From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#3375: FW: Fix "Document incompatible change to format of bookmarks" Date: Thu, 8 Oct 2009 23:20:42 -0700 Message-ID: <08D2B8259FBD400FB5F924D2B067AE69@us.oracle.com> Reply-To: Drew Adams , 3375@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1255073404 20229 80.91.229.12 (9 Oct 2009 07:30:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 9 Oct 2009 07:30:04 +0000 (UTC) To: <3375@emacsbugs.donarmstrong.com> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 09 09:29:54 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Mw9rh-0004LG-Ox for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 09:26:14 +0200 Original-Received: from localhost ([127.0.0.1]:43053 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mw9rh-0006ZV-5w for geb-bug-gnu-emacs@m.gmane.org; Fri, 09 Oct 2009 03:26:13 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mw9Ie-0006k5-Fo for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 02:50:00 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mw9IZ-0006fI-QD for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 02:49:59 -0400 Original-Received: from [199.232.76.173] (port=45211 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mw9IZ-0006f9-3a for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 02:49:55 -0400 Original-Received: from mx20.gnu.org ([199.232.41.8]:7213) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Mw9IY-0003n7-FK for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 02:49:54 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mw9IU-0007mI-Jd for bug-gnu-emacs@gnu.org; Fri, 09 Oct 2009 02:49:50 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n996l9IA020831; Thu, 8 Oct 2009 23:47:09 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.14.3/8.14.3/Submit) id n996U42G018187; Thu, 8 Oct 2009 23:30:04 -0700 Resent-Date: Thu, 8 Oct 2009 23:30:04 -0700 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Fri, 09 Oct 2009 06:30:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 3375 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 3375-submit@emacsbugs.donarmstrong.com id=B3375.125506934817404 (code B ref 3375); Fri, 09 Oct 2009 06:30:04 +0000 Original-Received: (at 3375) by emacsbugs.donarmstrong.com; 9 Oct 2009 06:22:28 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n996MQgs017401 for <3375@emacsbugs.donarmstrong.com>; Thu, 8 Oct 2009 23:22:28 -0700 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n996MXdZ016175 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <3375@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 06:22:34 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n9966IR9032467 for <3375@emacsbugs.donarmstrong.com>; Fri, 9 Oct 2009 06:23:11 GMT Original-Received: from abhmt019.oracle.com by acsmt357.oracle.com with ESMTP id 20306085251255069240; Fri, 09 Oct 2009 01:20:40 -0500 Original-Received: from dradamslap1 (/24.5.184.158) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 08 Oct 2009 23:20:39 -0700 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcpIoZ6G/0QVzZwxR3yB7SXjwnGrWAAAv66AAAD3DAA= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Source-IP: acsmt355.oracle.com [141.146.40.155] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4ACED69A.005B:SCFMA4539814,ss=1,fgs=0 X-detected-operating-system: by mx20.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Resent-Date: Fri, 09 Oct 2009 02:49:59 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:31805 Archived-At: Forgot to send to the bug thread. I keep forgetting that cc'ing the close message doesn't copy the actual bug thread. -----Original Message----- From: Drew Adams Sent: Thursday, October 08, 2009 11:18 PM To: 'Karl Fogel'; '3375-close@emacsbugs.donarmstrong.com' Subject: RE: Fix "Document incompatible change to format of bookmarks" > Thanks for the report. I've documented the format change in NEWS;... > > (I don't know why the default write-out format was changed, > as I didn't commit rev 1.114 of bookmark.el. We could investigate > and find out, but it would be of forensic interest only at this > point -- the change is made, and there's a long list of > bookmark.el bugs to go. So I'm not going to investigate the > reasoning behind 1.114 closely; if you happen to find out, > please let me know.) Thanks for adding the NEWS entry, Karl. It's really too bad that this incompatible change was made without anyone documenting the reason (at least I haven't found such documentation). Likewise, without any discussion (that I'm aware of). One can only hope that the change was truly necessary or at least somehow useful, for whatever unknown reason. The 1.114 log entry seems to suggest that it only adjusted some parts of the code to work with "the 2 slightly different formats used until now in bookmark.el's code." It's unclear what that text really tries to mean, but if it is suggesting that the new, Emacs 23 format was already in use in (some parts of) the bookmark code, then that's not true (assuming that you're right that 1.114 is the culprit, which it does seem to be). This is an incompatible change in the basic bookmark format, starting with Emacs 23 (apparently, starting with 1.114). It seems to be a gratuitous change, but how to tell, since no reason was given? I wonder if, in making that change, Stefan was aware that the format is new, or if he perhaps really thought that it had been in use previously. Perhaps he was confused by the misleading (incorrect) comments in the file. Dunno. And we'll likely never know, as you point out. Too bad. We've now had at least two incompatible format changes to the `bookmark-alist' structure, over its history. Neither of which brought anything useful to the party, AFAICT. Oh well. Let's hope that next year someone doesn't mutate the structure to a fourth format. ;-) Thx - Drew