From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Fri, 18 Dec 2020 04:06:05 +0200 Message-ID: <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26294"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: Glenn Morris , 29193@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 03:07:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kq5Ak-0006kD-6O for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 03:07:10 +0100 Original-Received: from localhost ([::1]:39748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kq5Aj-0007dk-85 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 17 Dec 2020 21:07:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kq5Ac-0007dV-GK for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 21:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54055) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kq5Ac-0002g0-8w for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 21:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kq5Ac-00039N-3d for bug-gnu-emacs@gnu.org; Thu, 17 Dec 2020 21:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 02:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160825717912057 (code B ref 29193); Fri, 18 Dec 2020 02:07:02 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 02:06:19 +0000 Original-Received: from localhost ([127.0.0.1]:37368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq59v-00038P-73 for submit@debbugs.gnu.org; Thu, 17 Dec 2020 21:06:19 -0500 Original-Received: from mail-wm1-f49.google.com ([209.85.128.49]:36729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kq59q-00038A-NS for 29193@debbugs.gnu.org; Thu, 17 Dec 2020 21:06:18 -0500 Original-Received: by mail-wm1-f49.google.com with SMTP id y23so833719wmi.1 for <29193@debbugs.gnu.org>; Thu, 17 Dec 2020 18:06:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=myMmEUIv+5rfBHyaeCT2dC5wTShkfv7a3ieXX19OU+8=; b=mH+MjGXVAPdxfll6CnhkHb3QYm+C3eFS1YPmH/VPukMROdxDaG74huMcFWnQF1y+RF 2kHx2nixBh8LZircv4wW2UGfVE0FHt8p3CcdClZwTvrIRWi4wtoRpir+2LJiz2iTcU0+ tQ9u0AN7eg0qqxFdimq3zjSxfzgYI7VcE+hoIRVy8UYkAvti8Yud6svGkWrHELcfjwo7 6sCxma8D18URRAaXatfzSyqqPXMalWQnZAMxs0xsTLmrIumBGA5s7FglOOQ+k5Bj8em2 JqxlRfl81jLA6MKo8XuiWAJwWlGqRKeURyi4jI+qFlA7eBq779KWSgMmVWRHruP2Pl3+ hYbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=myMmEUIv+5rfBHyaeCT2dC5wTShkfv7a3ieXX19OU+8=; b=pMJub7Guf3lrJu9ogGOsHlxV9jpge06SdLXUltqCxbesSF+5zepn+8AiY3Yg83oymT BIDnUxqLipycvqjnPeWomrB53huHMEGAECRIN39MHq72FXOTBayrfHvnUUTOSTcIdknZ OdS+N7pGJ6yeyvCChJ3JLvqkyZ8pIHq8WMwGtZVngvneHhxDx9/5siJwATteerhvNjqi O7MtpRCTVscDQvuSNCZeTUkY0ReFteWmiWfPxk32baycpqiwlpMP/2rdhXG3cTCDFdYR tZKl82WWJTZ3RqTadvksh5fGpDCvb07+gRkfptAagiWNvZ5Pkak8LTS6tLHbJbqZwRa+ G45A== X-Gm-Message-State: AOAM533v02x9QjUBzPrcT8vimM+izF3wwcgNZNAH8f93I6OhK13Xf9iT W6H268JqKa0zdBIs79dswEXCzg+VbB1+Rw== X-Google-Smtp-Source: ABdhPJziaH6ja4sNQjwIGCNjN1BB+s1VRLg6R2bq5tzLScI3HeL4HDhbMUg2SxHFpImbrblxEJzgDw== X-Received: by 2002:a7b:c4d5:: with SMTP id g21mr1977693wmk.92.1608257168544; Thu, 17 Dec 2020 18:06:08 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id t1sm12122413wro.27.2020.12.17.18.06.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Dec 2020 18:06:07 -0800 (PST) In-Reply-To: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196301 Archived-At: On 18.12.2020 01:25, Glenn Morris wrote: > fda9a2 causes a test failure. > > Ref eg:https://hydra.nixos.org/build/132986117 Thanks! It was a curious bug: one would expect that some highlighting's boundaries might change. What changed, however, is one's _type_. I've pushed a fix, and I'll let the Flymake's maintainer sort out at his leisure whether flymake-diag-region can be relied on not to change match data, as several of its clients seem to assume. > (Are people trying to run foo-tests.el before pushing changes to foo.el?) Some of us are spoiled enough to expect an email from the CI when some breakage occurs. (Sorry.)