From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Date: Mon, 30 Oct 2017 07:32:59 -0700 (PDT) Message-ID: <07ad0bf0-ecf4-4c0c-97c5-665e1ec77312@default> References: <4d0c5535-246a-4356-914f-3c8d030ba9c9@default> <59F0412F.9090206@gmx.at> <22c73180-e9a6-416f-9e28-da98d07908f8@default> <59F1957F.80900@gmx.at> <59F2ED8C.3010400@gmx.at> <31caab4d-f332-48a7-9736-ccd172073672@default> <59F443A7.1020207@gmx.at> <4851dc90-59c3-49a9-b03c-add382e9b8bf@default> <59F5B8F1.1050909@gmx.at> <59F61A30.30300@gmx.at> <2cb4dbe7-57a6-4a87-9897-224f2d602abe@default> <59F6E1C9.5030702@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1509374067 27224 195.159.176.226 (30 Oct 2017 14:34:27 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 30 Oct 2017 14:34:27 +0000 (UTC) To: martin rudalics , 28978-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Oct 30 15:34:22 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9B8q-0006DL-PZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 15:34:17 +0100 Original-Received: from localhost ([::1]:40936 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9B8y-0006Hz-0E for geb-bug-gnu-emacs@m.gmane.org; Mon, 30 Oct 2017 10:34:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40417) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e9B8g-0006Bg-3B for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 10:34:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e9B8c-0003g8-1I for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 10:34:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:33640) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e9B8b-0003g0-Ti for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 10:34:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e9B8b-00015K-NG for bug-gnu-emacs@gnu.org; Mon, 30 Oct 2017 10:34:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Oct 2017 14:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28978-done@debbugs.gnu.org id=D28978.15093739914070 (code D ref 28978); Mon, 30 Oct 2017 14:34:01 +0000 Original-Received: (at 28978-done) by debbugs.gnu.org; 30 Oct 2017 14:33:11 +0000 Original-Received: from localhost ([127.0.0.1]:42311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9B7m-00013a-Q0 for submit@debbugs.gnu.org; Mon, 30 Oct 2017 10:33:11 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:34999) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e9B7l-00013O-AH for 28978-done@debbugs.gnu.org; Mon, 30 Oct 2017 10:33:09 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v9UEX1vf010058 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Oct 2017 14:33:01 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v9UEX0gJ029376 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 Oct 2017 14:33:01 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v9UEX02h031490; Mon, 30 Oct 2017 14:33:00 GMT In-Reply-To: <59F6E1C9.5030702@gmx.at> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:139181 Archived-At: > > I was checking the `minibuffer' parameter of THIS-FRAME, > > to see if it was the `active-minibuffer-window'. But it > > should be just as good to check that the frame of the > > `active-minibuffer-window' is THIS-FRAME. > > > > I don't think the code you showed earlier corresponds to > > the same thing. IIUC, the test you suggested earlier > > checks whether the window that was selected immediately > > before the current minibuffer window was selected is the > > same as the selected window of THIS-FRAME. That's not > > the same thing as what I need to test, AFAICT. But your > > latest suggestion seems to check what I've been checking, > > and it should work OK in all Emacs versions. >=20 > If you told me with plain words what you really wanted to check then I > might come up with another suggestion. But "checking the `minibuffer' > parameter of THIS-FRAME, to see if it was the > `active-minibuffer-window'" could not have possibly done anything > reasonable even before my changes. That test simply failed/succeeded > accidentally with Emacs 25 and just produces the opposite result with > Emacs 26. It not only could possibly have done something reasonable before your changes, it did something reasonable, useful, and necessary before your changes. And as I said: in ALL Emacs releases. I think the alternative code you proposed will likely work as well (thank you), but there is no reason to claim that the previous code did not work or did nothing reasonable. Before your change, a separate *Completions* frame didn't have a minibuffer-window value for its frame parameter `minibuffer' - it used another frame's minibuffer. Before your change checking that parameter was a reasonable way to check whether the frame had an active minibuffer window. > > Return the window that was selected immediately > > before the current minibuffer window was selected. >=20 > Looks good but I need a first line that fits into 67 characters. Pretty > please suggest a suitable first line and whatever you consider important > for the rest. Also, since we nowhere specify "the current minibuffer > window" wouldn't "the currently active minibuffer window" be better? Return window selected just before minibuffer window was selected. or even Return window selected just before minibuffer window. Or if this is about an _active_ minibuffer then perhaps: Return window selected just before window of active minibuffer. I don't think "currently active minibuffer window" is the same thing as currently selected minibuffer window. For one thing, a window is not "active". (Nor is it "current", you will say, and that's right.) You probably meant "window of the active minibuffer". For another thing, if a minibuffer window is selected does that necessarily mean that the minibuffer is active? I don't think so, but I'm not an expert in this stuff. Thanks for fixing this.