From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.comp.lib.gnulib.bugs,gmane.emacs.devel Subject: Re: New warnings on emacs-26 branch with gcc 8.2.0 Date: Sat, 18 Aug 2018 10:19:54 -0700 Organization: UCLA Computer Science Department Message-ID: <0771b7a4-cc93-e23e-0de5-0069ce67a270@cs.ucla.edu> References: <86a7q0ai2z.fsf@gmail.com> <86y3d88x1u.fsf@gmail.com> <9ab72594-da61-a3f4-cac4-6e61cda67da3@cs.ucla.edu> <4195986.6xTypejAr3@omega> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1534613209 13819 195.159.176.226 (18 Aug 2018 17:26:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 18 Aug 2018 17:26:49 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: Andy Moreton , emacs-devel@gnu.org To: Bruno Haible , bug-gnulib@gnu.org Original-X-From: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Sat Aug 18 19:26:45 2018 Return-path: Envelope-to: gnu-bug-gnulib@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fr4zs-0003Ms-Qd for gnu-bug-gnulib@m.gmane.org; Sat, 18 Aug 2018 19:26:44 +0200 Original-Received: from localhost ([::1]:39874 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr51u-0002SW-7r for gnu-bug-gnulib@m.gmane.org; Sat, 18 Aug 2018 13:28:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fr51f-00027D-9W for bug-gnulib@gnu.org; Sat, 18 Aug 2018 13:28:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fr4uv-00061C-TU for bug-gnulib@gnu.org; Sat, 18 Aug 2018 13:21:42 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:56032) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fr4uv-0005zt-Ks; Sat, 18 Aug 2018 13:21:37 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13BA5160F92; Sat, 18 Aug 2018 10:21:36 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id Wot3jx2u-xPZ; Sat, 18 Aug 2018 10:21:35 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2BB92161130; Sat, 18 Aug 2018 10:21:35 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XGVPNaVU484V; Sat, 18 Aug 2018 10:19:58 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C8AC31610C0; Sat, 18 Aug 2018 10:19:57 -0700 (PDT) In-Reply-To: <4195986.6xTypejAr3@omega> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: bug-gnulib@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Gnulib discussion list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnulib-bounces+gnu-bug-gnulib=m.gmane.org@gnu.org Original-Sender: "bug-gnulib" Xref: news.gmane.org gmane.comp.lib.gnulib.bugs:39208 gmane.emacs.devel:228661 Archived-At: Bruno Haible wrote: > This code uses GetProcAddress so that it can exploit > features of newer Windows versions while at the same time still > work on older Windows versions. Can this problem be addressed a bit better by using GetProcAddress only inside #ifndef HAVE_GETSYSTEMTIMEPRECISEASFILETIME code on builds for MS-Windows 7 and earlier, and directly using GetSystemTimePreciseAsFileTime on builds for MS-Windows 8 and later? That should fix the warning on builds for newer MS-Windows, which might be good enough. > 3) Remove -Wcast-function-type from the compiler options. If we do this in Emacs builds, it should be done only for MS-Windows since the warning is generally useful on other platforms.