Logging state change with timestamp, but without note

Logging state change with timestamp, but without note

[Wanrong Lin]

Hi,

I would like to record down the time stamp when a TODO item changed its
state into some specific states (like "DELEGATED"), but I don't want to
be prompt with a window for notes. I might be able to do that by putting
those states into the DONE state and adding (setq org-log-done t) into
the config, however, conceptually that is not correct (as DELEGATED is
not really DONE) and hence I am afraid it will cause some other side
effects. Is there a good way I can do so?

Thanks a lot for your help.

Wanrong

Re: Logging state change with timestamp, but without note

[Bastien Guerry]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

Wanrong Lin <wanrong.lin@gmail.com> writes:

> I would like to record down the time stamp when a TODO item changed its
> state into some specific states (like "DELEGATED"), but I don't want to
> be prompt with a window for notes. 

I like the idea.

Here is a patch against latest org.el from git that implements something
that might suits your needs.

If you add "%!" to one of the heading in `org-log-note-headings' then
Org doesn't pop up a new buffer, the log is filled automatically.

(setq org-log-note-headings 
      '((done . "CLOSING NOTE %t") 
        (state . "State %-12s %t%!") 
        (clock-out . ""))))

Carsten, if you like it, I push it and update the manual accordingly.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: org.el.patch --]
[-- Type: text/x-diff, Size: 3734 bytes --]

diff --git a/org.el b/org.el
index d33d0ad..dd48e1d 100644
--- a/org.el
+++ b/org.el
@@ -14893,30 +14893,36 @@ The auto-repeater uses this.")
 (defun org-add-log-note (&optional purpose)
   "Pop up a window for taking a note, and add this note later at point."
   (remove-hook 'post-command-hook 'org-add-log-note)
-  (setq org-log-note-window-configuration (current-window-configuration))
-  (delete-other-windows)
-  (move-marker org-log-note-return-to (point))
-  (switch-to-buffer (marker-buffer org-log-note-marker))
-  (goto-char org-log-note-marker)
-  (org-switch-to-buffer-other-window "*Org Note*")
-  (erase-buffer)
-  (let ((org-inhibit-startup t)) (org-mode))
-  (insert (format "# Insert note for %s.
+  (catch 'exit 
+    (when (string-match 
+	   "%!"	(cdr (assq org-log-note-purpose org-log-note-headings)))
+      ;; The note should be construed and filled silently
+      (org-store-log-note t)
+      (throw 'exit t))
+    (setq org-log-note-window-configuration (current-window-configuration))
+    (delete-other-windows)
+    (move-marker org-log-note-return-to (point))
+    (switch-to-buffer (marker-buffer org-log-note-marker))
+    (goto-char org-log-note-marker)
+    (org-switch-to-buffer-other-window "*Org Note*")
+    (erase-buffer)
+    (let ((org-inhibit-startup t)) (org-mode))
+    (insert (format "# Insert note for %s.
 # Finish with C-c C-c, or cancel with C-c C-k.\n\n"
-		  (cond
-		   ((eq org-log-note-purpose 'clock-out) "stopped clock")
-		   ((eq org-log-note-purpose 'done)  "closed todo item")
-		   ((eq org-log-note-purpose 'state)
-		    (format "state change to \"%s\"" org-log-note-state))
-		   (t (error "This should not happen")))))
-  (org-set-local 'org-finish-function 'org-store-log-note))
-
-(defun org-store-log-note ()
+		    (cond
+		     ((eq org-log-note-purpose 'clock-out) "stopped clock")
+		     ((eq org-log-note-purpose 'done)  "closed todo item")
+		     ((eq org-log-note-purpose 'state)
+		      (format "state change to \"%s\"" org-log-note-state))
+		     (t (error "This should not happen")))))
+    (org-set-local 'org-finish-function 'org-store-log-note)))
+
+(defun org-store-log-note (&optional auto-note)
   "Finish taking a log note, and insert it to where it belongs."
-  (let ((txt (buffer-string))
+  (let ((txt (if auto-note "" (buffer-string)))
 	(note (cdr (assq org-log-note-purpose org-log-note-headings)))
 	lines ind)
-    (kill-buffer (current-buffer))
+    (unless auto-note (kill-buffer (current-buffer)))
     (while (string-match "\\`#.*\n[ \t\n]*" txt)
       (setq txt (replace-match "" t t txt)))
     (if (string-match "\\s-+\\'" txt)
@@ -14933,7 +14939,8 @@ The auto-repeater uses this.")
 			       (current-time)))
 		   (cons "%s" (if org-log-note-state
 				  (concat "\"" org-log-note-state "\"")
-				"")))))
+				""))
+		   (cons "%!" ""))))
       (if lines (setq note (concat note " \\\\")))
       (push note lines))
     (when (or current-prefix-arg org-note-abort) (setq lines nil))
@@ -14953,10 +14960,11 @@ The auto-repeater uses this.")
 	  (setq ind (concat (match-string 0) "  "))
 	  (end-of-line 1)
 	  (while lines (insert "\n" ind (pop lines)))))))
-  (set-window-configuration org-log-note-window-configuration)
-  (with-current-buffer (marker-buffer org-log-note-return-to)
-    (goto-char org-log-note-return-to))
-  (move-marker org-log-note-return-to nil)
+  (unless auto-note
+    (set-window-configuration org-log-note-window-configuration)
+    (with-current-buffer (marker-buffer org-log-note-return-to)
+      (goto-char org-log-note-return-to))
+    (move-marker org-log-note-return-to nil))
   (and org-log-post-message (message "%s" org-log-post-message)))
 
 ;; FIXME: what else would be useful?

[-- Attachment #3: Type: text/plain, Size: 13 bytes --]


-- 
Bastien

[-- Attachment #4: Type: text/plain, Size: 204 bytes --]

_______________________________________________
Emacs-orgmode mailing list
Remember: use `Reply All' to send replies to the list.
Emacs-orgmode@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Logging state change with timestamp, but without note

[Carsten Dominik]

Hi Bastien,

I am not sure this i a complete enough solution.  If I understand  
Wanrong correctly,
I think he wants to be able to define the specific states that should  
record a time.

So I guess a complete solution would be to introduce a character like  
"!", similar to the "@" we are already using to denote taking a note.   
So

#+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)

would record a note when switching to WAITING, and only a time when  
switching to CANCELED.

- Carsten


On Feb 14, 2008, at 3:53 AM, Bastien Guerry wrote:

> Wanrong Lin <wanrong.lin@gmail.com> writes:
>
>> I would like to record down the time stamp when a TODO item changed  
>> its
>> state into some specific states (like "DELEGATED"), but I don't  
>> want to
>> be prompt with a window for notes.
>
> I like the idea.
>
> Here is a patch against latest org.el from git that implements  
> something
> that might suits your needs.
>
> If you add "%!" to one of the heading in `org-log-note-headings' then
> Org doesn't pop up a new buffer, the log is filled automatically.
>
> (setq org-log-note-headings
>      '((done . "CLOSING NOTE %t")
>        (state . "State %-12s %t%!")
>        (clock-out . ""))))
>
> Carsten, if you like it, I push it and update the manual accordingly.
>
> <org.el.patch>
> -- 
> Bastien

Re: Logging state change with timestamp, but without note

[Bastien]

Carsten Dominik <dominik@science.uva.nl> writes:

> I am not sure this i a complete enough solution.  If I understand Wanrong
> correctly,
> I think he wants to be able to define the specific states that should
> record a time.

Yes, my patch was just doing part of the job.  I wanted to check whether
such a workaround would be hard to implement.

> So I guess a complete solution would be to introduce a character like "!",
> similar to the "@" we are already using to denote taking a note.   So
>
> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>
> would record a note when switching to WAITING, and only a time when
> switching to CANCELED.

Indeed.  

Do you want me to work on this?

BTW I think letting "%!" in `org-log-note-headings' would still be
useful.  

For example, if someone uses "#+STARTUP: lognotedone", then any switch
to a DONE state will require a note, no matter whether there is a "@"
cookie appended at the end of the DONE state or not.  In this case, I
guess some people would find it useful to put "%!" in the 'done cell of
`org-log-note-headings'.

What do you think?  Would that be too much or a bit redundant?

-- 
Bastien

Re: Logging state change with timestamp, but without note

[Carsten Dominik]

On Feb 14, 2008, at 2:43 PM, Bastien wrote:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> I am not sure this i a complete enough solution.  If I understand  
>> Wanrong
>> correctly,
>> I think he wants to be able to define the specific states that should
>> record a time.
>
> Yes, my patch was just doing part of the job.  I wanted to check  
> whether
> such a workaround would be hard to implement.
>
>> So I guess a complete solution would be to introduce a character  
>> like "!",
>> similar to the "@" we are already using to denote taking a note.   So
>>
>> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>>
>> would record a note when switching to WAITING, and only a time when
>> switching to CANCELED.
>
> Indeed.
>
> Do you want me to work on this?
>
> BTW I think letting "%!" in `org-log-note-headings' would still be
> useful.
>
> For example, if someone uses "#+STARTUP: lognotedone", then any switch
> to a DONE state will require a note, no matter whether there is a "@"
> cookie appended at the end of the DONE state or not.  In this case, I
> guess some people would find it useful to put "%!" in the 'done cell  
> of
> `org-log-note-headings'.
>
> What do you think?  Would that be too much or a bit redundant?

I guess a different way would be

#+STARTUP: logstate

in analogy to logdone?

- Carsten


>
>
> -- 
> Bastien

Re: Logging state change with timestamp, but without note

[Carsten Dominik]

On Feb 14, 2008, at 2:43 PM, Bastien wrote:

> Carsten Dominik <dominik@science.uva.nl> writes:
>
>> I am not sure this i a complete enough solution.  If I understand  
>> Wanrong
>> correctly,
>> I think he wants to be able to define the specific states that should
>> record a time.
>
> Yes, my patch was just doing part of the job.  I wanted to check  
> whether
> such a workaround would be hard to implement.
>
>> So I guess a complete solution would be to introduce a character  
>> like "!",
>> similar to the "@" we are already using to denote taking a note.   So
>>
>> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>>
>> would record a note when switching to WAITING, and only a time when
>> switching to CANCELED.
>
> Indeed.
>
> Do you want me to work on this?

Well let me do this, I know this code well.  To be honest, I'd much  
rather have you focus on the exporter.... :-)

>
>
> BTW I think letting "%!" in `org-log-note-headings' would still be
> useful.
>
> For example, if someone uses "#+STARTUP: lognotedone", then any switch
> to a DONE state will require a note, no matter whether there is a "@"
> cookie appended at the end of the DONE state or not.  In this case, I
> guess some people would find it useful to put "%!" in the 'done cell  
> of
> `org-log-note-headings'.
>
> What do you think?  Would that be too much or a bit redundant?
>
> -- 
> Bastien

Re: Logging state change with timestamp, but without note

[Wanrong Lin]

Hi, Carsten and Bastien,

Thanks a lot for putting a lot of thought on this. I always get more 
than I asked for here, which is rare in life. :-)

Just one more question though: Are we going to make the "CANCELED(c!)" 
notation also a global option (vs per-file option) when we define the 
TODO states in .emacs? I almost never use per-file options (except for 
exporting) as I want to stick to one simple set-up everywhere.

Thank you.

Wanrong

Carsten Dominik wrote:
> Hi Bastien,
>
> I am not sure this i a complete enough solution.  If I understand 
> Wanrong correctly,
> I think he wants to be able to define the specific states that should 
> record a time.
>
> So I guess a complete solution would be to introduce a character like 
> "!", similar to the "@" we are already using to denote taking a note.  So
>
> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>
> would record a note when switching to WAITING, and only a time when 
> switching to CANCELED.
>
> - Carsten
>
>
> On Feb 14, 2008, at 3:53 AM, Bastien Guerry wrote:
>
>> Wanrong Lin <wanrong.lin@gmail.com> writes:
>>
>>> I would like to record down the time stamp when a TODO item changed its
>>> state into some specific states (like "DELEGATED"), but I don't want to
>>> be prompt with a window for notes.
>>
>> I like the idea.
>>
>> Here is a patch against latest org.el from git that implements something
>> that might suits your needs.
>>
>> If you add "%!" to one of the heading in `org-log-note-headings' then
>> Org doesn't pop up a new buffer, the log is filled automatically.
>>
>> (setq org-log-note-headings
>>      '((done . "CLOSING NOTE %t")
>>        (state . "State %-12s %t%!")
>>        (clock-out . ""))))
>>
>> Carsten, if you like it, I push it and update the manual accordingly.
>>
>> <org.el.patch>
>> -- 
>> Bastien
>

Re: Logging state change with timestamp, but without note

[Carsten Dominik]

On Feb 14, 2008, at 4:09 PM, Wanrong Lin wrote:

>
> Hi, Carsten and Bastien,
>
> Thanks a lot for putting a lot of thought on this. I always get more  
> than I asked for here, which is rare in life. :-)
>
> Just one more question though: Are we going to make the  
> "CANCELED(c!)" notation also a global option (vs per-file option)  
> when we define the TODO states in .emacs? I almost never use per- 
> file options (except for exporting) as I want to stick to one simple  
> set-up everywhere.


Yes, obviously.

- Carsten

>
>
> Thank you.
>
> Wanrong
>
> Carsten Dominik wrote:
>> Hi Bastien,
>>
>> I am not sure this i a complete enough solution.  If I understand  
>> Wanrong correctly,
>> I think he wants to be able to define the specific states that  
>> should record a time.
>>
>> So I guess a complete solution would be to introduce a character  
>> like "!", similar to the "@" we are already using to denote taking  
>> a note.  So
>>
>> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>>
>> would record a note when switching to WAITING, and only a time when  
>> switching to CANCELED.
>>
>> - Carsten
>>
>>
>> On Feb 14, 2008, at 3:53 AM, Bastien Guerry wrote:
>>
>>> Wanrong Lin <wanrong.lin@gmail.com> writes:
>>>
>>>> I would like to record down the time stamp when a TODO item  
>>>> changed its
>>>> state into some specific states (like "DELEGATED"), but I don't  
>>>> want to
>>>> be prompt with a window for notes.
>>>
>>> I like the idea.
>>>
>>> Here is a patch against latest org.el from git that implements  
>>> something
>>> that might suits your needs.
>>>
>>> If you add "%!" to one of the heading in `org-log-note-headings'  
>>> then
>>> Org doesn't pop up a new buffer, the log is filled automatically.
>>>
>>> (setq org-log-note-headings
>>>     '((done . "CLOSING NOTE %t")
>>>       (state . "State %-12s %t%!")
>>>       (clock-out . ""))))
>>>
>>> Carsten, if you like it, I push it and update the manual  
>>> accordingly.
>>>
>>> <org.el.patch>
>>> -- 
>>> Bastien
>>
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Logging state change with timestamp, but without note

[Carsten Dominik]

This is in the git repo now.

- Carsten

On Feb 14, 2008, at 1:50 PM, Carsten Dominik wrote:

> Hi Bastien,
>
> I am not sure this i a complete enough solution.  If I understand  
> Wanrong correctly,
> I think he wants to be able to define the specific states that  
> should record a time.
>
> So I guess a complete solution would be to introduce a character  
> like "!", similar to the "@" we are already using to denote taking a  
> note.  So
>
> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>
> would record a note when switching to WAITING, and only a time when  
> switching to CANCELED.
>
> - Carsten
>
>
> On Feb 14, 2008, at 3:53 AM, Bastien Guerry wrote:
>
>> Wanrong Lin <wanrong.lin@gmail.com> writes:
>>
>>> I would like to record down the time stamp when a TODO item  
>>> changed its
>>> state into some specific states (like "DELEGATED"), but I don't  
>>> want to
>>> be prompt with a window for notes.
>>
>> I like the idea.
>>
>> Here is a patch against latest org.el from git that implements  
>> something
>> that might suits your needs.
>>
>> If you add "%!" to one of the heading in `org-log-note-headings' then
>> Org doesn't pop up a new buffer, the log is filled automatically.
>>
>> (setq org-log-note-headings
>>     '((done . "CLOSING NOTE %t")
>>       (state . "State %-12s %t%!")
>>       (clock-out . ""))))
>>
>> Carsten, if you like it, I push it and update the manual accordingly.
>>
>> <org.el.patch>
>> -- 
>> Bastien
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Logging state change with timestamp, but without note

[Wanrong Lin]

Thanks a lot. I have not got time to learn git yet (I was told it is 
hard to get it working under windows), so I will wait for the next 
release to try the feature.

Wanrong

Carsten Dominik wrote:
> This is in the git repo now.
>
> - Carsten
>
> On Feb 14, 2008, at 1:50 PM, Carsten Dominik wrote:
>
>> Hi Bastien,
>>
>> I am not sure this i a complete enough solution.  If I understand 
>> Wanrong correctly,
>> I think he wants to be able to define the specific states that should 
>> record a time.
>>
>> So I guess a complete solution would be to introduce a character like 
>> "!", similar to the "@" we are already using to denote taking a 
>> note.  So
>>
>> #+TODO: TODO(t) WAITING(w@) | DELEGATED DONE CANCELED(c!)
>>
>> would record a note when switching to WAITING, and only a time when 
>> switching to CANCELED.
>>
>> - Carsten
>>
>>
>> On Feb 14, 2008, at 3:53 AM, Bastien Guerry wrote:
>>
>>> Wanrong Lin <wanrong.lin@gmail.com> writes:
>>>
>>>> I would like to record down the time stamp when a TODO item changed 
>>>> its
>>>> state into some specific states (like "DELEGATED"), but I don't 
>>>> want to
>>>> be prompt with a window for notes.
>>>
>>> I like the idea.
>>>
>>> Here is a patch against latest org.el from git that implements 
>>> something
>>> that might suits your needs.
>>>
>>> If you add "%!" to one of the heading in `org-log-note-headings' then
>>> Org doesn't pop up a new buffer, the log is filled automatically.
>>>
>>> (setq org-log-note-headings
>>>     '((done . "CLOSING NOTE %t")
>>>       (state . "State %-12s %t%!")
>>>       (clock-out . ""))))
>>>
>>> Carsten, if you like it, I push it and update the manual accordingly.
>>>
>>> <org.el.patch>
>>> -- 
>>> Bastien
>>
>>
>>
>> _______________________________________________
>> Emacs-orgmode mailing list
>> Remember: use `Reply All' to send replies to the list.
>> Emacs-orgmode@gnu.org
>> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
>
>
>
> _______________________________________________
> Emacs-orgmode mailing list
> Remember: use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode

Re: Logging state change with timestamp, but without note

[Bernt Hansen]

Wanrong Lin <wrglin@gmail.com> writes:

> Thanks a lot. I have not got time to learn git yet (I was told it is
> hard to get it working under windows), so I will wait for the next
> release to try the feature.

Try MSysGit

http://code.google.com/p/msysgit/

You can download it from here

http://code.google.com/p/msysgit/downloads/list

It's still beta but it works...  I'm using that on windows.

So ... install it
Start the git bash shell (you should get an icon on your desktop)

create a directory for your git repositories

$ mkdir git

$ cd git

Clone the org-mode repository

$ git clone git://repo.or.cz/org-mode.git

And you should be all set...

Bernt