From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Uberti Newsgroups: gmane.emacs.devel Subject: project--files-in-directory: code formatting Date: Wed, 4 Nov 2020 14:26:21 +0100 Message-ID: <0751c421-d860-2d79-74ee-52806d46fc13@inventati.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2991"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Nov 04 14:32:30 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kaItp-0000hG-9E for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 14:32:29 +0100 Original-Received: from localhost ([::1]:39004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaIto-00034n-62 for ged-emacs-devel@m.gmane-mx.org; Wed, 04 Nov 2020 08:32:28 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaIoA-0007Rr-0i for emacs-devel@gnu.org; Wed, 04 Nov 2020 08:26:40 -0500 Original-Received: from confino.investici.org ([212.103.72.250]:32791) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kaIo0-0000w2-F3 for emacs-devel@gnu.org; Wed, 04 Nov 2020 08:26:36 -0500 Original-Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4CR6qg0Rkhz1101 for ; Wed, 4 Nov 2020 13:26:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inventati.org; s=stigmate; t=1604496383; bh=nW+NyXmt7y/pM+xfDp382ha+BSREHEUa0MpBh9Br3p4=; h=To:From:Subject:Date:From; b=ENPcvXAmRJFZiOUz/MHe1jjkWDOy+0Y2jYsrIrvV+Da9tSKunEamX0HdYysv200u2 TxGUlfzBf41rl0oAGPF1s+SKOXA07bOAzucDtfOtrUORVbK4gJlrE6o7TbkptizO6x WKe/P9KsUqrM83M2QteXay73ZEY8sak8O74+xc3g= Original-Received: from [212.103.72.250] (mx1.investici.org [212.103.72.250]) (Authenticated sender: manuel.uberti@inventati.org) by localhost (Postfix) with ESMTPSA id 4CR6qf5ZY1z10y8 for ; Wed, 4 Nov 2020 13:26:22 +0000 (UTC) Autocrypt: addr=manuel.uberti@inventati.org; prefer-encrypt=mutual; keydata= mQENBFTh+8QBCADM+TpOAlO6NIM+GCSLZd4hZQCU2WV7Z1cLYLnE2NHdEaKGnaVlkcf9dGeL 6nlX7j20AYL7KqF4h9IX5d4lc1w8Izk0V2ijtqNeqbRdiTZ8mF+cFEwbALjHIs/YNUjr8IMK pJ+5rQ4DN6dsLVuJ7NJCB54AtAqqvoTodEPxLCT2Gq6YyGaobiEGeczk/3SPsQZYQnKfJ2zM JxIQDy4Dg9owrPpX/WWOfmcTkDoWovX9nsojErYXhIXP7r6+V3cV9stQeOwMhfmnZ1k7LO7y tyvYNIZGfh+JrYBakGttYGSj/C47hJV9MBiY08/Wr3QeDVtV7UTB5qXVYMrYQk63UssNABEB AAG0QU1hbnVlbCBVYmVydGkgKEF1dGlzdGljaS9JbnZlbnRhdGkpIDxtYW51ZWwudWJlcnRp QGludmVudGF0aS5vcmc+iQE6BBMBCgAkAhsDBQsJCAcDBRUKCQgLBRYCAwEAAh4BAheABQJZ pBuqAhkBAAoJEE5XpsTKpI9iEBoIAJLAIZfNVT2KoO9iMM92kuCih6BA1lvpDWreoqRvwW8A iEnS6pwvpiuXldhZgcB4drpy97XBudBFx/b96Sqb4RvGxIHKpt4oLlpXzcohL28oP1CJiN+O bHEbRhzF8fuTrNh7v76z88WRkplUT/7nrO7YLVOM2DS/2QYccOrPkW4C5F03JyVkzSNisz5R VcmUTWcdnqo8VBd/DP3P96ayRj3VPKa9IdQIAxbjbhP+kEQbq9XDiZpGpcOHhFjWeLAWlFCm nES1C7Wb Content-Language: en-GB Received-SPF: pass client-ip=212.103.72.250; envelope-from=manuel.uberti@inventati.org; helo=confino.investici.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/04 08:26:23 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258674 Archived-At: Hello, I noticed this piece of code in project.el (line 292 on master): (command (format "%s %s %s -type f %s -print0" find-program localdir (xref--find-ignores-arguments ignores localdir) (if files (concat (shell-quote-argument "(") " " find-name-arg " " (mapconcat #'shell-quote-argument (split-string files) (concat " -o " find-name-arg " ")) " " (shell-quote-argument ")"))"") )) Woudln't it be cleaner formatted this way? (command (format "%s %s %s -type f %s -print0" find-program localdir (xref--find-ignores-arguments ignores localdir) (if files (concat (shell-quote-argument "(") " " find-name-arg " " (mapconcat #'shell-quote-argument (split-string files) (concat " -o " find-name-arg " ")) " " (shell-quote-argument ")")) ""))) Basically, the "else" of "if files..." on a new line, with the remaining parenthesis on the same line as this "else". What do you think? Since this is not really a bug I didn't open one for it, but I can do it if you prefer so. Also, I understand this is mostly a matter of personal preferences, so feel free to ignore this email. All te best -- Manuel Uberti www.manueluberti.eu