all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Vitalie Spinu'" <spinuvit@gmail.com>,
	"'Andreas Schwab'" <schwab@linux-m68k.org>
Cc: 14254@debbugs.gnu.org
Subject: bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number toblame)
Date: Wed, 24 Apr 2013 08:13:41 -0700	[thread overview]
Message-ID: <0751605D820C43538A0D17CED57E237E@us.oracle.com> (raw)
In-Reply-To: <877gjsast7.fsf@gmail.com>

>  >> Now (string-to-number "junk") returns 0.
> 
>  > It always did, as documented.
> 
> That presumably means that read-number never worked as originally
> expected. The comment in source file says that read-number should be
> used for "n" interactive spec, but "n" spec works as expected, so
> read-number is not used there.
> 
> Wouldn't it be more natural for string-to-number to return nil rather
> than 0 in a non-number case?

See my last reply.  It's not about `string-to-number'.  It's about
`read-number'.  

And no, it has always worked as expected, up through Emacs 24.2.  It was broken
in 24.3, by changing (read str) to (string-to-number str).






  reply	other threads:[~2013-04-24 15:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 12:46 bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number to blame) Vitalie Spinu
2013-04-24 13:09 ` bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number toblame) Drew Adams
2013-04-24 14:21 ` bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number to blame) Andreas Schwab
2013-04-24 14:44   ` bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number toblame) Drew Adams
2013-04-24 14:48   ` bug#14254: 24.3; read-number fails to recognize faulty numbers (string-to-number to blame) Vitalie Spinu
2013-04-24 15:13     ` Drew Adams [this message]
2013-04-24 17:29 ` Glenn Morris
2013-04-24 20:57 ` Juri Linkov
2013-04-25  3:33   ` Stefan Monnier
2013-04-25 20:44     ` Juri Linkov
2013-04-26  1:46       ` Stefan Monnier
2013-05-07  8:42       ` Juri Linkov
2013-05-07 13:38         ` Stefan Monnier
2013-05-07 20:51           ` Juri Linkov
2013-05-07 21:31             ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0751605D820C43538A0D17CED57E237E@us.oracle.com \
    --to=drew.adams@oracle.com \
    --cc=14254@debbugs.gnu.org \
    --cc=schwab@linux-m68k.org \
    --cc=spinuvit@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.