From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#27840: 26.0.50; vc-git-grep stopped working on git master Date: Thu, 27 Jul 2017 16:23:06 +0300 Message-ID: <07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru> References: <87shhj3wtc.fsf@pokyo> <87inie93lp.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1501161856 21200 195.159.176.226 (27 Jul 2017 13:24:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 27 Jul 2017 13:24:16 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Thunderbird/55.0 Cc: 27840@debbugs.gnu.org To: npostavs@users.sourceforge.net, Tom Tromey Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 27 15:24:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dailr-000559-To for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jul 2017 15:24:08 +0200 Original-Received: from localhost ([::1]:43011 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dailx-0006PQ-E2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 27 Jul 2017 09:24:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dailr-0006PL-2m for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 09:24:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dailm-0005qC-2f for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 09:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55401) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daill-0005pz-VD for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 09:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1daill-0002jh-Nz for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2017 09:24:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2017 13:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27840 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 27840-submit@debbugs.gnu.org id=B27840.150116179710458 (code B ref 27840); Thu, 27 Jul 2017 13:24:01 +0000 Original-Received: (at 27840) by debbugs.gnu.org; 27 Jul 2017 13:23:17 +0000 Original-Received: from localhost ([127.0.0.1]:58078 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dail3-0002ic-M1 for submit@debbugs.gnu.org; Thu, 27 Jul 2017 09:23:17 -0400 Original-Received: from mail-wr0-f181.google.com ([209.85.128.181]:35869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dail2-0002iO-ET for 27840@debbugs.gnu.org; Thu, 27 Jul 2017 09:23:16 -0400 Original-Received: by mail-wr0-f181.google.com with SMTP id y43so143577974wrd.3 for <27840@debbugs.gnu.org>; Thu, 27 Jul 2017 06:23:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KNq5hK0jhIXBkjJQBE52uTqzvuIV0TTQfTposU/IbkU=; b=UVp/l1zU9lWMSBHBo/+/1dcV4HvNB77S6dxwjWKbbcrSQvWpLyTvSPT95c2BxcTCw2 BnALNEfFTKejru0M4Oq6srMIBMps3F6i5qyGP+UNd9Se5K5uw2O659gO5OKz76KNRLn4 FJtvMjCFaR/dSkSjc3XEBAaOH4dsfSJl1eykyCV9QRohcEFTkKwL16HIjq1wy1kjQR5C 9/KVtYFDlH+1rkA361GLjyyiTrrfP8VdyvA2zJQw+ovvzZffi9lPU+JiC+wDOB2XLila 4T8oOBVSOUBoMf6r2uA/jShxzwoF9oqABXPnbfyr5TprMMXI4I6QduCHocUBFZ+8SOJo BWSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KNq5hK0jhIXBkjJQBE52uTqzvuIV0TTQfTposU/IbkU=; b=oFc/WBUwAGkbnOxQ+cuPvTCvACPoYjIcJpU8XIUq/Y/2yV12phnooyVvfaPaVpl0wM EZx49mDo0DTcoemsaCu/GrdZHX7TChsznGKRGNq8xfvnu7X6x7nSGxXm73NdDNtRaNzq wkSB8sJHB5pumtKTDDJeUbaem11kPaDswmPcFOhT5KS0Q5eY7lVvAP1idOW9ut5A9yFI tT4qz8dIFRTPJCgxP3PkUccFUJLccvzhyZwRedNSmmtdZZVyWtZJNdGtjtLphlC/9tBH bvUnUv0yD76NI+aLwvWGDtR0N5n+ddzJBEffFVH9qbZfs4Sr0RJT8LiLO4zLN9hR1X39 afFA== X-Gm-Message-State: AIVw110MieXYnTzkmAHnv9DFbUmAxFw3WaXBWfZNuNvYRt7BADUuHZ+8 zichibGvOgvxsefFHgM= X-Received: by 10.223.165.153 with SMTP id g25mr4114255wrc.208.1501161789391; Thu, 27 Jul 2017 06:23:09 -0700 (PDT) Original-Received: from [192.168.0.133] (static-nbl2-118.cytanet.com.cy. [212.31.107.118]) by smtp.googlemail.com with ESMTPSA id n87sm15706967wmi.47.2017.07.27.06.23.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2017 06:23:08 -0700 (PDT) In-Reply-To: <87inie93lp.fsf@users.sourceforge.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135048 Archived-At: On 7/27/17 2:32 AM, npostavs@users.sourceforge.net wrote: > Perhaps we should > instead disable this option by default; when I introduced it, I didn't > think about the fact that grep.el is used for not-quite-grep programs as > well. Or we can try to think of them as separate. I.e., the patch below also works. And if we want to use the --null option for vc-git-grep, we can construct a derivative alist in vc-git.el. Up to you, of course. diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index cc3e295..f52dc6e 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1443,7 +1443,8 @@ vc-git-grep (add-to-history 'grep-history command)))) (when command (let ((default-directory dir) - (compilation-environment (cons "PAGER=" compilation-environment))) + (compilation-environment (cons "PAGER=" compilation-environment)) + grep-use-null-filename-separator) ;; Setting process-setup-function makes exit-message-function work ;; even when async processes aren't supported. (compilation-start command 'grep-mode))