all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: npostavs@users.sourceforge.net, Tom Tromey <tom@tromey.com>
Cc: 27840@debbugs.gnu.org
Subject: bug#27840: 26.0.50; vc-git-grep stopped working on git master
Date: Thu, 27 Jul 2017 16:23:06 +0300	[thread overview]
Message-ID: <07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru> (raw)
In-Reply-To: <87inie93lp.fsf@users.sourceforge.net>

On 7/27/17 2:32 AM, npostavs@users.sourceforge.net wrote:

> Perhaps we should
> instead disable this option by default; when I introduced it, I didn't
> think about the fact that grep.el is used for not-quite-grep programs as
> well.

Or we can try to think of them as separate. I.e., the patch below also 
works. And if we want to use the --null option for vc-git-grep, we can 
construct a derivative alist in vc-git.el.

Up to you, of course.

diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index cc3e295..f52dc6e 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -1443,7 +1443,8 @@ vc-git-grep
  	    (add-to-history 'grep-history command))))
        (when command
  	(let ((default-directory dir)
-	      (compilation-environment (cons "PAGER=" compilation-environment)))
+	      (compilation-environment (cons "PAGER=" compilation-environment))
+              grep-use-null-filename-separator)
  	  ;; Setting process-setup-function makes exit-message-function work
  	  ;; even when async processes aren't supported.
  	  (compilation-start command 'grep-mode))





  reply	other threads:[~2017-07-27 13:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 17:57 bug#27840: 26.0.50; vc-git-grep stopped working on git master Tom Tromey
2017-07-26 23:32 ` npostavs
2017-07-27 13:23   ` Dmitry Gutov [this message]
2017-07-30 18:08     ` npostavs
2017-08-01 13:36       ` Dmitry Gutov
2017-08-03  3:09         ` npostavs
2017-08-04  0:59           ` Dmitry Gutov
2017-08-04 22:31             ` npostavs
2017-08-07  0:39               ` npostavs
2017-07-27 13:26 ` vc-git-grep vs project-find-regexp: Was: " Dmitry Gutov
2017-07-27 22:05   ` Tom Tromey
2017-07-29 22:58   ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07272ad0-8cd0-f75e-1cf7-8f66e1d77466@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=27840@debbugs.gnu.org \
    --cc=npostavs@users.sourceforge.net \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.