From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#27986: 26.0.50; 'rename-file' can rename files without confirmation Date: Sat, 19 Aug 2017 17:30:01 -0400 Message-ID: <0720ef94-7787-94e7-a44d-576ec7f75607@cornell.edu> References: <61980dde-3d68-7200-e7f4-98f62e410060@cs.ucla.edu> <0e80a1cf-8217-9e9a-a00f-9fdbd6575fc4@cs.ucla.edu> <0a79089f-36ed-8183-a3bf-6cfa32cb9028@cs.ucla.edu> <6dbd21fd-d191-812a-5810-cb4fbcfbcb20@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------DD03CF9B65BD18C2DFFC173A" X-Trace: blaine.gmane.org 1503178285 20405 195.159.176.226 (19 Aug 2017 21:31:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 19 Aug 2017 21:31:25 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Cc: 27986@debbugs.gnu.org To: Paul Eggert , Philipp Stephani , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Aug 19 23:31:13 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBKn-0004NN-8j for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Aug 2017 23:31:09 +0200 Original-Received: from localhost ([::1]:37341 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBKs-0004In-6d for geb-bug-gnu-emacs@m.gmane.org; Sat, 19 Aug 2017 17:31:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djBKk-0004Hw-L1 for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:31:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djBKh-0006rk-1l for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:31:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37208) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1djBKg-0006qT-Tg for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1djBKg-0004Ef-Dv for bug-gnu-emacs@gnu.org; Sat, 19 Aug 2017 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Aug 2017 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27986 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: security Original-Received: via spool by 27986-submit@debbugs.gnu.org id=B27986.150317821916230 (code B ref 27986); Sat, 19 Aug 2017 21:31:02 +0000 Original-Received: (at 27986) by debbugs.gnu.org; 19 Aug 2017 21:30:19 +0000 Original-Received: from localhost ([127.0.0.1]:45889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBJz-0004Dh-GR for submit@debbugs.gnu.org; Sat, 19 Aug 2017 17:30:19 -0400 Original-Received: from limerock01.mail.cornell.edu ([128.84.13.241]:44503) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djBJx-0004DV-D1 for 27986@debbugs.gnu.org; Sat, 19 Aug 2017 17:30:17 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock01.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id v7JLU2CJ018201; Sat, 19 Aug 2017 17:30:02 -0400 Original-Received: from [192.168.0.4] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id v7JLU02g026494 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Sat, 19 Aug 2017 17:30:01 -0400 In-Reply-To: <6dbd21fd-d191-812a-5810-cb4fbcfbcb20@cornell.edu> Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135922 Archived-At: This is a multi-part message in MIME format. --------------DD03CF9B65BD18C2DFFC173A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 8/16/2017 3:33 PM, Ken Brown wrote: > On 8/14/2017 7:03 PM, Paul Eggert wrote >> Now that renameat_noreplace works on DOS_NT, would it make sense to >> apply the attached further patch as well? If we can get >> renameat_noreplace to work on Cygwin the we could simplify the >> fileio.c code even further. > > I'm in the process of writing an implementation of something like > 'renameat2', which I'll submit to the Cygwin developers. This is now done. The implementation will appear in the next Cygwin release. When that release occurs, I'll install something like the attached patch. Question: Is the patch OK as is, or should I make the call to renameat2 conditional on CYGWIN? In other words, is it safe to assume that renameat2 is defined on any platform on which RENAME_NOREPLACE is defined but not SYS_renameat2? Ken --------------DD03CF9B65BD18C2DFFC173A Content-Type: text/plain; charset=UTF-8; name="0001-Implement-renameat_noreplace-on-recent-Cygwin.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Implement-renameat_noreplace-on-recent-Cygwin.patch" RnJvbSBiOWVmNGNhOTk1MzUwZDFhNTIwYWJhNjZkZTFkNWU0MjA5ZjNlYjkxIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4K RGF0ZTogU2F0LCAxOSBBdWcgMjAxNyAxNzoxNzoyNyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IEltcGxlbWVudCByZW5hbWVhdF9ub3JlcGxhY2Ugb24gcmVjZW50IEN5Z3dpbgoKKiBzcmMv c3lzZGVwLmMgW0NZR1dJTl06IEluY2x1ZGUgY3lnd2luL2ZzLmguCihyZW5hbWVhdF9ub3Jl cGxhY2UpIFtSRU5BTUVfTk9SRVBMQUNFXTogVXNlIHJlbmFtZWF0Mi4KKEJ1ZyMyNzk4NikK LS0tCiBzcmMvc3lzZGVwLmMgfCA2ICsrKysrKwogMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0 aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9zeXNkZXAuYyBiL3NyYy9zeXNkZXAuYwppbmRl eCAxMmU5YzgzZWU5Li43NzIyMTA5N2RiIDEwMDY0NAotLS0gYS9zcmMvc3lzZGVwLmMKKysr IGIvc3JjL3N5c2RlcC5jCkBAIC00Miw2ICs0MiwxMCBAQCBhbG9uZyB3aXRoIEdOVSBFbWFj cy4gIElmIG5vdCwgc2VlIDxodHRwOi8vd3d3LmdudS5vcmcvbGljZW5zZXMvPi4gICovCiAj IGluY2x1ZGUgPHN5cy9zeXNjYWxsLmg+CiAjZW5kaWYKIAorI2lmZGVmIENZR1dJTgorIyBp bmNsdWRlIDxjeWd3aW4vZnMuaD4KKyNlbmRpZgorCiAjaWYgZGVmaW5lZCBEQVJXSU5fT1Mg fHwgZGVmaW5lZCBfX0ZyZWVCU0RfXwogIyBpbmNsdWRlIDxzeXMvc3lzY3RsLmg+CiAjZW5k aWYKQEAgLTI2ODUsNiArMjY4OSw4IEBAIHJlbmFtZWF0X25vcmVwbGFjZSAoaW50IHNyY2Zk LCBjaGFyIGNvbnN0ICpzcmMsIGludCBkc3RmZCwgY2hhciBjb25zdCAqZHN0KQogewogI2lm IGRlZmluZWQgU1lTX3JlbmFtZWF0MiAmJiBkZWZpbmVkIFJFTkFNRV9OT1JFUExBQ0UKICAg cmV0dXJuIHN5c2NhbGwgKFNZU19yZW5hbWVhdDIsIHNyY2ZkLCBzcmMsIGRzdGZkLCBkc3Qs IFJFTkFNRV9OT1JFUExBQ0UpOworI2VsaWYgZGVmaW5lZCBSRU5BTUVfTk9SRVBMQUNFCS8q IEN5Z3dpbiA+PSAyLjkuMC4gKi8KKyAgcmV0dXJuIHJlbmFtZWF0MiAoc3JjZmQsIHNyYywg ZHN0ZmQsIGRzdCwgUkVOQU1FX05PUkVQTEFDRSk7CiAjZWxpZiBkZWZpbmVkIFJFTkFNRV9F WENMCiAgIHJldHVybiByZW5hbWVhdHhfbnAgKHNyY2ZkLCBzcmMsIGRzdGZkLCBkc3QsIFJF TkFNRV9FWENMKTsKICNlbHNlCi0tIAoyLjE0LjEKCg== --------------DD03CF9B65BD18C2DFFC173A--