From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Scan of Emacs regexp mistakes Date: Wed, 15 Apr 2020 11:19:50 -0700 Organization: UCLA Computer Science Department Message-ID: <06c10772-75fa-0f80-2ed5-775e5b245b16@cs.ucla.edu> References: <140DB045-4529-4862-99B8-5F0DEF1EE8D4@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="107844"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 Cc: emacs-devel To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 15 20:21:48 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOmfT-000Rx0-3c for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Apr 2020 20:21:47 +0200 Original-Received: from localhost ([::1]:53700 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOmfS-00057U-3X for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Apr 2020 14:21:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50148) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOmdh-0004Pd-EA for emacs-devel@gnu.org; Wed, 15 Apr 2020 14:20:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOmdg-0002dd-Ak for emacs-devel@gnu.org; Wed, 15 Apr 2020 14:19:57 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:44652) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOmdg-0002bY-5I for emacs-devel@gnu.org; Wed, 15 Apr 2020 14:19:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EB0801600AF; Wed, 15 Apr 2020 11:19:51 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id JOkY5k7gRrMT; Wed, 15 Apr 2020 11:19:51 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E7FE81600CC; Wed, 15 Apr 2020 11:19:50 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C423LREXW6Yk; Wed, 15 Apr 2020 11:19:50 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id BF8211600AF; Wed, 15 Apr 2020 11:19:50 -0700 (PDT) In-Reply-To: <140DB045-4529-4862-99B8-5F0DEF1EE8D4@acm.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247045 Archived-At: On 4/14/20 3:52 AM, Mattias Engdeg=C3=A5rd wrote: > (defvar authors-obsolete-files-regexps > - '(".*loaddefs.el$" ; not obsolete, but auto-generated > + '(".*loaddefs\\.el$" ; not obsolete, but auto-generated > "\\.\\(bzr\\|cvs\\|git\\)ignore$" ; obsolete or uninteresting > "\\.arch-inventory$" Should those trailing "$"s be changed to "\\'"s? > ;; Match anything but `.' and `..'. > -(defvar dired-re-no-dot "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*") > +(defvar dired-re-no-dot (rx (or (not ".") "..."))) ... > (defconst directory-files-no-dot-files-regexp > - "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*" > + "[^.]\\|\\.\\.\\." > "Regexp matching any file name except \".\" and \"..\".") We shouldn't have two names for the same variable. I suggest obsoleting=20 dired-re-no-dot and replacing its only use with directory-files-no-dot-fi= les-regexp. As Drew's comments make evident, the doc string is unclear. It should be= =20 something like 'Regexp that matches part of a nonempty string if the stri= ng is=20 neither "." nor "..".' > (let ((files (directory-files > - directory t "^\\([^.]\\|\\.\\([^.]\\|\\..\\)\\).*")) > + directory t (rx (or (not ".") "...")))) Shouldn't this and similar uses of (rx (or (not ".") "...")) be replaced = by=20 directory-files-no-dot-files-regexp? That would be clearer. I agree with you that directory-files should not return "." and "..", tho= ugh=20 that indeed is a different topic.