From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62974: 29.0.60; New buffers created with project-switch-to-buffer aren't in the project Date: Fri, 21 Apr 2023 18:56:46 +0300 Message-ID: <06aff731-1196-5c27-b66d-01f79117283e@gutov.dev> References: <83ttxa4c3m.fsf@gnu.org> <1e68f5ff-63aa-4dc4-9a92-02f3e6d4641a@gutov.dev> <83pm7x4woq.fsf@gnu.org> <83a5z14f94.fsf@gnu.org> <87v8hpl6gt.fsf@catern.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13178"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: Spencer Baugh , 62974@debbugs.gnu.org To: sbaugh@catern.com, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 21 17:57:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppt8K-00038w-4P for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 21 Apr 2023 17:57:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppt8C-0003QT-5Y; Fri, 21 Apr 2023 11:57:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppt8B-0003Q6-0j for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 11:57:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ppt8A-0003AL-G1 for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 11:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ppt8A-0004hQ-Bq for bug-gnu-emacs@gnu.org; Fri, 21 Apr 2023 11:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Apr 2023 15:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62974 X-GNU-PR-Package: emacs Original-Received: via spool by 62974-submit@debbugs.gnu.org id=B62974.168209261818052 (code B ref 62974); Fri, 21 Apr 2023 15:57:02 +0000 Original-Received: (at 62974) by debbugs.gnu.org; 21 Apr 2023 15:56:58 +0000 Original-Received: from localhost ([127.0.0.1]:40993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppt85-0004h5-Ig for submit@debbugs.gnu.org; Fri, 21 Apr 2023 11:56:57 -0400 Original-Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:55747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppt84-0004gt-5v for 62974@debbugs.gnu.org; Fri, 21 Apr 2023 11:56:56 -0400 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.west.internal (Postfix) with ESMTP id 1A6382B06724; Fri, 21 Apr 2023 11:56:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 21 Apr 2023 11:56:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1682092609; x=1682096209; bh=SNBu//eHX3qGqzqyrsPaSaYgOVtlwyGYMWA 1NJKuNUs=; b=PCJOIHzOj8y53kF28hgLWYuzQjq1KlLm07mR+qWT/WFhCeUXPaE h7T59BzDpRWirBuIbpVevuLlGBD8E6cZLLlqI0I3iND5b4CYXXB9jUysSI0TJ1he sSEMXKHUkzHKzopTtx91Q9lH4adU6JrTrojpy4zB0dYPSTvLzo0Vzk/CaFtrpzWI viJnoddr2LM8ucuJtvU2x3xQMYib2iJZje82ULOkTRmdl/lkDu6RzoqmJQyZKHOc h+Wo2bedgvapuMQEkYR71xp4W0zg4tvdGJae8QETYzbgMB+FbenOIUcxBQxc3qti AkgMFVKc3EZPA34W4NmVAaSKTvv4dGsAlag== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682092609; x=1682096209; bh=SNBu//eHX3qGqzqyrsPaSaYgOVtlwyGYMWA 1NJKuNUs=; b=UaSzrSUAICKN9NU7fbtvFmVR6rNcLg8sPzxHVIsQCS3tukUDdk7 H1IVoFszsS8gRydBrgdhVuCrhqDACSKPSJfvYzek5Vp0GD43ib/BNnEiy4DVH2nd 7u8AnX7zOQn/RlofdtGDX9xhMRdzLV6JfjPYbD+3XTGsayPCW2RcGXob0gBOcQiP kAYIKwuB5PP3RkFE58ul1TBsBniXYPlrqgit+7lsSYmNEdjDZemQfi8qJtZXRD8H 0zSjFPg/madXbk4oXu+Ew63aWiZSKkN+Z3l0Zm/uJOXsQrZVbV2Wtpt4kKIqEbnK +sfWybDzAkrf54L7hgRgALky82PpadIk2YA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedgledvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepgeejgfelvdejtedvteeufedtvdfgtefftdeujedtteehtdfgueelleeuteff ueeunecuffhomhgrihhnpehrohhothdrnhhonecuvehluhhsthgvrhfuihiivgeptdenuc frrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 21 Apr 2023 11:56:47 -0400 (EDT) Content-Language: en-US In-Reply-To: <87v8hpl6gt.fsf@catern.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260397 Archived-At: On 21/04/2023 16:17, sbaugh@catern.com wrote: > Eli Zaretskii writes: >>> From: Spencer Baugh >>> Date: Fri, 21 Apr 2023 07:46:14 -0400 >>> Cc: Dmitry Gutov,62974@debbugs.gnu.org >>> >>> But if it is in a subdirectory of the root, it also belongs to the >>> project, doesn't it? Exactly like the buffer from which this command >>> is invoked, whose default-directory was a subdirectory of the root. >>> No? >>> >>> That's fine, I wouldn't want to change that behavior, the behavior I'd want to change is when invoking >>> the command from a buffer which is not in a project, or by invoking it after C-x p p to switch projects. >> The recipe you posted didn't include "C-x p p", though. > My recipe was an example of "command from a buffer which is not in a > project". Here's a recipe for the issue using C-x p p: > > 1. (setq project-switch-use-entire-map t) > 2. Be in a buffer in project A > 3. C-x p p b to switch to project B and select a buffer in project B > 4. Type a buffer name which doesn't exist > 5. The resulting buffer is in project A, not B Thanks. How does this look? diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el index a18b918db62..94c7f8f547a 100644 --- a/lisp/progmodes/project.el +++ b/lisp/progmodes/project.el @@ -1314,13 +1314,17 @@ project--read-project-buffer (and (memq (cdr buffer) buffers) (not (project--buffer-check - (cdr buffer) project-ignore-buffer-conditions)))))) - (read-buffer - "Switch to buffer: " - (when (funcall predicate (cons other-name other-buffer)) - other-name) - nil - predicate))) + (cdr buffer) project-ignore-buffer-conditions))))) + (buffer (read-buffer + "Switch to buffer: " + (when (funcall predicate (cons other-name other-buffer)) + other-name) + nil + predicate))) + (if (get-buffer buffer) + buffer + (let ((default-directory (project-root pr))) + (get-buffer-create buffer))))) ;;;###autoload (defun project-switch-to-buffer (buffer-or-name)