From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Reitter Newsgroups: gmane.emacs.devel Subject: Re: saveplace: don't ask for coding system Date: Sun, 2 Dec 2007 16:51:57 +0000 Message-ID: <06675819-C4A8-4D78-AD59-0A2AF296AC7E@inf.ed.ac.uk> References: <198E2B70-D060-41D8-8BC2-A9614C2729CC@inf.ed.ac.uk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v915) Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1196626946 3041 80.91.229.12 (2 Dec 2007 20:22:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 2 Dec 2007 20:22:26 +0000 (UTC) Cc: emacs- devel To: Juanma Barranquero Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 02 21:22:34 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IyvKg-0007B8-KT for ged-emacs-devel@m.gmane.org; Sun, 02 Dec 2007 21:22:30 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IyvKQ-0000iE-CR for ged-emacs-devel@m.gmane.org; Sun, 02 Dec 2007 15:22:14 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Iys3A-0000zF-Rk for emacs-devel@gnu.org; Sun, 02 Dec 2007 11:52:12 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Iys39-0000xS-9Z for emacs-devel@gnu.org; Sun, 02 Dec 2007 11:52:11 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Iys39-0000xL-5n for emacs-devel@gnu.org; Sun, 02 Dec 2007 11:52:11 -0500 Original-Received: from mandy.inf.ed.ac.uk ([129.215.218.49]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Iys38-0003Qe-Lw for emacs-devel@gnu.org; Sun, 02 Dec 2007 11:52:10 -0500 Original-Received: from scarlett.lan (host86-146-51-226.range86-146.btcentralplus.com [86.146.51.226]) (authenticated bits=0) by mandy.inf.ed.ac.uk (8.13.8/8.13.8) with ESMTP id lB2Gpvs1001392 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 2 Dec 2007 16:51:58 GMT In-Reply-To: X-Mailer: Apple Mail (2.915) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. X-Mailman-Approved-At: Sun, 02 Dec 2007 15:22:10 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84499 Archived-At: On 29 Nov 2007, at 09:05, Juanma Barranquero wrote: > > > I think you should also add a "-*- coding: XXX -*-" line to the file. Good idea. I left the coding system at `utf-8', because that's what ido seems to use. If there are characters not in utf-8 that file systems accept for file names, it should probably be emacs-mule. I'll post a separate patch for log level based message filtering another time. 2007-12-02 David Reitter * saveplace.el (load-save-place-alist-from-file): set coding system for places file and improve write error message. *** lisp/saveplace.el 25 Jul 2007 05:47:04 +0100 1.37.2.1 --- lisp/saveplace.el 02 Dec 2007 16:44:59 +0000 *************** *** 205,215 **** (setq save-place-alist (cdr save-place-alist))))) (defun save-place-alist-to-file () ! (let ((file (expand-file-name save-place-file))) (save-excursion (message "Saving places to %s..." file) (set-buffer (get-buffer-create " *Saved Places*")) (delete-region (point-min) (point-max)) (when save-place-forget-unreadable-files (save-place-forget-unreadable-files)) (let ((print-length nil) --- 205,220 ---- (setq save-place-alist (cdr save-place-alist))))) (defun save-place-alist-to-file () ! (let ((file (expand-file-name save-place-file)) ! (coding-system-for-write 'utf-8)) (save-excursion (message "Saving places to %s..." file) (set-buffer (get-buffer-create " *Saved Places*")) (delete-region (point-min) (point-max)) + (insert + (format ";; -*- mode: emacs-lisp; coding: %s -*-\n" + coding-system-for-write) + ";; Positions for files, automatically generated by `saveplace'.\n\n") (when save-place-forget-unreadable-files (save-place-forget-unreadable-files)) (let ((print-length nil) *************** *** 225,231 **** (condition-case nil ;; Don't use write-file; we don't want this buffer to visit it. (write-region (point-min) (point-max) file) ! (file-error (message "Can't write %s" file))) (kill-buffer (current-buffer)) (message "Saving places to %s...done" file))))) --- 230,236 ---- (condition-case nil ;; Don't use write-file; we don't want this buffer to visit it. (write-region (point-min) (point-max) file) ! (file-error (message "Saving places: Can't write %s" file))) (kill-buffer (current-buffer)) (message "Saving places to %s...done" file)))))