From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jackson Ray Hamilton Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation. Date: Fri, 23 Dec 2016 22:58:30 -0800 Message-ID: <064dad34-c8c4-9135-2cbd-0ccd452de2cc@jacksonrayhamilton.com> References: <20161223195027.29384.58430@vcs.savannah.gnu.org> <20161223195027.7C9E52201BC@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1482562729 28647 195.159.176.226 (24 Dec 2016 06:58:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 24 Dec 2016 06:58:49 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.5.1 To: Stefan Monnier , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 24 07:58:45 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cKgI0-0006qy-3Z for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2016 07:58:44 +0100 Original-Received: from localhost ([::1]:42482 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKgI4-0005GY-My for ged-emacs-devel@m.gmane.org; Sat, 24 Dec 2016 01:58:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKgHy-0005GI-Ji for emacs-devel@gnu.org; Sat, 24 Dec 2016 01:58:43 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKgHt-0004QZ-P6 for emacs-devel@gnu.org; Sat, 24 Dec 2016 01:58:42 -0500 Original-Received: from mta-05-3.privateemail.com ([68.65.122.15]:55728) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cKgHt-0004QL-IV for emacs-devel@gnu.org; Sat, 24 Dec 2016 01:58:37 -0500 Original-Received: from [10.145.8.123] (unknown [10.20.151.225]) by MTA-05.privateemail.com (Postfix) with ESMTPA id 03D5A60030; Sat, 24 Dec 2016 06:58:30 +0000 (UTC) X-Enigmail-Draft-Status: N1110 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 68.65.122.15 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210771 Archived-At: > I think we can skip the second tar with something like > "tar -cvhf /dev/null 2>&1". I tried this before, and again just now, but it does not cause make to execute at a significantly different speed on my machine. Is the effect more noticeable on yours? > But I have a question: are we sure that tar will always apply the -X > "$${pt}/.elpaignore" patterns to the files explicitly mentioned on the > command line? Good point. I suppose not in this instance, where I get no output: $ mkdir -p a/a $ touch a/b.el a/a/b.el $ echo 'a/b.el' > a/.elpaignore $ tar -ch a/*.el --no-recursion --exclude-vcs -X a/.elpaignore \ | tar --list Since .elpaignore is inside the project directory, I assume that we should be treating .elpaignore as matching relative to inside the project root. We should cd into the project directory first, so we don't accidentally match against the project's directory's name, too. $ cd a $ tar -ch *.el --no-recursion --exclude-vcs -X .elpaignore | tar --list The above command correctly yields "b.el". Did you have any other cases in mind? On 12/23/2016 03:49 PM, Stefan Monnier wrote: >> + tar -ch $$pt/*.el --no-recursion \ >> + --exclude-vcs -X "$${pt}/.elpaignore" \ >> + | tar --list; \ >=20 > I think we can skip the second tar with something like > "tar -cvhf /dev/null 2>&1". >=20 > But I have a question: are we sure that tar will always apply the -X > "$${pt}/.elpaignore" patterns to the files explicitly mentioned on the > command line? >=20 >=20 > Stefan >=20