From: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation.
Date: Fri, 23 Dec 2016 22:58:30 -0800 [thread overview]
Message-ID: <064dad34-c8c4-9135-2cbd-0ccd452de2cc@jacksonrayhamilton.com> (raw)
In-Reply-To: <jwvd1gidx8m.fsf-monnier+emacsdiffs@gnu.org>
> I think we can skip the second tar with something like
> "tar -cvhf /dev/null 2>&1".
I tried this before, and again just now, but it does not cause make to
execute at a significantly different speed on my machine. Is the effect
more noticeable on yours?
> But I have a question: are we sure that tar will always apply the -X
> "$${pt}/.elpaignore" patterns to the files explicitly mentioned on the
> command line?
Good point. I suppose not in this instance, where I get no output:
$ mkdir -p a/a
$ touch a/b.el a/a/b.el
$ echo 'a/b.el' > a/.elpaignore
$ tar -ch a/*.el --no-recursion --exclude-vcs -X a/.elpaignore \
| tar --list
Since .elpaignore is inside the project directory, I assume that we
should be treating .elpaignore as matching relative to inside the
project root. We should cd into the project directory first, so we
don't accidentally match against the project's directory's name, too.
$ cd a
$ tar -ch *.el --no-recursion --exclude-vcs -X .elpaignore | tar --list
The above command correctly yields "b.el".
Did you have any other cases in mind?
On 12/23/2016 03:49 PM, Stefan Monnier wrote:
>> + tar -ch $$pt/*.el --no-recursion \
>> + --exclude-vcs -X "$${pt}/.elpaignore" \
>> + | tar --list; \
>
> I think we can skip the second tar with something like
> "tar -cvhf /dev/null 2>&1".
>
> But I have a question: are we sure that tar will always apply the -X
> "$${pt}/.elpaignore" patterns to the files explicitly mentioned on the
> command line?
>
>
> Stefan
>
next prev parent reply other threads:[~2016-12-24 6:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161223195027.29384.58430@vcs.savannah.gnu.org>
[not found] ` <20161223195027.7C9E52201BC@vcs.savannah.gnu.org>
2016-12-23 23:49 ` [elpa] master 580a1b6: Respect .elpaignore when compiling and optimize compilation Stefan Monnier
2016-12-24 6:58 ` Jackson Ray Hamilton [this message]
2016-12-26 4:16 ` Stefan Monnier
2016-12-26 19:57 ` Jackson Ray Hamilton
2016-12-27 3:29 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=064dad34-c8c4-9135-2cbd-0ccd452de2cc@jacksonrayhamilton.com \
--to=jackson@jacksonrayhamilton.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.