From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#24870: 26.0.50; parse-partial-sexp ignores comment-end Date: Wed, 14 Dec 2016 07:45:45 +0100 Message-ID: <0633d0d0-9521-7288-af5b-e039e89bdd23@easy-emacs.de> References: <7cb86247-1e30-f029-0b9b-c53cc096ec4b@easy-emacs.de> <87mvggh2hu.fsf@users.sourceforge.net> <87h967cj0f.fsf@users.sourceforge.net> <87eg1bcg0y.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------6DE364D3C2DE4D117BCC76A2" X-Trace: blaine.gmane.org 1481697438 2647 195.159.176.226 (14 Dec 2016 06:37:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 14 Dec 2016 06:37:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Icedove/45.5.1 Cc: 24870@debbugs.gnu.org, Alan Mackenzie , Matt Armstrong To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Dec 14 07:37:14 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH3Be-0007Sw-7u for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2016 07:37:10 +0100 Original-Received: from localhost ([::1]:45842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH3Bh-0002yU-16 for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2016 01:37:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH3Ba-0002oO-JR for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 01:37:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cH3BX-0005md-C4 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 01:37:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54182) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cH3BX-0005mT-7T for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 01:37:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cH3BW-0006yB-E4 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2016 01:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Dec 2016 06:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24870 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed Original-Received: via spool by 24870-submit@debbugs.gnu.org id=B24870.148169740726768 (code B ref 24870); Wed, 14 Dec 2016 06:37:02 +0000 Original-Received: (at 24870) by debbugs.gnu.org; 14 Dec 2016 06:36:47 +0000 Original-Received: from localhost ([127.0.0.1]:41348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH3BH-0006xf-4z for submit@debbugs.gnu.org; Wed, 14 Dec 2016 01:36:47 -0500 Original-Received: from mout.kundenserver.de ([212.227.126.135]:57951) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cH3BF-0006xU-IA for 24870@debbugs.gnu.org; Wed, 14 Dec 2016 01:36:46 -0500 Original-Received: from [192.168.178.35] ([77.3.28.25]) by mrelayeu.kundenserver.de (mreue001 [212.227.15.167]) with ESMTPSA (Nemesis) id 0MGJlf-1cNMh60WFL-00F9tr; Wed, 14 Dec 2016 07:36:23 +0100 In-Reply-To: <87eg1bcg0y.fsf@users.sourceforge.net> X-Provags-ID: V03:K0:VY+/3Mc9VLAs2/k5bRbnAX7wGXjOuqNMBZX+HRUz37lDaN38hwG zF6bZl/0vVJmk5u63U7gcbu5wtJvpplLY1wZTp9qwfuTJX2E8Qm7opclsApksbXJ2gJ8isr isko4a0/p/pDrwGoRyWq/o/3cUK95Vmh7FMB6/O8dyKQTCOCVJBUfmkpRNIbb40boOv33VX 5x1at328mrmeb2ZyILtVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:IGN9mLYIN2k=:OSgaXar0hyZuIJhEOV6Gto SF9hjZYyntYbTuMPwlPBufDcYXL6V67KkaIqZbHpmeeYYwW9ys5hdE5FKWM1HL5kCLT9fbvVR pA22GU64w8s1rdBg4OxBAe4MqWcuiiK2xTeGEy1kd4ztKX7nzDmoLfR8zpESUFkEOBz8zeSZs XwzpW77o3s5f/2svXiujB0bUB7kLM37wbUC4eqffa7PTJCSl/4rAakSooX/wJj5nq0grrYo3l NwubS7FtwzCJ6EpB0BiT8MK6s/1U/D8D7rZ5SPSk1iztL47i88JWVFyOSr9leI8zo4Kg7OIav KflcWk0KAf5WDc3k1kFAkWAKOO5aE8DoHNMTixhuYXcxf+mfm4wASjdu2hIndE3GUDc+G/9hb Drp1tnvZh8kMBDwsgC+4R1cZt0tdydX141ENbCzAGDujfO59VftLr25831Shy2aeyOFwnbzaB 4RN+Q3oVc3S2qCNRuSgmGZOjevcBUcEE+WcHf9JbvyW1tnqXYtBXQdhAV7sM7vr9nBEsHaDli obTFegEKCCocojxX75LGd2OnhwVLgeGLB0FCvaUWFz+rK0kfFIc0wiewAZrYnGJdzdQNhBL4n AJNkhl0u3QQZbuQxsFko95AtIIjVrej8onoLL1rcby9Droa4RUTgSqyRfpmRAtgejFAm8ZTBb j8yZ32Q34Q116Hl5Miiw/iFgXd+Ok6q0yncYRWDaQOlMTHk/0+ZpqjtXuz70FZZ7TF6eBRMwt omNw+f/6izfwtsBf X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:127026 Archived-At: This is a multi-part message in MIME format. --------------6DE364D3C2DE4D117BCC76A2 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 14.12.2016 05:04, npostavs@users.sourceforge.net wrote: > npostavs@users.sourceforge.net writes: >> >> I have tracked the issue down to scan_sexps_forward in syntax.c > Applying this change which reverts part of [1] seems to fix the issue: > > > > Alan, can you explain what the idea behind that change was? > > I think it might correspond to this part of the commit message: > > Reformulate code at the top of the main loop correctly to > recognize comment openers when starting in the middle of one. > > [1]: 9dcf5998935c Sun Mar 20 13:19:48 2016 +0000 > "Amend parse-partial-sexp correctly to handle two character comment delimiters" Thanks a lot! BTW that message puzzles me too, AFAIK comments in C,C++ can't be nested. --------------6DE364D3C2DE4D117BCC76A2 Content-Type: text/html; charset=windows-1252 Content-Transfer-Encoding: 7bit



On 14.12.2016 05:04, npostavs@users.sourceforge.net wrote:
npostavs@users.sourceforge.net writes:


I have tracked the issue down to scan_sexps_forward in syntax.c

Applying this change which reverts part of [1] seems to fix the issue:




Alan, can you explain what the idea behind that change was?

I think it might correspond to this part of the commit message:

    Reformulate code at the top of the main loop correctly to
    recognize comment openers when starting in the middle of one.

[1]: 9dcf5998935c Sun Mar 20 13:19:48 2016 +0000
"Amend parse-partial-sexp correctly to handle two character comment delimiters"

Thanks a lot! BTW that message puzzles me too, AFAIK comments in C,C++ can't be nested.
--------------6DE364D3C2DE4D117BCC76A2--