From: Phil Sainty <psainty@orcon.net.nz>
To: "emacs-devel@gnu.org" <emacs-devel@gnu.org>
Subject: Performance under bidi-paragraph-direction 'left-to-right vs bidi-display-reordering nil
Date: Sun, 24 Nov 2019 23:41:56 +1300 [thread overview]
Message-ID: <06329813-a32a-2eb8-61b9-337b67d84a4c@orcon.net.nz> (raw)
As discussed in
https://lists.gnu.org/archive/html/emacs-devel/2019-07/msg00294.html
setting bidi-display-reordering nil isn't a supported/tested scenario,
and in so-long.el we changed that to set bidi-paragraph-direction to
'left-to-right instead.
I've just traced what seemed like a performance regression to this
change -- it's now apparent to me that there's a noticeable effect on
the redisplay performance having bidi-display-reordering enabled and
bidi-paragraph-direction set (at least under long-line situations)
which isn't experienced when bidi-display-reordering is disabled.
(Which doesn't seem entirely unexpected when stated like that. I
think I'd simply been under a misapprehension that the change we'd
made would have more similar performance characteristics than is
actually the case. I failed to notice anything at the time, because
I'd forgotten that I'd (setq-default bidi-display-reordering nil) in
my own config after bug 23801 -- believing back then that this was
a supported setting.)
As before, the JSON file from https://emacs.stackexchange.com/q/598
serves as an example:
wget
https://github.com/Wilfred/ReVo-utilities/blob/a4bdc40dd2656c496defc461fc19c403c8306d9f/revo-export/dictionary.json?raw=true
-O one_line.json
With global-so-long-mode enabled visiting one_line.json does not hang
Emacs; but for me there is a very noticeable 'lag' to interactive
movements around the early parts of that buffer which disappears
completely if I set bidi-display-reordering to nil.
I do imagine that the code already tries hard to be efficient, but if
there's any chance that with only bidi-paragraph-direction set we can
achieve performance nearer to that with bidi-display-reordering
disabled, that would seemingly be beneficial for files with extremely
long lines.
Failing that, it makes me wonder whether a nil bidi-display-reordering
should be under consideration as a supported state for end users, for
the performance benefits.
-Phil
next reply other threads:[~2019-11-24 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-24 10:41 Phil Sainty [this message]
2019-11-24 16:00 ` Performance under bidi-paragraph-direction 'left-to-right vs bidi-display-reordering nil Eli Zaretskii
2019-11-30 8:42 ` Phil Sainty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06329813-a32a-2eb8-61b9-337b67d84a4c@orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.