From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#74361: [PATCH] New option xref-navigation-display-window-action Date: Tue, 19 Nov 2024 21:51:32 +0200 Message-ID: <05def9dc-c6bb-4b26-9f7e-8c26b25178c2@gutov.dev> References: <86ldxkitjn.fsf@gnu.org> <5a2abf5e-011b-43d0-b34a-e06e354badc5@gutov.dev> <8634jrin5v.fsf@gnu.org> <86ikskvie0.fsf@gnu.org> <97e7ec85-7e5c-4aa4-a85f-b5f40adc8de6@gutov.dev> <8634jov5ir.fsf@gnu.org> <86serntf0h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5621"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 20:52:24 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDUGu-0001I2-14 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 20:52:24 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDUGd-0006AK-D0; Tue, 19 Nov 2024 14:52:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDUGZ-000695-Bq for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 14:52:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDUGY-0001sY-TF for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 14:52:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=1nnBlGqp0NwiWJ6//xUTUrY8MIR2vleqGyjNJhfeYgc=; b=jCUjzImIeL2RvyyvDTnLlapUdRwFLAF3wgBDZicumo5RKnzPNX7qgBAptCbQLCqN7KE2obqzXgi/2u1cKLYe79CZmp/v/+N9n0DFI1dZZucmlr+rBn9GXk9SaWtl0u+wzq37AEGkz+/s9+d2kofPp4eufuqOhWSobwMVtDhlDvjSaKRvYWU/sZs2e3MkzTYH7kplw2uNsXWQlrLOUzgjWsxage374jXyO2eo0bx1/Qr03xOFFznrbDXh7Jcrmdr9sh8ODq2bRJ1VKAzkL0/YYtU47W/9jEaaVXc8D5D2yERRNXjT6Zyk7oBrbUgqzw9Uoq+NvLX1twwWk6BhlfUAiQ==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDUGY-0006tN-Jm for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 14:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 19:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74361 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74361-submit@debbugs.gnu.org id=B74361.173204590326462 (code B ref 74361); Tue, 19 Nov 2024 19:52:02 +0000 Original-Received: (at 74361) by debbugs.gnu.org; 19 Nov 2024 19:51:43 +0000 Original-Received: from localhost ([127.0.0.1]:44111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDUGF-0006sj-7y for submit@debbugs.gnu.org; Tue, 19 Nov 2024 14:51:43 -0500 Original-Received: from fhigh-a7-smtp.messagingengine.com ([103.168.172.158]:57695) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDUGC-0006sW-I6 for 74361@debbugs.gnu.org; Tue, 19 Nov 2024 14:51:41 -0500 Original-Received: from phl-compute-06.internal (phl-compute-06.phl.internal [10.202.2.46]) by mailfhigh.phl.internal (Postfix) with ESMTP id 7C8AD1140114; Tue, 19 Nov 2024 14:51:35 -0500 (EST) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Tue, 19 Nov 2024 14:51:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1732045895; x=1732132295; bh=1nnBlGqp0NwiWJ6//xUTUrY8MIR2vleqGyjNJhfeYgc=; b= W3FqblKfY3zSLUwI/w3+Es5Z4NLE3AyASOHEOiOSqqVDxym90oVOj1dlKcWhdS/Q Ir+asVzLfEW1ZpdtqJnMkY2/bcEKyvo7DTbrnnxCaC9aHkF1hkOgqGTvzMag6bnG LROSg/eyvnF74ffyAZvMAOMXEvVdGg3F2AP7n/tVzxsMcT5mcjS2SkFVuoJdYIb1 k4pna0vcx12Vhw6XeSJlqXeGBPfHE2ac35pr+D3o+gTwzXveLqFszHwzbh7We6y+ vFy1H5aN6RLwjEHDdyZki2KtEHjyQ6+kdlvwuTOWBWNLrccHY6HHjVD2ZvCRX6Cn VirYRw0sh7o436r2IA6KvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1732045895; x= 1732132295; bh=1nnBlGqp0NwiWJ6//xUTUrY8MIR2vleqGyjNJhfeYgc=; b=I irQE0rq1WlTQtphnrb+Jn0+LDmqICAY+wNW6HxywcSVYtO+G5yHd5U3GzRrASj10 eskYyTQKoWnG4fvpkXo0PMuX1kAyCb4K+tbzTB6S2XNh9yCgtWegtrKL1yThnT3B BCgBoXHgvFBFNWYK6WW81Ea0RqGZ+QCXyL1Nhzb7s1Wq8H1A98ehC30KJwGJiEyN u6U7Oo2fhUh8UBByBcTWWeyqHMCCxgSw4SCvH/xFOvqD2QmPbLrV6vX1HutmVosO faefYWIG47OmxtDHNHswxEyhCUIP45VkhZM7PnmuQ8giAptgm7ZmD1zwF1/SLUBm haVydR2lBp3NUZDcjktTA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrfedvgdduvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdej necuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdrug gvvheqnecuggftrfgrthhtvghrnhepteduleejgeehtefgheegjeekueehvdevieekueef tddvtdevfefhvdevgedujeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrdguvghvpdhnsggprhgtphhtthho peegpdhmohguvgepshhmthhpohhuthdprhgtphhtthhopegvlhhiiiesghhnuhdrohhrgh dprhgtphhtthhopehruhgurghlihgtshesghhmgidrrghtpdhrtghpthhtohepjeegfeei udesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopehjuhhriheslhhinhhkoh hvrdhnvght X-ME-Proxy: Feedback-ID: i07de48aa:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 19 Nov 2024 14:51:33 -0500 (EST) Content-Language: en-US In-Reply-To: <86serntf0h.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295657 Archived-At: On 19/11/2024 17:33, Eli Zaretskii wrote: >> Date: Tue, 19 Nov 2024 03:21:26 +0200 >> Cc: rudalics@gmx.at, 74361@debbugs.gnu.org, juri@linkov.net >> From: Dmitry Gutov >> >> Next step is to find the appropriate place for it. Maybe not a docstring >> if the user option to customize will be the global one >> (display-buffer-alist), but either in Commentary or somewhere in the manual. > > Maybe just mention in the doc string that the commands use > display-buffer to select the window? The important part is using a specific category, not just display-buffer. And there doesn't seem to be a single docstring, or even a main docstring to mention this in. There are at least 3 of them: xref-find-definitions, xref-go-back and xref-go-forward, and these are not the only ones affected. >> Speaking of the reference that we used for this solution, it seems that >> >> (category . comint) >> >> is only mentioned in NEWS and in the obsoletion message for >> 'display-comint-buffer-action'. There is also a hit for it in the >> manual, but only in the form "If the caller display-buffer passes a >> category as a symbol ...", not saying exactly that comint modes do or >> should do that. Maybe that's something to be fixed as well. > > I will see about documenting it properly, if no one beats me to it. Thanks.