From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Patches for Emacs 25.2 Date: Mon, 7 Nov 2016 12:39:06 +0200 Message-ID: <05d06a0a-e6df-5d54-01bf-7bb9447a2f7e@yandex.ru> References: <877f96t9oc.fsf@gmx.de> <837f96xgp5.fsf@gnu.org> <87zim2rtck.fsf@gmx.de> <9181f38b-8d6c-c61e-90b0-d44a9e048c9e@gmail.com> <87wph6qd1d.fsf@gmx.de> <831szexb54.fsf@gnu.org> <83shrtx5dv.fsf@gnu.org> <752ec49c-da5b-bf86-e31d-294c362c04cb@gmail.com> <877f95deig.fsf@gmx.de> <6f656e32-a44c-f874-3290-f47b8828078e@yandex.ru> <87oa1r64vg.fsf@gmx.de> <2d749ac6-636b-14f2-e5a9-dcc0e9ba7541@yandex.ru> <8760nzfunl.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1478515215 14137 195.159.176.226 (7 Nov 2016 10:40:15 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 7 Nov 2016 10:40:15 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:50.0) Gecko/20100101 Thunderbird/50.0 Cc: Eli Zaretskii , Nikolay Kudryavtsev , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 07 11:40:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c3hLC-0000js-6Y for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 11:39:50 +0100 Original-Received: from localhost ([::1]:52842 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3hLF-00058R-22 for ged-emacs-devel@m.gmane.org; Mon, 07 Nov 2016 05:39:53 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33496) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c3hKd-00058B-QY for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:39:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c3hKY-00029n-Tu for emacs-devel@gnu.org; Mon, 07 Nov 2016 05:39:15 -0500 Original-Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:35144) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1c3hKY-00028O-Lm; Mon, 07 Nov 2016 05:39:10 -0500 Original-Received: by mail-wm0-x243.google.com with SMTP id a20so4885957wme.2; Mon, 07 Nov 2016 02:39:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hHMCZ2BkytS522kTkeQqz36ewMOnDb2On3l+YdvlAW0=; b=fdWpamS7SrMFGlDygK+kXQoRbbr+VglnqryZ6ogFNi6zbS2M3K97n3e+GgYEVifvd7 r+nYphZ73A3HL2WsIBHHaHGFjHojKT//ihmxFa5vD7/KCZZ8Rdu9t3nzgbk5L/n7d+7D A/zgmUMeNg9bkb+iad9BLXNTRttTNRGUvg8k3mTJ9Ii8stHyY3kWWZwa5P6n3xtYDtN/ p30n5RW7SAzUzNUe457Ve7UpZI/dqmXnlyw8X7JxW3Hppnhpq+33WX9fGjGdrbifrwAS 1PGbzZoqU0a3XVK1GinTv15O9WUroiJ44F6QuRwJM7R+veMO6mFKPiOaOMQVY/5584Zm QBYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hHMCZ2BkytS522kTkeQqz36ewMOnDb2On3l+YdvlAW0=; b=TNC1026Cr/R8I8OXXH36NiT8iVLQPVUSCgvFUJcJgLHhd84fq9/0VWQdLvAfl5Au/H lfpXg6Ulzg+0EPr7VM+8f+pk6q3idv0nAny8RchqmrPLMwT6fQfE4kk+81Tu37N/7A9d Vz3iGvyGQvxFwKnjExU4i8bVPX3X4blgAwD7G4bCtuC3BAJS4uquDk6FstT36S5ytq/W Kav404AEkjKj7BRzRiLytg2Or/C6EbBag1BEwvRZRE/Kv6F7YFw5nQDz1x6wU8jY5mf5 fjwXqeyJdmvmazM28mnuyEhEafG9ZD+eIn48dqYMRbsl/TtPGGADWTWa9jbSl5vcBuEL x1FQ== X-Gm-Message-State: ABUngvcJyo9Uydtpa5Lsnxga+qV7FeZA2jwR6czE2HmtJ662CqPPq6ul2AHOJsHPS+2RFQ== X-Received: by 10.28.128.211 with SMTP id b202mr5661427wmd.7.1478515149469; Mon, 07 Nov 2016 02:39:09 -0800 (PST) Original-Received: from [192.168.1.3] ([185.105.173.41]) by smtp.googlemail.com with ESMTPSA id r7sm16802532wjp.43.2016.11.07.02.39.07 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Nov 2016 02:39:08 -0800 (PST) In-Reply-To: <8760nzfunl.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:400c:c09::243 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209241 Archived-At: On 07.11.2016 12:31, Michael Albinus wrote: >>>> Can't we move the (file-remote-p ... 'localname) call to the first >>>> hunk here? Then the patch will only change one place, and we get rid >>>> of the added `or' here. >>> >>> I let it to Nikolay. >> >> Not sure I understand. > > The patch for the emacs-25 branch is proposed by Nikolay. Yes. And my comment applies to both it and your modified version. >>> However, given that this construct >>> >>> (or (file-remote-p FILE 'localname) FILE) >>> >>> happens several times in the lisp sources, I wonder whether we shall >>> give it an own defmacro or defsubst (in master, of course). >> >> I have no strong opinion either way, but your commit in master fixing >> this problem does not have this construct. > > Sure. It was a rather general comment, given that we find this construct > under .../emacs/lisp for at least 11 times, and under .../elpa 4 times. I wouldn't mind such a function if we find a good name for it. No point in making it a macro or a defsubst, I think.