From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#22018: 25.0.50; REGRESSION wrt `isearch-new-word' Date: Thu, 26 Nov 2015 16:29:08 -0800 (PST) Message-ID: <05c9d4b4-736a-4825-9f5d-0b1544487b56@default> References: <70438b05-f1ac-4087-b803-685e5c71db41@default> <774616e6-3d7e-4aa5-b120-812f1c24e0e4@default> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1448584232 6363 80.91.229.3 (27 Nov 2015 00:30:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 27 Nov 2015 00:30:32 +0000 (UTC) Cc: 22018@debbugs.gnu.org To: bruce.connor.am@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Nov 27 01:30:16 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1a26vV-0007n9-Ne for geb-bug-gnu-emacs@m.gmane.org; Fri, 27 Nov 2015 01:30:13 +0100 Original-Received: from localhost ([::1]:53704 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a26vY-0005zz-5J for geb-bug-gnu-emacs@m.gmane.org; Thu, 26 Nov 2015 19:30:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a26vT-0005zj-Bg for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 19:30:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a26vO-0005as-C4 for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 19:30:11 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:36861) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a26vO-0005Zh-9C for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 19:30:06 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1a26vN-0002si-DC for bug-gnu-emacs@gnu.org; Thu, 26 Nov 2015 19:30:05 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Nov 2015 00:30:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22018 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22018-submit@debbugs.gnu.org id=B22018.144858415410998 (code B ref 22018); Fri, 27 Nov 2015 00:30:05 +0000 Original-Received: (at 22018) by debbugs.gnu.org; 27 Nov 2015 00:29:14 +0000 Original-Received: from localhost ([127.0.0.1]:54802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a26uX-0002rJ-Ka for submit@debbugs.gnu.org; Thu, 26 Nov 2015 19:29:13 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:45826) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1a26uV-0002rB-PU for 22018@debbugs.gnu.org; Thu, 26 Nov 2015 19:29:12 -0500 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id tAR0TA4s011486 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 27 Nov 2015 00:29:10 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.13.8/8.13.8) with ESMTP id tAR0TA8I007861 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 27 Nov 2015 00:29:10 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id tAR0TA58013445; Fri, 27 Nov 2015 00:29:10 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:109320 Archived-At: > > An alias (e.g., `defvaralias') would make it a global > > variable, no? >=20 > Yes. I'll probably do that anyway. There's obviously code > out there calling setq on this variable. Since this variable > is no longer let bound, these setq will globally define the > variable anyway. Any such code out there would be used within the scope of the macro (i.e., in BODY) - that's the point of such code. It would count on the `let' binding in `with-search-suspended'. So an alternative to adding a global binding would be to first bind `isearch-new-word' to `isearch-regexp-function', just as was done before. That DTRT. Any assignment by setq in BODY would *not* "globally define the variable anyway." That would let any 3rd-party code that uses `isearch-new-word' behave exactly the same as before wrt that local variable. The behavior could be altered negatively or unexpectedly if we suddenly change the variable to a defvar. But this is more of a nit. I think it makes the behavior cleaner, but admittedly it makes the code messier. So please do whatever you think best, as long as the bug gets fixed. Thx.