From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#39944: 27.0.90; JIT Stealth timer errors Date: Sun, 8 Mar 2020 00:41:05 -0800 Organization: UCLA Computer Science Department Message-ID: <05a3b1d0-193a-02e5-0d38-9586767f3655@cs.ucla.edu> References: <83a74tiyyd.fsf@gnu.org> <837dzxiyr8.fsf@gnu.org> <835zfhiyag.fsf@gnu.org> <83h7z1bh0d.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="81834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: 39944@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 08 09:42:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jArVk-000LAA-J3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Mar 2020 09:42:12 +0100 Original-Received: from localhost ([::1]:55958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jArVj-0005Wk-8i for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Mar 2020 04:42:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51554) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jArVb-0005Wb-M8 for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2020 04:42:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jArVa-0001hL-NQ for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2020 04:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41894) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jArVa-0001gp-K2 for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2020 04:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jArVZ-0006ka-Pj for bug-gnu-emacs@gnu.org; Sun, 08 Mar 2020 04:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Mar 2020 08:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39944 X-GNU-PR-Package: emacs Original-Received: via spool by 39944-submit@debbugs.gnu.org id=B39944.158365687925901 (code B ref 39944); Sun, 08 Mar 2020 08:42:01 +0000 Original-Received: (at 39944) by debbugs.gnu.org; 8 Mar 2020 08:41:19 +0000 Original-Received: from localhost ([127.0.0.1]:47867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jArUs-0006jh-ON for submit@debbugs.gnu.org; Sun, 08 Mar 2020 04:41:18 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jArUq-0006jP-7k for 39944@debbugs.gnu.org; Sun, 08 Mar 2020 04:41:16 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E41CD16009E; Sun, 8 Mar 2020 00:41:06 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AwakKcWxyrak; Sun, 8 Mar 2020 00:41:06 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 229CD1600AF; Sun, 8 Mar 2020 00:41:06 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ngIhS-u1XOt9; Sun, 8 Mar 2020 00:41:06 -0800 (PST) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id DF9FC16009E; Sun, 8 Mar 2020 00:41:05 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:177043 Archived-At: >> Although comments in that area no doubt could use improvement, I'd rather not >> see comments like this: >> >> /* Add TM_YEAR_BASE to mpz[0]. */ >> mpz_add_ui (mpz[0], mpz[0], TM_YEAR_BASE); > > There are quite a few of similar comments there, I don't see any similar comments for simple calls from Emacs to mpz_add_ui. And I doubt whether there should be, any more than image.c should have comments like this: /* Use components from GC to draw a line on DPY's PIXMAP from (X, Y) to (X+WIDTH-1, Y+HEIGHT-1). */ XDrawLine (dpy, pixmap, gc, x, y, x + width - 1, y + height - 1); Emacs does not do comments like that, because they would clutter the code if you already know what XDrawLine does; and if you don't know, it's easy enough to look it up - which you should do anyway, and you'll need to do it anyway if you want to understand commentary like "components from GC" and "DPY's PIXMAP". Similarly for nearly every library function Emacs calls. GMP should be no different from other libraries in this respect. > But I really meant that stuff like this lacks a comment: > > hz = make_integer_mpz (); > mpz_swap (mpz[0], *iticks); > ticks = make_integer_mpz (); > > And also functions like timespec_ticks, lisp_time_hz_ticks, and > lisp_time_seconds, which don't have a single comment describing how > they do their thing. I added a few comments here and there. But I didn't go down to the level of commenting every call. >> But it might be better in master to remove the "Invalid time format" >> check entirely. > > I'm fine with removing that test, if we are sure that invoking > run-at-time with something utterly un-timely, like a symbol or a a > string that cannot be a valid time description, will trigger an error > (presumably from timer-set-time). Yes, that's what happens. I removed the test in master.