From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 39944@debbugs.gnu.org
Subject: bug#39944: 27.0.90; JIT Stealth timer errors
Date: Sun, 8 Mar 2020 00:41:05 -0800 [thread overview]
Message-ID: <05a3b1d0-193a-02e5-0d38-9586767f3655@cs.ucla.edu> (raw)
In-Reply-To: <bcd022c6-90f8-9c10-1188-40f9089013d2@cs.ucla.edu>
>> Although comments in that area no doubt could use improvement, I'd rather not
>> see comments like this:
>>
>> /* Add TM_YEAR_BASE to mpz[0]. */
>> mpz_add_ui (mpz[0], mpz[0], TM_YEAR_BASE);
>
> There are quite a few of similar comments there,
I don't see any similar comments for simple calls from Emacs to mpz_add_ui. And
I doubt whether there should be, any more than image.c should have comments like
this:
/* Use components from GC to draw a line on DPY's PIXMAP from (X, Y)
to (X+WIDTH-1, Y+HEIGHT-1). */
XDrawLine (dpy, pixmap, gc, x, y, x + width - 1, y + height - 1);
Emacs does not do comments like that, because they would clutter the code if you
already know what XDrawLine does; and if you don't know, it's easy enough to
look it up - which you should do anyway, and you'll need to do it anyway if you
want to understand commentary like "components from GC" and "DPY's PIXMAP".
Similarly for nearly every library function Emacs calls. GMP should be no
different from other libraries in this respect.
> But I really meant that stuff like this lacks a comment:
>
> hz = make_integer_mpz ();
> mpz_swap (mpz[0], *iticks);
> ticks = make_integer_mpz ();
>
> And also functions like timespec_ticks, lisp_time_hz_ticks, and
> lisp_time_seconds, which don't have a single comment describing how
> they do their thing.
I added a few comments here and there. But I didn't go down to the level of
commenting every call.
>> But it might be better in master to remove the "Invalid time format"
>> check entirely.
>
> I'm fine with removing that test, if we are sure that invoking
> run-at-time with something utterly un-timely, like a symbol or a a
> string that cannot be a valid time description, will trigger an error
> (presumably from timer-set-time).
Yes, that's what happens. I removed the test in master.
next prev parent reply other threads:[~2020-03-08 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 10:01 bug#39944: 27.0.90; JIT Stealth timer errors Eli Zaretskii
2020-03-06 10:06 ` Eli Zaretskii
2020-03-06 10:16 ` Eli Zaretskii
2020-03-06 16:11 ` Eli Zaretskii
2020-03-07 18:02 ` Paul Eggert
2020-03-07 18:29 ` Eli Zaretskii
2020-03-08 8:41 ` Paul Eggert [this message]
2020-03-08 15:10 ` Eli Zaretskii
2020-09-20 8:33 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05a3b1d0-193a-02e5-0d38-9586767f3655@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=39944@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.