Re: [Emacs-diffs] master 7e294d5: Remove some obsolete integer overflow handling

Re: [Emacs-diffs] master 7e294d5: Remove some obsolete integer overflow handling

[Pip Cet]

[-- Attachment #1: Type: text/plain, Size: 1172 bytes --]

On Mon, Jul 22, 2019 at 5:28 PM Mattias Engdegård
<mattiase@savannah.gnu.org> wrote:
> diff --git a/lisp/subr.el b/lisp/subr.el
> index 4a1649f..9fd3366 100644
> --- a/lisp/subr.el
> +++ b/lisp/subr.el
> @@ -681,14 +681,12 @@ of course, also replace TO with a slightly larger value
>      (when (zerop inc) (error "The increment can not be zero"))
>      (let (seq (n 0) (next from) (last from))
>        (if (> inc 0)
> -          ;; The (>= next last) condition protects against integer
> -          ;; overflow in computing NEXT.
> -          (while (and (>= next last) (<= next to))
> +          (while (<= next to)
>              (setq seq (cons next seq)
>                    n (1+ n)
>                    last next
>                    next (+ from (* n inc))))
> -        (while (and (<= next last) (>= next to))
> +        (while (>= next to)
>            (setq seq (cons next seq)
>                  n (1+ n)
>                  next (+ from (* n inc)))))

This causes a warning here:

  ELC      ../lisp/subr.elc

In toplevel form:
subr.el:655:1:Warning: Unused lexical variable ‘last’

which is fixed by the attached patch.

[-- Attachment #2: 0001-Avoid-byte-compiler-warning-for-subr.el.patch --]
[-- Type: application/x-patch, Size: 964 bytes --]

Re: [Emacs-diffs] master 7e294d5: Remove some obsolete integer overflow handling

[Paul Eggert]

Thanks, I installed that.

Re: [Emacs-diffs] master 7e294d5: Remove some obsolete integer overflow handling

[Mattias Engdegård]

23 juli 2019 kl. 01.19 skrev Pip Cet <pipcet@gmail.com>:

> subr.el:655:1:Warning: Unused lexical variable ‘last’
> 
> which is fixed by the attached patch.

23 juli 2019 kl. 02.47 skrev Paul Eggert <eggert@cs.ucla.edu>:

> Thanks, I installed that.

Sorry about that, and thank you both!