From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Why does make run git? Date: Tue, 1 Aug 2017 08:10:59 -0700 Organization: UCLA Computer Science Department Message-ID: <056f3714-9c2d-3983-ab48-f677da0718d1@cs.ucla.edu> References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1501600316 18136 195.159.176.226 (1 Aug 2017 15:11:56 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 1 Aug 2017 15:11:56 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 To: rms@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 01 17:11:51 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYpr-0004Rm-7i for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 17:11:51 +0200 Original-Received: from localhost ([::1]:43187 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYpx-000168-AA for ged-emacs-devel@m.gmane.org; Tue, 01 Aug 2017 11:11:57 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38015) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcYp9-00014n-7V for emacs-devel@gnu.org; Tue, 01 Aug 2017 11:11:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcYp5-0008Ks-NF for emacs-devel@gnu.org; Tue, 01 Aug 2017 11:11:07 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcYp5-0008Gl-Bi; Tue, 01 Aug 2017 11:11:03 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8537F160702; Tue, 1 Aug 2017 08:11:00 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id D05Od5hLgpDe; Tue, 1 Aug 2017 08:10:59 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 98038160704; Tue, 1 Aug 2017 08:10:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 6SRqsUHtJuWg; Tue, 1 Aug 2017 08:10:59 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 7CE5F160702; Tue, 1 Aug 2017 08:10:59 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217208 Archived-At: Richard Stallman wrote: > I was surprised to see this output from `make'. What does this do? > It seems fundamentally unmodular for building Emacs from sources > to concern itself in any way with how you got those sources. Make configures Git only if you got the sources via Git and have not conf= igured=20 Emacs. If you got the sources via some other means, or have already confi= gured=20 Emacs, Make doesn't configure Git. So I don't see a violation of modulari= ty=20 here; it's merely a convenience that Make supplies a default configuratio= n if=20 you haven't already configured things. If you prefer to not configure Git even though you got the sources via Gi= t, you=20 can run 'make ALL_IF_GIT=3D' or './configure; make' after grabbing the so= urces.=20 However, the default Git configuration is typically more convenient. > Running make on the Emacs checkout seems like an inadequate place to > do this. There is no assurance that you will run make in that > checkout before committing anything. That's true. However, these are only guidelines, and it's not a huge trag= edy if=20 the guidelines are occasionally violated. > Perhaps there should be a function in Emacs that does this, and some > VC commands could call it. That would be nice. However, some developers don't use Emacs VC to check = in (I=20 typically use vc-dwim instead), and so it's good to have Git check things= as well.