From: Phil Sainty <psainty@orcon.net.nz>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 28863@debbugs.gnu.org
Subject: bug#28863: 26.0.90; [PATCH] Don't clobber docstrings of explicitly-defined mode hook variables
Date: Sun, 22 Oct 2017 15:51:29 +1300 [thread overview]
Message-ID: <05578489-27b2-e4ea-ba2f-ec0620fc4003@orcon.net.nz> (raw)
In-Reply-To: <874lqsdryr.fsf@users.sourceforge.net>
On 22/10/17 12:03, Noam Postavsky wrote:
> Giving a default value to a hook variable is problematic, because if
> the user has (add-hook 'foo-mode-hook 'some-other-fun) then they lose
> the default-value if foo-mode.el wasn't loaded yet.
Yes indeed; but there are certainly examples of this pattern in use.
I'll follow up separately about this, but I don't it has any direct
bearing on this patch.
> Seems fine to me.
> My only nitpick is that you seem to be adding tab-indented lines.
Yes, that seemed consistent with the existing sources (or at least there
was a mixture of tabs vs spaces, as I recall).
...and I now see that repository's .dir-locals.el sets indent-tabs-mode
to nil for emacs-lisp-mode. I didn't realise that had happened.
(Has a read of bug #20323.)
I'll remember this in future.
If no one objects to this being committed, then let's just untabify the
changes and amend the commit before pushing.
-Phil
next prev parent reply other threads:[~2017-10-22 2:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 12:35 bug#28863: 26.0.90; [PATCH] Don't clobber docstrings of explicitly-defined mode hook variables Phil Sainty
2017-10-21 23:03 ` Noam Postavsky
2017-10-22 2:51 ` Phil Sainty [this message]
2017-10-31 12:45 ` Noam Postavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05578489-27b2-e4ea-ba2f-ec0620fc4003@orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=28863@debbugs.gnu.org \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.