From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Herman@debbugs.gnu.org, =?UTF-8?Q?G=C3=A9za?= Newsgroups: gmane.emacs.bugs Subject: bug#59816: [PATCH]: bug#59816: 29.0.60; c++-ts-mode handles one-line comments badly Date: Tue, 6 Dec 2022 00:16:53 +0100 Message-ID: <0546f952-a765-2c59-1655-b15da41d6d25@gmail.com> References: <08257d6b-2426-bbdf-0ed4-edd161801ad6@gmail.com> <878rjmdnpa.fsf@thornhill.no> <83sfhu80o3.fsf@gnu.org> <87y1rmvveh.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10938"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Cc: casuri@gmail.com, 59816@debbugs.gnu.org To: Theodor Thornhill , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 06 00:18:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p2Kj3-0002d6-Rh for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 06 Dec 2022 00:18:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p2Kiq-0006Lm-Vt; Mon, 05 Dec 2022 18:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p2Kio-0006KE-Uz for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 18:18:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p2Kio-0005Qi-MM for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 18:18:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p2Kio-0002pO-8P for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 18:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Herman@debbugs.gnu.org, =?UTF-8?Q?G=C3=A9za?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 23:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59816 X-GNU-PR-Package: emacs Original-Received: via spool by 59816-submit@debbugs.gnu.org id=B59816.167028222310858 (code B ref 59816); Mon, 05 Dec 2022 23:18:02 +0000 Original-Received: (at 59816) by debbugs.gnu.org; 5 Dec 2022 23:17:03 +0000 Original-Received: from localhost ([127.0.0.1]:38988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Khr-0002p4-05 for submit@debbugs.gnu.org; Mon, 05 Dec 2022 18:17:03 -0500 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:43815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p2Khp-0002oe-H6 for 59816@debbugs.gnu.org; Mon, 05 Dec 2022 18:17:02 -0500 Original-Received: by mail-ej1-f54.google.com with SMTP id gu23so2094332ejb.10 for <59816@debbugs.gnu.org>; Mon, 05 Dec 2022 15:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5n+hkhw3OCNj9VGfFHbIxASwrOBG6g1qxL3uCNJHPA0=; b=NOa9l3shprcQ2vUuDMLiigxPJGJM/NZ+bD/WGNKKE3N0G3adFbhSJZBMQJpfeih5A4 JExOIwFS7IdF4s3LyN1tjDBmj4D3Z7Fy0oyVJ7/uIORImYCDSsioL0u/iXs+rs8vEwM+ M+LFDSdxoy2u39vKcw5/Pn3yEd4M6n6uLjhNXl7H7g/3LWtkZa6oB3Q1trlX4T2DDfwB IDGMT/sxKoSMOCR8kj2xLBh1pg/rZCUoXpL7tOlzZ+tvaAlH/wFjV0VcAW7rM4BW1IwH 6ID8ei0csAGjyF5uNSjmHKoszeU2kd353aDSQfOY5Pt2BN5mdw4gzXakz0nunJEW+QWn IAjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5n+hkhw3OCNj9VGfFHbIxASwrOBG6g1qxL3uCNJHPA0=; b=TQlch9vfX05OyEDP+aHXEdHOP7iiMCWkS/phj+zXwa4JbmNANYCDkVDmxYaXKHwwHH oSsGRoxRr7Y2fKt/9OQ+0nwwAqsDijh65RlZzJQQU/bZ4X0pZs3sjDtVvLyXOWO3MgSs oZnzczoOuwoEHz94lLxnXnbIvtFVFEAPhFAx9MnV1qoyrJBeJ5z02FRC294arj4vfL8d qLbtPA0Axj/ja4m9liiHJQQ1As+cu/kpPagSc3h5otn6GZljrRF5MusmtUY4yC0/mhc8 C/EXH31XlVnqo54ViqwlCJxpz3PwZPog3NRak8Wiqx6E9uxHsdil0b0yRBbo5fVrWJKy cLjg== X-Gm-Message-State: ANoB5pkfsuEIMBd6TeQfpZo2DDtZL1KTyz42U8PGBvkyf45wCNFNXoL7 P+5AOLDn7aIP5AKo8SW57L4= X-Google-Smtp-Source: AA0mqf5XtDY1fijxMAnE9UaZcNRBrmPEtBtBVKwOVtwTBEYfwgsp9V1TZk7v5AvjN5OVDHLdpJGbzQ== X-Received: by 2002:a17:906:3952:b0:7b9:2a28:f6ff with SMTP id g18-20020a170906395200b007b92a28f6ffmr53352391eje.61.1670282215510; Mon, 05 Dec 2022 15:16:55 -0800 (PST) Original-Received: from [192.168.8.4] (netacc-gpn-204-103-46.pool.yettel.hu. [5.204.103.46]) by smtp.gmail.com with ESMTPSA id o17-20020a170906769100b00782fbb7f5f7sm6681415ejm.113.2022.12.05.15.16.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 15:16:54 -0800 (PST) Content-Language: sv-FI In-Reply-To: <87y1rmvveh.fsf@thornhill.no> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250076 Archived-At: Hi Theo, yes, it works correctly with your patch, thanks! On 12/5/22 14:21, Theodor Thornhill wrote: > Eli Zaretskii writes: > >>> From: Theodor Thornhill >>> Cc: geza.herman@gmail.com, eliz@gnu.org >>> Date: Mon, 05 Dec 2022 13:44:49 +0100 >>> >>> You're right. This is my bad. This patch addresses it. What do you >>> think, Eli? >> I'll defer to people who know more than I do about these modes. >> > Sure, added Yuan to CC. > >>> BTW - I see that many modes in general don't refer to their >>> syntax-tables in their define-derived-mode form. Is that intentional? >> The ELisp manual says: >> >> -- Macro: define-derived-mode variant parent name docstring >> keyword-args... body... >> This macro defines VARIANT as a major mode command, using NAME as >> the string form of the mode name. VARIANT and PARENT should be >> unquoted symbols. >> >> The new command VARIANT is defined to call the function PARENT, >> then override certain aspects of that parent mode: >> >> [...] >> >> • The new mode has its own syntax table, kept in the variable >> ‘VARIANT-syntax-table’, unless you override this using the >> ‘:syntax-table’ keyword (see below). ‘define-derived-mode’ >> makes the parent mode’s syntax-table the parent of >> ‘VARIANT-syntax-table’, unless the latter is already set and >> already has a parent different from the standard syntax table. >> >> So there's no need to mention it because it happens automatically. > Right, thanks! > > Can you test this patch, Herman, and see if it works for you now? > > Theo