From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#38044: 27.0.50; There should be an easier way to look at a specific vc commit Date: Thu, 21 Nov 2019 23:05:07 +0200 Message-ID: <0521b598-33ec-c0b5-42ff-fb6ff779b7e4@yandex.ru> References: <87ftj5at1q.fsf@gnus.org> <87r22phsoj.fsf@gmx.net> <87bltslnpo.fsf@mail.linkov.net> <87d0dvmqu8.fsf@mail.linkov.net> <590e595e-8220-1c7e-bd4a-b2eb0968e289@yandex.ru> <87r226xl8m.fsf@mail.linkov.net> <24c56bca-8d7d-3a20-aeef-5d11f8a075e6@yandex.ru> <87pnhquo4k.fsf@mail.linkov.net> <6087186e-a444-0aac-e87d-596d2e36f0ce@yandex.ru> <877e3wub09.fsf@mail.linkov.net> <5ce7d4f0-3884-fd27-09dc-c38f01a19958@yandex.ru> <83zhgr26c3.fsf@gnu.org> <87blt7qxhz.fsf@mail.linkov.net> <837e3v1aae.fsf@gnu.org> <87y2warzv3.fsf@mail.linkov.net> <83r221xoll.fsf@gnu.org> <83a78pxenu.fsf@gnu.org> <215302ff-8252-1f6c-5f60-aaba01cd615f@yandex.ru> <837e3tx9s8.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="92752"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: larsi@gnus.org, stephen.berman@gmx.net, 38044@debbugs.gnu.org, juri@linkov.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Nov 21 22:06:18 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iXtea-000NvE-0o for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 22:06:16 +0100 Original-Received: from localhost ([::1]:45834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXteY-0001H6-8C for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Nov 2019 16:06:14 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47376) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iXteO-0001H0-Ts for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:06:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iXteM-0008JH-Vb for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:06:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44566) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iXteM-0008J7-Nt for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:06:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iXteL-0002lB-LH for bug-gnu-emacs@gnu.org; Thu, 21 Nov 2019 16:06:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Nov 2019 21:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38044 X-GNU-PR-Package: emacs Original-Received: via spool by 38044-submit@debbugs.gnu.org id=B38044.157437033210569 (code B ref 38044); Thu, 21 Nov 2019 21:06:01 +0000 Original-Received: (at 38044) by debbugs.gnu.org; 21 Nov 2019 21:05:32 +0000 Original-Received: from localhost ([127.0.0.1]:53387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtds-0002kO-AT for submit@debbugs.gnu.org; Thu, 21 Nov 2019 16:05:32 -0500 Original-Received: from mail-wr1-f68.google.com ([209.85.221.68]:34284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iXtdq-0002k6-4e for 38044@debbugs.gnu.org; Thu, 21 Nov 2019 16:05:30 -0500 Original-Received: by mail-wr1-f68.google.com with SMTP id t2so6193781wrr.1 for <38044@debbugs.gnu.org>; Thu, 21 Nov 2019 13:05:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EDpVRbz6a3E6v20985EMr4p+kA6OGt5Yv0OmUfI3rO0=; b=A8/9iX12/vVayKVVCXSmcGlL18qSYQzUvarMXJq13PdNdibJTMrh8PR/LZiMaYS0zS vCXqOBd3JCv0A66NDw+CzJnCkdD+n8mWqN97I/8e/fM+d4IIFxM3D+48S+cs5BdP9Crq 60WUXLvLvsGLXnFrDXQZA/16Jpxfo2azDeSPpBZw+5Hbzg3XgUikKcmk61CGwCAMXZdH fr87/W1fThC4yU8RSBJwEXUYbm9SUXxYwd0nHbQUhhYFUR2wUr3m1gU+Dpxe35Gl7zHA raxCeH1SN6YbrDAHmXONtZICPEBeLF2dJ6yahAb/p5On0JpFBb3aqwtQfibw8GIIZcMv ExZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EDpVRbz6a3E6v20985EMr4p+kA6OGt5Yv0OmUfI3rO0=; b=SAGPEzyDBuFLp1nXfZ6dyP6RFJQA18tRrdeVg+89pEhV0Opig4O91RnHlX7HzJFeSc lzl/Qp2Vgcxflx/NCB1pfGw2CbiY7tHg3NbdhJS3l5Q85SbuWvfYSyq9FCkeX2yn0hJd tGN/4XqoLh6tq6oJ40UHWYxCX8xcSFinJRPWNE6hI4x5tumEocdDhjjQcEGm8fnx9PF9 gLGg8k4LB1JARGPHz1fAEIwfx+k/UDvHYEgEZ9MDjqCveeNKZEZwTlrrzGKX1T8TwGgI 44hDgDdwE2Hy7VD9+j1PRaxGk3VF1sTrTosWujod9FcErzwBeaB1hD9KJO7EVv0GPzYI TbVg== X-Gm-Message-State: APjAAAVkRFwXuS7gkzB5ZPjDNCJUTE/6LdF/8e7QKw744cFaVFIRE/+7 wN6+TBF0ROj+m2ErnxSkJ9E= X-Google-Smtp-Source: APXvYqxpw32jvqDjBgJdvLY091CsPoCZRC2e8PHWxtezm87ZJ+vi8YdxcdmAcVmZoh9pb8bw1FYobw== X-Received: by 2002:adf:a497:: with SMTP id g23mr13796414wrb.129.1574370319514; Thu, 21 Nov 2019 13:05:19 -0800 (PST) Original-Received: from [192.168.0.5] ([212.50.117.215]) by smtp.googlemail.com with ESMTPSA id 205sm1160103wmb.3.2019.11.21.13.05.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 21 Nov 2019 13:05:18 -0800 (PST) In-Reply-To: <837e3tx9s8.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172160 Archived-At: On 21.11.2019 22:19, Eli Zaretskii wrote: >> "As I said before", when a revision is created, we fill in a number of >> different fields, most importantly, the commit message. That's in every >> VCS except some ancient ones. So to show a revision means to show all >> that stuff. > > Here's an alternative proposal. It seems like almost all VCS backends > we support provide a variant of a "log" command that shows the diffs > together with the usual meta-data shown by "log". Only RCS and CVS > don't have such an option of "log", all the rest do (most of them via > "log -p"). Somewhat better, but all backends would have to be updated anyway, for this to work. So the change in VC backend API is comparable to adding a new action. I don't mind this too much (asking vc-git-print-log to include the diffs makes sense, at least), but doing it this way loses out on the opportunity to support all backends in one fell swoop. And we can do that by adding a default 'print-revision' implementation that calls two other backend actions (print-log and diff). Or, again, we can do that for all backends and forego a new backend action altogether. > So we could make this a subcommand of vc-log, more accurately > vc-print-root-log, such that "C-u C-u C-x v L" will prompt for a > revision ID, and display the information produced by such a "log -p" > command (and fall back to displaying just the diffs for RCS and CVS). > > Does this sound better? I hardly see myself ever choosing 'C-u C-u C-x v L' instead of 'M-x vc-print-revision'. Simply because I'll never remember the former. Are you really that against a new command? Considering we have vc-print-branch-log for simply showing the same thing for a different branch, that feels... inconsistent.