From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35624: log-view-diff regression Date: Wed, 8 May 2019 01:54:32 +0300 Message-ID: <051f40d7-206b-e5b5-f0b7-2354d0552dcf@yandex.ru> References: <87pnou2ak2.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="207932"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 To: Juri Linkov , 35624@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 08 00:55:11 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hO8zP-000rzy-9N for geb-bug-gnu-emacs@m.gmane.org; Wed, 08 May 2019 00:55:11 +0200 Original-Received: from localhost ([127.0.0.1]:55826 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO8zO-0008CX-7C for geb-bug-gnu-emacs@m.gmane.org; Tue, 07 May 2019 18:55:10 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hO8zH-0008CM-HF for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:55:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hO8zG-0005Z4-HL for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:55:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46382) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hO8zG-0005YV-Dd for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:55:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hO8zG-0007C3-6w for bug-gnu-emacs@gnu.org; Tue, 07 May 2019 18:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 May 2019 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35624 X-GNU-PR-Package: emacs Original-Received: via spool by 35624-submit@debbugs.gnu.org id=B35624.155726968327621 (code B ref 35624); Tue, 07 May 2019 22:55:02 +0000 Original-Received: (at 35624) by debbugs.gnu.org; 7 May 2019 22:54:43 +0000 Original-Received: from localhost ([127.0.0.1]:59926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO8yx-0007BR-0n for submit@debbugs.gnu.org; Tue, 07 May 2019 18:54:43 -0400 Original-Received: from mail-wm1-f68.google.com ([209.85.128.68]:40188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hO8yu-0007BC-KA for 35624@debbugs.gnu.org; Tue, 07 May 2019 18:54:41 -0400 Original-Received: by mail-wm1-f68.google.com with SMTP id h11so619765wmb.5 for <35624@debbugs.gnu.org>; Tue, 07 May 2019 15:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YVoqYEkz8P82JkcgmR/yQcueQnEh/1TMjsfl6N/rt8c=; b=DMBwZmgEFvpmfgnRpgvbCgVSqucJprZ80oY0f9k0P0fKPmRZrLPjBFIoXIGbbQpnKM L9ndrwe68V48EVr0/ceV6pyBqAMi+/sqa42a+KsDu+2AkbwUrFgEBRqnxWEhLia+wqv8 SWlwOs16HDL7rl7AVRU7vThuh+YzqjvcXEzm4m0Q74jNiaSpHBR9BI1j2YCXFH6I0uEZ TJKhdlBNgSJjf+7EMfCI9susUyQQ3hq4MTfzwSf9wlJy1QfNe7Kh4BNOgZjW6m5uh9cX WCwVot1sndAMQloBILVW+YYyHVuCz47Jmf7kDdQitlcK5/gj8dquxuXWOJ7HE0ZKWdjc k05A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=YVoqYEkz8P82JkcgmR/yQcueQnEh/1TMjsfl6N/rt8c=; b=uLYxEuPjQWgVyy8MXXdvshzVhqv9zCAuOENB2g0ZnkEoUW5cLLq0pYIIBXhgNjXXbD cHctNuySTIInhwkhi1SgCHU1Y4A6T36tzs091LUZoIMcpEq7IMoVRrGdH4R+39F6ESFb +KQL7JHef7j2uUUKF7CEJBEorGpTYl1vFykCmbzZEGxClB0gbwkHXlKmavLMnDGcgjSK jEfFEGoX6T4ifRvm6+wLaPbDOP33+qQpXajnU6fn2Z9fJJIIEIT8zjXHbaizZNMqEhCd iVeUGrVUFlAuVcW42PX0QNqJ2OaeayatMRuOgor9+BPpOcdZQhNCK+PrmXGOdcqmMqvP aqdw== X-Gm-Message-State: APjAAAWkDt3wKAFjhlMa38g7G3PUIiVYbJ89Rae0u9uQkf10rCSzPf7B VvNsadiCJ6v5GQJd2bBxeL91LI30 X-Google-Smtp-Source: APXvYqzDolncK2G+Hh3Jj8IDnMS4wSRH9J+PyWZ3u2a9XbHm/GrGAq5PZsS74HhRh02eOUlEUxZqpA== X-Received: by 2002:a05:600c:24d0:: with SMTP id 16mr506105wmu.21.1557269674410; Tue, 07 May 2019 15:54:34 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id p67sm309671wmp.22.2019.05.07.15.54.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 May 2019 15:54:33 -0700 (PDT) In-Reply-To: <87pnou2ak2.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:158900 Archived-At: On 08.05.2019 0:56, Juri Linkov wrote: > bug#28466 caused a regression in 26.0.50. Maybe it's too late to fix it > in the release branch, so the patch below is for master. > > The problem is that after the change a year and a half ago > log-view-diff always falls back to the previous revision > even when point is in the middle of the log buffer, > and not after the last entry. > > This patch uses the previous revision only at the end of the log buffer: Hi Juri, I think the patch should look like the one below instead. Does it fix your problem? It also looks "obviously correct" in my opinion. Your proposal would fail in the presence of "Show 2X entries" (when the log is long enough). diff --git a/lisp/vc/log-view.el b/lisp/vc/log-view.el index e47fad8908..e1e453115b 100644 --- a/lisp/vc/log-view.el +++ b/lisp/vc/log-view.el @@ -621,7 +621,8 @@ log-view-diff-common (>= (point) (save-excursion (goto-char (car fr-entry)) - (forward-line)))) + (forward-line) + (point)))) (setq fr (vc-call-backend log-view-vc-backend 'previous-revision nil fr))) (vc-diff-internal t (list log-view-vc-backend