From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Gerd_M=C3=B6llmann?= Newsgroups: gmane.emacs.devel Subject: Re: Question on https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=d0b1e3647fb4e6d889f9f999388c53daf0e67f0d Date: Thu, 21 Sep 2023 10:46:56 +0200 Message-ID: <04a0c0f2-a3b6-47f3-b4da-fed2dadd0ee2@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26708"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird To: Pedro Andres Aranda Gutierrez , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 21 10:48:00 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjFLs-0006mo-JX for ged-emacs-devel@m.gmane-mx.org; Thu, 21 Sep 2023 10:48:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjFL8-0000Jl-R2; Thu, 21 Sep 2023 04:47:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjFKy-0000FO-SN for emacs-devel@gnu.org; Thu, 21 Sep 2023 04:47:12 -0400 Original-Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjFKx-0003Yv-7p for emacs-devel@gnu.org; Thu, 21 Sep 2023 04:47:04 -0400 Original-Received: by mail-ej1-x635.google.com with SMTP id a640c23a62f3a-99357737980so79912866b.2 for ; Thu, 21 Sep 2023 01:47:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695286021; x=1695890821; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tOdoJ+zQ/2QPvNa1021jqyx0m/dwls9zXCrt7JWYOAo=; b=ikVMqxm0j96qArMiKOHTssj56BqZxEpROZbxgyo2j3gVR1R+MmVZYt2NlATiVvJLaE APfFZB9WORzhS/lOXZIFeC61aOICgAH/P0BNQnuNmbqtuPqpxl5rEd+r4g7G8Nsnyt+4 s3ZEGydru5ij5/GDyH5hzbgNu07gNSF+/t0zfo5Yg9bIJCo+naa45jc9UhMz4fs9NNDC 63JdUp3+YNQIQgdFEcLg0OPkOQrr8xgfdsHEYL3+jQ3u9DYmN0ICJqePYU9y8ZVI+WIj GpbI4o4zXjpS8oBQ4wAcoODw6XEKAHr+WpXEy6XK8Ubw/VKRbIeAFXrSA1oK0Wfgb8K7 9sFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695286021; x=1695890821; h=content-transfer-encoding:in-reply-to:from:references:newsgroups:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tOdoJ+zQ/2QPvNa1021jqyx0m/dwls9zXCrt7JWYOAo=; b=kXaPRMA9XsjJcCeKX712+c40Nh/ZGHeNvWUYefJBcQjOUyxUSRNLaw2fLtGnzmvWj2 C5vK6lfSjxObV7bevA0d44URQ1UBNIU05yt6nIGb8430ETbcb/A6IjnxQa4WDfPSdtEE H6QkuyhWTlf06ZY0HroT95K5y0mpr3jeVL+mDXPygQRpQLpzYOP7BrCCG15gK8L61gzs myRXOiw7EL+Dt/9Zhl+mVUp+nlO81Z8zj45kuRmDjuR57tNPA74czsiz2YVmXv03zAqY 7gIX+LbFt9WAr2Y+1lAMLZVPT/4S5V4Ikq+e1u/s95uoY12BKVGyqQRHlvK6k/fFGvgS 6xWQ== X-Gm-Message-State: AOJu0YyqB3ubiDSgui8Ng9SPqt1h3I67VcXGIvNyhGG0etiXKBYDYbgO +R3B3kor4lpvLG6mHF6iyVs= X-Google-Smtp-Source: AGHT+IG3yPuWzxr3MjF1dtgshxUmA/Zuw8AwsOjjm+HoqlJ8dPy+MM66e2WxUG7cizDHWW7KeQzTCQ== X-Received: by 2002:a17:907:985b:b0:9ae:3d56:1ef1 with SMTP id jj27-20020a170907985b00b009ae3d561ef1mr4047736ejc.8.1695286021300; Thu, 21 Sep 2023 01:47:01 -0700 (PDT) Original-Received: from [192.168.178.26] (p4fe3aa86.dip0.t-ipconnect.de. [79.227.170.134]) by smtp.gmail.com with ESMTPSA id d12-20020a1709064c4c00b0099bd86f9248sm712608ejw.63.2023.09.21.01.47.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Sep 2023 01:47:00 -0700 (PDT) Content-Language: en-US, de-DE Original-Newsgroups: gmane.emacs.devel In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=gerd.moellmann@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:310873 Archived-At: On 23-09-21 8:29 , Pedro Andres Aranda Gutierrez wrote: > Hi > > reading removed FIXME in the second hunk: > > # FIXME: Don't install the dump file into the app bundle when > # self-contained install is disabled. > > I understand that we should install if self-contained is enabled. > > However, I see > > +ifeq (${ns_self_contained},no) > > Shouldn't that read as > > +ifeq (${ns_self_contained},yes) > > I'm confused... I assume that is nextstep/Makefile.in. We want to cp the .pdmp file only if we don't do a self-contained build (...=no).