From: "Mitchell, Paul" <Paul.Mitchell@amd.com>
To: "Stefan Monnier" <monnier@iro.umontreal.ca>
Cc: 1243@emacsbugs.donarmstrong.com, bug-gnu-emacs@gnu.org, "Bilik,
Scott" <Scott.Bilik@amd.com>, Wilson Snyder <wsnyder@wsnyder.org>
Subject: bug#1243: Verilog mode hanging emacs 22.2
Date: Mon, 27 Oct 2008 10:38:13 -0400 [thread overview]
Message-ID: <049C4E48B10A854FB9D3B3C9DFAB506BC3D436@smarexmb1.amd.com> (raw)
In-Reply-To: <jwvbpx69lav.fsf-monnier+emacsbugreports@gnu.org>
Stefan,
I ran this against my test case just now and emacs no longer hangs. I'm
moving back to version 22, and will let you know if I see this again,
but it seems fixed.
Thanks for your help,
Paul
-----Original Message-----
From: Stefan Monnier [mailto:monnier@iro.umontreal.ca]
Sent: Monday, October 27, 2008 10:21 AM
To: Mitchell, Paul
Cc: 1243@emacsbugs.donarmstrong.com; bug-gnu-emacs@gnu.org; Bilik,
Scott; Wilson Snyder
Subject: Re: bug#1243: Verilog mode hanging emacs 22.2
> I ran emacs under gdb, from within the src directory. I then edited
the
> file that exhibits this problem and did a few incremental searches.
> This caused emacs to hang. I tried to break out of this from gdb
using
> ctrl-c, which killed emacs so that I could not use xbacktrace. Then,
> from the gdb prompt I used: "handle SIGINT stop", got back to the
hang,
> and tried ctrl-c again. I now was able to use xbacktrace, and see
this:
> (gdb) xbacktrace
> "re-search-backward" (0x86f1eeb)
> "verilog-beg-of-defun" (0x87cfd85)
> "byte-code" (0x8234d13)
> "verilog-syntax-ppss" (0x831e8c9)
> "verilog-skip-backward-comment-or-string" (0x8811595)
> "verilog-beg-of-defun" (0x87cfd85)
> "byte-code" (0x8234d13)
> "verilog-syntax-ppss" (0x831e8c9)
I believe the patch below will fix it. Wilson, WDYT?
Stefan
--- verilog-mode.el.~1.24.~ 2008-09-12 12:39:48.000000000 -0400
+++ verilog-mode.el 2008-10-27 10:18:58.000000000 -0400
@@ -2373,6 +2373,8 @@
;; Fontify things in translate off regions
'(verilog-match-translate-off
(0 'verilog-font-lock-translate-off-face
prepend))))))
+ ;; FIXME: This XEmacs setting is redundant with the setting done
later
+ ;; for Emacs (because XEmacs obeys's Emacs setting as well).
(put 'verilog-mode 'font-lock-defaults
'((verilog-font-lock-keywords
verilog-font-lock-keywords-1
@@ -2560,10 +2562,17 @@
;; Stuff for GNU Emacs
(set (make-local-variable 'font-lock-defaults)
- '((verilog-font-lock-keywords verilog-font-lock-keywords-1
+ `((verilog-font-lock-keywords verilog-font-lock-keywords-1
verilog-font-lock-keywords-2
verilog-font-lock-keywords-3)
- nil nil nil verilog-beg-of-defun))
+ nil nil nil
+ ,(if (functionp 'syntax-ppss)
+ ;; verilog-beg-of-defun uses syntax-ppss, and syntax-ppss
uses
+ ;; font-lock-beginning-of-syntax-function, so
+ ;; font-lock-beginning-of-syntax-function, can't use
+ ;; verilog-beg-of-defun.
+ nil
+ verilog-beg-of-defun)))
;;------------------------------------------------------------
;; now hook in 'verilog-colorize-include-files
(eldo-mode.el&spice-mode.el)
;; all buffer local:
next prev parent reply other threads:[~2008-10-27 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <wwbpt79dw2.fsf@fencepost.gnu.org>
2008-10-24 20:38 ` bug#1243: Verilog mode hanging emacs 22.2 Mitchell, Paul
2008-10-25 18:38 ` Stefan Monnier
2008-10-27 13:58 ` Mitchell, Paul
2008-10-27 14:20 ` Stefan Monnier
2008-10-27 14:38 ` Mitchell, Paul [this message]
2009-02-13 4:20 ` bug#1243: marked as done (Verilog mode hanging emacs 22.2) Emacs bug Tracking System
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=049C4E48B10A854FB9D3B3C9DFAB506BC3D436@smarexmb1.amd.com \
--to=paul.mitchell@amd.com \
--cc=1243@emacsbugs.donarmstrong.com \
--cc=Scott.Bilik@amd.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=wsnyder@wsnyder.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.