From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dave Abrahams Newsgroups: gmane.emacs.bugs Subject: bug#64198: Feature request: compile.el's "Find this in" prompt should be hookable. Date: Wed, 21 Jun 2023 09:09:08 -0700 Message-ID: <03EC2FC3-A297-4CD1-91FB-2262A319A6F3@boostpro.com> References: <837crx5a8x.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Content-Type: multipart/alternative; boundary="Apple-Mail=_868CB592-7A88-44BB-AD9C-49A4490AF95F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5459"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64198@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 21 18:10:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qC0Pd-0001Cm-Sj for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Jun 2023 18:10:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qC0PE-0003Tb-Kh; Wed, 21 Jun 2023 12:10:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC0PC-0003T3-Fv for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 12:10:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qC0PC-000627-5p for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 12:10:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qC0PB-0002vY-Ld for bug-gnu-emacs@gnu.org; Wed, 21 Jun 2023 12:10:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dave Abrahams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Jun 2023 16:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64198 X-GNU-PR-Package: emacs Original-Received: via spool by 64198-submit@debbugs.gnu.org id=B64198.168736376911208 (code B ref 64198); Wed, 21 Jun 2023 16:10:01 +0000 Original-Received: (at 64198) by debbugs.gnu.org; 21 Jun 2023 16:09:29 +0000 Original-Received: from localhost ([127.0.0.1]:34139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0Oe-0002uh-Jj for submit@debbugs.gnu.org; Wed, 21 Jun 2023 12:09:28 -0400 Original-Received: from mail-ot1-f54.google.com ([209.85.210.54]:49553) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0Oc-0002uT-A2 for 64198@debbugs.gnu.org; Wed, 21 Jun 2023 12:09:26 -0400 Original-Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6b5d57d7db9so398527a34.3 for <64198@debbugs.gnu.org>; Wed, 21 Jun 2023 09:09:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boostpro-com.20221208.gappssmtp.com; s=20221208; t=1687363760; x=1689955760; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:from:to:cc:subject:date:message-id:reply-to; bh=Gx7xRNC79PFcohDAvwKjCsVlppbbXPa9n5q2ZCzmORQ=; b=T+HO2e8LHwCmJlMrqgsPZsheeGO4rgqoCvwU+JLGlQhR6AQz8TmcI6yH8rwONSKnMV zqcWDQpK9LPRYzKB8H5KTUv7Urg41y1ZkhUPHx524jQvEWnVNSPE3g3ws5mO4rQHvueQ xp3Zpu79ciQyLJNPnSip5s6SPkO3m5XO8AdSAFtSHeuvg9MeXxKMD8d/OVqYJGOBnOa7 FEYpZPkY8lO4HS6r5qbXwkGuUhito9VrMrvsL5+9Wv1P5MYWHjplellwjYEeH2HIjSDa WDs+RQkcuL9qoQuib59RUVuxI05bkX+Jlne3qJ1ST98FOaq4yW6zTcsPLIov/F8otK3l ik+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687363760; x=1689955760; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Gx7xRNC79PFcohDAvwKjCsVlppbbXPa9n5q2ZCzmORQ=; b=AQ/LUNK42uQo4hnpltKTzr9BXQgd5ow0QQuV3EQ1cADWQ0fvZHG7yQMBIbiXGAaWIj FDFMljOyBfeygAlh1xgDl2L1KRXbh6FnLrgXa918uPlgGqMhdYe5cBxPnVLuCbKTF9kl Zunu6HZVKrxNItlwOvY4AF2EdaRIrTlLsE2zdpKecA4X0/D4xNkvqt2VlyjExs6FJaWN PSz2uMw4Of5WCHcm/79sTLqtmauil0cyJz4vphY4jQci+O+CmNeRpzC72gQpgmW6wBc5 AKNBRMfNRltUr7AYe/+ABT0WKYY/eJ28gy/sulNm8DOO+09a2gOefPJggACp2kPQJ4cp JoJw== X-Gm-Message-State: AC+VfDxLwB7CFr1CXsuyGMgBeXoY4wXWLz+tK0PCYXGDuQBPHl/WY1HJ pi2EDCHru5r/tyH3qIQ1z//Smg== X-Google-Smtp-Source: ACHHUZ5PDXqxcnR7v34cmakU/ErF/2/XPHlkJZ+Ktqo1CayCtD3pE06ImoUaR3aDQk7WGirlLHiD0g== X-Received: by 2002:a05:6358:704f:b0:12b:dd2b:f170 with SMTP id 15-20020a056358704f00b0012bdd2bf170mr7399705rwp.27.1687363760174; Wed, 21 Jun 2023 09:09:20 -0700 (PDT) Original-Received: from smtpclient.apple (69-209-31-205.lightspeed.sntcca.sbcglobal.net. [69.209.31.205]) by smtp.gmail.com with ESMTPSA id b65-20020a816744000000b0056183cdb2d9sm1195297ywc.60.2023.06.21.09.09.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2023 09:09:19 -0700 (PDT) In-Reply-To: <837crx5a8x.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.600.7) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263841 Archived-At: --Apple-Mail=_868CB592-7A88-44BB-AD9C-49A4490AF95F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 21, 2023, at 4:24 AM, Eli Zaretskii wrote: >=20 >> From: Dave Abrahams >> Date: Tue, 20 Jun 2023 15:30:58 -0700 >>=20 >> [I hope this is the right venue for feature requests. If not, = sorry!] >=20 > This is the right place. >=20 >> When a file can't be found via the path given in a diagnostic, I'd = like to be able to override the prompt that emacs gives to locate the = file. compilation-parse-errors-filename-function happens too early, = while the buffer is being initially parsed. A similar = compilation-locate-file-function would be great. If there's interest I = could try to develop a patch. >=20 > Before discussing patches, could you please describe your situation? > Specifically, how does it happen that neither the compilation > directory plus the file name shown by the diagnostics nor the search > of compilation-search-path succeed to locate the file? And what would > the hook function you suggest adding do to resolve this, i.e. how > would it know where to look for the file? When Swift asserts, it doesn't write the path to the file into the = output, because=E2=80=A6 reasons I grudgingly accept. So one needs to = guess at the file. https://github.com/apple/swift/issues/66777 contains = all the details, but if you want additional info, please ask.= --Apple-Mail=_868CB592-7A88-44BB-AD9C-49A4490AF95F Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

On Jun = 21, 2023, at 4:24 AM, Eli Zaretskii <eliz@gnu.org> wrote:

From: Dave Abrahams <dave@boostpro.com>
Date: = Tue, 20 Jun 2023 15:30:58 -0700

[I hope this is the right venue = for feature requests.  If not, sorry!]

This is = the right place.

When a file can't be = found via the path given in a diagnostic, I'd like to be able to = override the prompt that emacs gives to locate the file. =  compilation-parse-errors-filename-function happens too early, = while the buffer is being initially parsed.  A similar = compilation-locate-file-function would be great.  If there's = interest I could try to develop a patch.

Before = discussing patches, could you please describe your = situation?
Specifically, how does it happen that neither the = compilation
directory plus the file name shown by the diagnostics nor = the search
of compilation-search-path succeed to locate the file? =  And what would
the hook function you suggest adding do to = resolve this, i.e. how
would it know where to look for the = file?

When Swift asserts, it = doesn't write the path to the file into the output, because=E2=80=A6 = reasons I grudgingly accept.  So one needs to guess at the file. =  https://github.com/ap= ple/swift/issues/66777 contains all the details, but if you = want additional info, please ask.
= --Apple-Mail=_868CB592-7A88-44BB-AD9C-49A4490AF95F--