From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#51368: 29.0.50; `cl-case' should error on incorrect use Date: Sun, 3 Sep 2023 15:40:03 +0200 Message-ID: <03810284-957B-4ABD-8013-E9746FAFC17E@gmail.com> References: Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23525"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 51368@debbugs.gnu.org, Philipp Stephani , Lars Ingebrigtsen , Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 03 15:41:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcnLk-0005z6-Tq for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 03 Sep 2023 15:41:13 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcnLR-0004kD-Ag; Sun, 03 Sep 2023 09:40:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcnLQ-0004k1-M8 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 09:40:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcnLQ-0004H8-E7 for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 09:40:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcnLa-0001p7-He for bug-gnu-emacs@gnu.org; Sun, 03 Sep 2023 09:41:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Sep 2023 13:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51368 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51368-submit@debbugs.gnu.org id=B51368.16937484276956 (code B ref 51368); Sun, 03 Sep 2023 13:41:02 +0000 Original-Received: (at 51368) by debbugs.gnu.org; 3 Sep 2023 13:40:27 +0000 Original-Received: from localhost ([127.0.0.1]:40023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnL0-0001o7-Kd for submit@debbugs.gnu.org; Sun, 03 Sep 2023 09:40:26 -0400 Original-Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:46368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcnKw-0001no-7C for 51368@debbugs.gnu.org; Sun, 03 Sep 2023 09:40:25 -0400 Original-Received: by mail-lf1-x131.google.com with SMTP id 2adb3069b0e04-500c7796d8eso957731e87.1 for <51368@debbugs.gnu.org>; Sun, 03 Sep 2023 06:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693748405; x=1694353205; darn=debbugs.gnu.org; h=to:cc:date:message-id:subject:mime-version:from:sender:from:to:cc :subject:date:message-id:reply-to; bh=3zqYftnagsSStAs0TE3UGnNqNqNZU17TZ+K5d8pddd4=; b=r+armEAC7zHyt1TZ8SlpHZLGTu8wGwbeAIw1KjJqLmdDAfulilhrtke222bblo9bah wcKnXeyTZRy9weOzphbqzjiLCpuSRaaQ5/+WXxplUdzHAAIQ+6n4s56evrAJI1rdM3/U FtKnrB27BdA8xAAEWjyDDZMdOz1SP9IgcuRNWOUE3JN59vPIBVdQ2Dr9Fm6Z+u3367H0 iV4OfmGYhNVz0NCsqjp0+WjRi7IkOAybwYs58Bst07TLXyk+6y+rhcR8xev714M7pq6X SKiInj3S19O8u3QLsqcdmWxYdGBTeTdWc1kBFLJqczN3XRHKSJKqCXNr04sUqH/Qhu9d Kdjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693748405; x=1694353205; h=to:cc:date:message-id:subject:mime-version:from:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3zqYftnagsSStAs0TE3UGnNqNqNZU17TZ+K5d8pddd4=; b=HBOCtfkVPfz80lKLhC4H+lLKfUqzOCfmfKloaYYY6gItk1o/egyxhdbJrdfAqNItDp Nc3ybLdVrFolS00nlq2VjCLBRKk2a1hJF6urQrJrfmY/8u2jebXhSztQO42mvjSCr1UN DbkGA0+411iLyD500T92rw8DXVGJfEpDl623e6yttSh65W8eDfwMB2Q67ah1ayL6NyOk zYF0DTKI2+bdh7F9mYYU+I3piWdSoCctteoaMR+h+iz92cE9uBMDZDiyN/virCNYPXlF psX8cSwBI7L1DJG99cR/cbayIIK3O1XyR8lQyxickK+OWGJ3uEWJhgRICkKC/AwuWmQg 8PNw== X-Gm-Message-State: AOJu0Yy+mpBsS8LC5vcNet5Z47wZHKyeoWBqKoBJE9+Q35vzD0BVaUcI 6CF133gJ49dZM0frt8xeOtTs0NyfcoE= X-Google-Smtp-Source: AGHT+IGcEc579j8T21CM/OrF65JgaELn2pjZajevFLORx8qxOx/mXREi1MPEbTJ6YdLUGyD3YUgWTQ== X-Received: by 2002:a05:6512:3b8a:b0:4f8:7055:6f7e with SMTP id g10-20020a0565123b8a00b004f870556f7emr5651580lfv.44.1693748405260; Sun, 03 Sep 2023 06:40:05 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id f6-20020ac25326000000b004fe5688b5dcsm1272755lfh.150.2023.09.03.06.40.04 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 03 Sep 2023 06:40:04 -0700 (PDT) X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269164 Archived-At: --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > (cl-case EXP > ((a b) FOO) > ((a c) BAR)) >=20 > won't warn about the duplicate `a`. I was curious how common this could be so I locally added a warning to = the back-end in bytecomp that generates switches (attached), and = bootstrapped Emacs. Results: ---------------- In gnus-cloud-decode-data: lisp/gnus/gnus-cloud.el:154:6: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: base64-gzip In netrc-parse: lisp/obsolete/netrc.el:106:22: Warning: Duplicated value in =E2=80=98cond=E2= =80=99: "macdef" In org-read-date-analyze: lisp/org/org.el:14041:15: Warning: Duplicated value in =E2=80=98cond=E2=80= =99: "" In org-html-latex-fragment: lisp/org/ox-html.el:3099:8: Warning: Duplicated value in =E2=80=98cond=E2=80= =99: t ----------------- None of these are from `cl-case`. (`pcase` doesn't typically warn either = but just drops the duplicate silently.) I probably won't keep the warning because it's in the back-end and was = very much a hack. --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2 Content-Disposition: attachment; filename=bytecomp-cond-switch-dup-warn.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="bytecomp-cond-switch-dup-warn.diff" Content-Transfer-Encoding: 7bit diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el index 7feaf118b86..6bb95e7865b 100644 --- a/lisp/emacs-lisp/bytecomp.el +++ b/lisp/emacs-lisp/bytecomp.el @@ -4621,7 +4621,10 @@ byte-compile--cond-switch-prefix (setq switch-var var) (setq switch-test (byte-compile--common-test switch-test fn)) - (unless (member value keys) + (if (member value keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': %S" value) (push value keys) (push (cons (list value) (or body '(t))) cases)) t)))) @@ -4632,7 +4635,10 @@ byte-compile--cond-switch-prefix (setq switch-var var) (setq switch-test (byte-compile--common-test switch-test 'eq)) - (unless (memq nil keys) + (if (memq nil keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': nil") (push nil keys) (push (cons (list nil) (or body '(t))) cases)) t))) @@ -4655,7 +4661,10 @@ byte-compile--cond-switch-prefix (member . equal)))))) (let ((vals nil)) (dolist (elem value) - (unless (funcall fn elem keys) + (if (funcall fn elem keys) + (byte-compile-warn-x + (car clauses) + "Duplicated value in `cond': %S" elem) (push elem vals))) (when vals (setq keys (append vals keys)) --Apple-Mail=_171F92A5-E4D5-496C-8FA8-3038388E5AF2--