* bug#2205: My fix does not quite work
@ 2009-02-05 13:12 Keith Ponting
2011-10-05 5:30 ` bug#2205: electric-perl-terminator leaves point at beginning of line on error Glenn Morris
0 siblings, 1 reply; 2+ messages in thread
From: Keith Ponting @ 2009-02-05 13:12 UTC (permalink / raw
To: 2205
[-- Attachment #1: Type: text/plain, Size: 1694 bytes --]
A small postscript - the save-excursion fix I suggested does not quite
work as it leaves point _before_ the inserted terminator not after it.
The following rearrangement works around that:
(defun perl-electric-terminator (arg)
"Insert character and adjust indentation.
If at end-of-line, and not in a comment or a quote, correct the's
indentation."
(interactive "P")
(let ((insertpos (point)))
(and (not arg) ;
decide whether to indent
(eolp)
(save-excursion
(beginning-of-line)
(and (not ;
eliminate comments quickly
(and comment-start-skip
(re-search-forward
comment-start-skip insertpos t)) )
(or (/= last-command-char ?:)
;; Colon is special only after a
label ....
(looking-at
"\\s-*\\(\\w\\|\\s_\\)+$"))
(let ((pps (parse-partial-sexp
(perl-beginning-of-function) insertpos)))
(not (or (nth 3 pps) (nth 4 pps) (nth
5 pps))))))
(progn ; must insert,
indent, delete
(insert-char last-command-char 1)
(save-excursion (perl-indent-line))
(delete-char -1))))
(self-insert-command (prefix-numeric-value arg)))
Keith Ponting
Aurix Ltd, Malvern WR14 3SZ UK
[-- Attachment #2: Type: text/html, Size: 10459 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-05 5:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-05 13:12 bug#2205: My fix does not quite work Keith Ponting
2011-10-05 5:30 ` bug#2205: electric-perl-terminator leaves point at beginning of line on error Glenn Morris
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.