From: Dmitry Gutov <dgutov@yandex.ru>
To: "Daniel Martín" <mardani29@yahoo.es>, 49731@debbugs.gnu.org
Subject: bug#49731: 28.0.50; Filter xref results by filename
Date: Tue, 27 Jul 2021 02:28:58 +0300 [thread overview]
Message-ID: <030dbe6c-130d-e578-f50d-54e90bfa7cfa@yandex.ru> (raw)
In-Reply-To: <m1pmv6iz4n.fsf@yahoo.es>
Hi Daniel,
On 25.07.2021 11:19, Daniel Martín via Bug reports for GNU Emacs, the
Swiss army knife of text editors wrote:
>
> I plan to implement a new feature for xref, but I'd like to get some
> opinions first:
>
> Sometimes an xref backend returns a lot of results spread over several
> files. This usually happens in huge projects and for certain operations
> like "search references". To make them more manageable, I propose a new
> command that can filter xref result groups (typically filenames) by a
> regular expression. A user could filter by "tests/", or something like
> that, to only get results from unit tests. If you want to see a similar
> feature in action, go to
> https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/background/background_contents.cc;bpv=1;bpt=1
> and type on "Type to filter by file path", under the "References" tab.
This is going to be quite welcome.
> Right now the only approach I know for this use case is to use Isearch,
> but Isearch searches the entire xref buffer, including xref matches.
>
> What do you think about this new feature? Do you have any suggestions
> about how it should work?
We've discussed this sort of functionality before. Here are some
approaches (not mutually exclusive):
1. Add the possibility to add filtering by file names, types, etc,
before the search is done. This should fit 'project-find-regexp' well. I
can point you to a previous discussion with some ideas. The main upside
is you can speed up the search. And store such settings as a history.
2. Filter in the resulting Xref buffer. The best part is it can work
with the output from any command that uses Xref. The "filtering" is
temporary. I'm assuming this is the direction you want to work in.
3. Do some sort of "editable Xref buffer" feature where you can kill the
lines you don't want to see/use, with an undo history. This would
probably fit better together with another requested feature (wdired-like
editing).
I've never exactly considered the option 2., but I'd be happy to talk
the details. WRT UI, maybe something along the lines of
package-menu-filter-* commands, bound inside a '/' prefix. One command
could add "inclusion filter", another - "exclusion filter", and the
third one - reset all filters. '/ /' be bound to the last one.
The 'q' binding sounds iffy to be in that regard.
Another thing to keep an eye out for - is how the filtering will affect
n/p navigation and the xref-query-replace-in-results command. I think
they should respect the filtering as well.
next prev parent reply other threads:[~2021-07-26 23:28 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m1pmv6iz4n.fsf.ref@yahoo.es>
2021-07-25 8:19 ` bug#49731: 28.0.50; Filter xref results by filename Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 8:32 ` Lars Ingebrigtsen
2021-07-25 8:33 ` Lars Ingebrigtsen
2021-07-26 23:16 ` Dmitry Gutov
2021-07-25 9:10 ` Eli Zaretskii
2021-07-25 14:58 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-25 20:43 ` Juri Linkov
2021-07-26 11:49 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-26 22:53 ` Juri Linkov
2022-01-16 18:52 ` Juri Linkov
2022-11-21 7:58 ` Juri Linkov
2022-11-23 8:39 ` Juri Linkov
2022-11-23 14:19 ` Dmitry Gutov
2022-11-23 17:50 ` Juri Linkov
2022-11-23 18:08 ` Dmitry Gutov
2022-11-23 18:20 ` Juri Linkov
2022-11-23 18:47 ` Dmitry Gutov
2022-11-24 7:48 ` Juri Linkov
2022-11-25 7:35 ` Kévin Le Gouguec
2024-02-13 16:52 ` Juri Linkov
2024-02-14 9:25 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-15 7:23 ` Juri Linkov
2024-06-03 17:18 ` Juri Linkov
2024-06-04 6:34 ` Juri Linkov
2024-06-05 6:36 ` Juri Linkov
2021-07-26 23:28 ` Dmitry Gutov [this message]
2021-07-27 17:08 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-27 20:51 ` Juri Linkov
2021-07-27 23:11 ` Dmitry Gutov
2021-07-28 0:08 ` Dmitry Gutov
2021-07-28 16:12 ` Juri Linkov
2021-07-29 2:02 ` Dmitry Gutov
2021-07-29 17:43 ` Juri Linkov
2021-08-02 2:09 ` Dmitry Gutov
2021-08-02 20:58 ` Juri Linkov
2021-08-06 0:03 ` Dmitry Gutov
2021-07-31 16:45 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-07-31 17:06 ` Eli Zaretskii
2022-11-23 18:48 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=030dbe6c-130d-e578-f50d-54e90bfa7cfa@yandex.ru \
--to=dgutov@yandex.ru \
--cc=49731@debbugs.gnu.org \
--cc=mardani29@yahoo.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.