From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: master 583995c: GnuTLS HMAC and symmetric cipher support Date: Mon, 17 Jul 2017 18:14:42 -0400 Message-ID: <02lgnm1zjh.fsf@fencepost.gnu.org> References: <20170714150706.13106.18905@vcs0.savannah.gnu.org> <20170714150707.5E9B322DF8@vcs0.savannah.gnu.org> <87eftfdu5g.fsf@lifelogs.com> <7kzic356o4.fsf@fencepost.gnu.org> <34d18yexh0.fsf@fencepost.gnu.org> <2ztw2auan0.fsf@fencepost.gnu.org> <3f44fabe-80b7-8a01-2b64-0a33b2a311b3@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1500329704 2749 195.159.176.226 (17 Jul 2017 22:15:04 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 17 Jul 2017 22:15:04 +0000 (UTC) User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Cc: Emacs developers , Noam Postavsky To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 18 00:15:00 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXEI6-0000NL-MD for ged-emacs-devel@m.gmane.org; Tue, 18 Jul 2017 00:14:58 +0200 Original-Received: from localhost ([::1]:52787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXEIC-000740-1n for ged-emacs-devel@m.gmane.org; Mon, 17 Jul 2017 18:15:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXEI6-00073i-BN for emacs-devel@gnu.org; Mon, 17 Jul 2017 18:14:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXEI5-0001bv-KP for emacs-devel@gnu.org; Mon, 17 Jul 2017 18:14:58 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXEHq-0001Pl-Mt; Mon, 17 Jul 2017 18:14:42 -0400 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dXEHq-0001fe-AB; Mon, 17 Jul 2017 18:14:42 -0400 X-Spook: Skipjack supercomputer unclassified Sundevil X-Ran: ].D(90<+;`D^.WF (Paul Eggert's message of "Mon, 17 Jul 2017 14:58:44 -0700") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216807 Archived-At: Paul Eggert wrote: > Glenn Morris wrote: > >> Seems a bit like a happy accident?): > > It's not an accident, as every valid cipher etc. has a name. > >> 1. Fgnutls_ciphers. Can intern NULL and crash. >> const gnutls_cipher_algorithm_t *gciphers = gnutls_cipher_list (); >> for (ptrdiff_t pos = 0; gciphers[pos] != GNUTLS_CIPHER_NULL; pos++) >> { >> gnutls_cipher_algorithm_t gca = gciphers[pos]; >> Lisp_Object cipher_symbol = intern (gnutls_cipher_get_name (gca)); >> ... >> } > > It's OK, as every cipher other than GNUTLS_CIPHER_NULL has a non-NULL name. But it isn't OK. That's what this thread is about. GNUTLS_CIPHER_UNKNOWN apparently has a NULL name.