From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: Eshell's external pipe module interferes with other argument parsing hooks Date: Sun, 22 May 2022 21:34:30 -0700 Message-ID: <02a7cd10-6b40-76a3-2baa-6085800b1aa9@gmail.com> References: <70677cd2-f741-16d1-b38f-c39b507cc95e@gmail.com> <871qyij7vx.fsf@melete.silentflame.com> <877d89iy53.fsf@melete.silentflame.com> <0ac470ac-87e2-f3e9-7e23-28a6622ef082@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14769"; mail-complaints-to="usenet@ciao.gmane.io" To: Sean Whitton , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon May 23 06:36:53 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nszoL-0003fF-OS for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 06:36:53 +0200 Original-Received: from localhost ([::1]:33968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nszoK-0004hr-96 for ged-emacs-devel@m.gmane-mx.org; Mon, 23 May 2022 00:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38570) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nszm6-0003kA-AC for emacs-devel@gnu.org; Mon, 23 May 2022 00:34:34 -0400 Original-Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]:35375) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nszm4-0001gw-Ja for emacs-devel@gnu.org; Mon, 23 May 2022 00:34:33 -0400 Original-Received: by mail-pl1-x62c.google.com with SMTP id c2so12037179plh.2 for ; Sun, 22 May 2022 21:34:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=cuuat1f3o7bsYbF15esJOaXNTig3PECs09SRRMny56M=; b=LitQROGRGfvxfhxRm+jSB+cJvrPg7VA15NGHvI4fLUxywi56RSZ6eanwfy9y9Cd1NV VABa7dlrtBC7spYz5tIm9amRJBuqGtBmPUrniCTQbzQlAZ2ItSHtnQTfPY7xqbSq0jFB Qg317e4zyFL5W8dUu/V0NPdvkYgw31jSwr3rar67sKA+ES72kO+XcM8YUAA1Uv+2cwVr PNyTGTA2UtktveFMyXPXIozXaphLWySz3opotS605rHM4K9OabhPJvjToSFRkcu0/hns /hvSuhob5DVO+Lgn7Zoq5A0paNl3cm6idO8MPYQO/zUfozjuWSnB86kNPo3lB6IsBJAH xWWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=cuuat1f3o7bsYbF15esJOaXNTig3PECs09SRRMny56M=; b=tKbkgUm6HzHp72yk8VFW4aBndWMTimne2oG2OVnESoMLj6aVrB8Sa5z/azZDSgcecq URi+4gBQs0gJN+ubwYKIOj+3oPF6lZu04lSbNfRUV6SpthjU83bUBh6SrDm31G8x14I3 LQeOLXjKkJdJJQHSHYxIVFeVCLnwYp4FLVEwVmto81U1fFyQqqnFH2xRKNDjMHvfQ6gO ZDqhaFaaT4x2BiSpwz5zjUzYFXk/gUI6yKPzidOX6kWBxE1HrvWcSpQ1z1NK2qqRmu3O 9VQWWzkpPWp524Ywxj0/iAiN3yd6dagCU2z3SrKeA8Sw3EDhA2o2xGFvdtRx3LIf6SVB cwVA== X-Gm-Message-State: AOAM532pEYG0Frv6arHHEE8wPuVmGCGq4ihJwqC9/aecJjeIAOMMIpny Po+aPE59enZzvblewZ76iGFJmfW+hk8= X-Google-Smtp-Source: ABdhPJyUFCQ/rzEl0qSwCrQFYGgHk/P765/TSLJhiSCYhuCAVPt5hp5MSrx9lbn0vqy6sFbPPMn+lA== X-Received: by 2002:a17:90a:d01:b0:1e0:2e32:8650 with SMTP id t1-20020a17090a0d0100b001e02e328650mr8490530pja.156.1653280470987; Sun, 22 May 2022 21:34:30 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u9-20020a62ed09000000b005180df18990sm6040481pfh.168.2022.05.22.21.34.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 May 2022 21:34:30 -0700 (PDT) In-Reply-To: <0ac470ac-87e2-f3e9-7e23-28a6622ef082@gmail.com> Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::62c; envelope-from=jporterbugs@gmail.com; helo=mail-pl1-x62c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:290115 Archived-At: On 3/31/2022 4:11 PM, Jim Porter wrote: > On 3/31/2022 2:56 PM, Sean Whitton wrote: >> On Thu 31 Mar 2022 at 01:58PM -07, Jim Porter wrote: >>> 1) Eshell's built-in pipelines are slow because they go through Emacs >>> buffers. [snip] >>> For (1), Eshell could opportunistically use external pipelines without >>> any special syntax. > [snip] >> >> This could just be added to Eshell right now, right?  Definitely useful. > > Unless there's a reason for Eshell's current behavior that I'm not aware > of, I can't think of any problems with doing this, so long as everything > is escaped properly. On the subject of Eshell's built-in pipelines being slow, this might be of interest: . The author seems to have some interest in upstreaming the patch too[1]. I haven't had a chance to look at the patch in very much detail yet, but if this worked for all cases (apparently it's limited to PTY subprocesses for now, and I'm sure there are other cases where it would need to stay out of the way), it would be a huge improvement to "regular" Eshell pipes. - Jim [1] https://www.reddit.com/r/emacs/comments/usghki/comment/i93hkmv/?utm_source=reddit&utm_medium=web2x&context=3