From: "Mattias Engdegård" <mattiase@acm.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 42904@debbugs.gnu.org, alan@idiocy.org
Subject: bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS
Date: Mon, 17 Aug 2020 20:48:08 +0200 [thread overview]
Message-ID: <02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org> (raw)
In-Reply-To: <838sedgq2x.fsf@gnu.org>
17 aug. 2020 kl. 19.05 skrev Eli Zaretskii <eliz@gnu.org>:
> Well, it is always easier to special-case some use case, but we have
> general APIs for a reason. In particular, having several similar but
> subtly different functions is confusing and causes mistakes.
The new function is much simpler and easier to use than encode_string_utf_8 precisely for that reason: to avoid confusion and mistakes, both of which I got in spades when trying to use it.
> And you seem to be saying that encode_string_utf_8 doesn't work as
> advertised, which means it should be fixed.
Actually I don't know exactly how it is supposed to work so I wouldn't even say that. It's probably fine code but it's not for me, not in this case.
> So I would prefer to use encode_string_utf_8 if reasonably practical.
Well, it doesn't seem to be reasonably practical. In order to fix a bug, I prefer not having to fix some unrelated but complex code, especially when it is unclear how and if that code really can and/or should be 'fixed', and exactly what that would entail.
Now if, after the proposed patch has been applied, someone wants to refactor so that string_to_valid_utf_8 disappears or becomes implemented in terms of something else, then that's perfectly fine, as long as the bug remains fixed.
next prev parent reply other threads:[~2020-08-17 18:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 14:11 bug#42904: [PATCH] Non-Unicode frame title crashes Emacs on macOS Mattias Engdegård
2020-08-17 14:54 ` Andrii Kolomoiets
2020-08-17 15:55 ` Mattias Engdegård
2020-08-17 15:55 ` Eli Zaretskii
2020-08-17 16:11 ` Mattias Engdegård
2020-08-17 17:05 ` Eli Zaretskii
2020-08-17 18:48 ` Mattias Engdegård [this message]
2020-08-17 19:56 ` Alan Third
2020-08-18 8:07 ` Mattias Engdegård
2020-08-18 8:43 ` Alan Third
2020-08-18 11:48 ` Mattias Engdegård
2020-08-18 12:22 ` Eli Zaretskii
2020-08-18 17:28 ` Alan Third
2020-08-20 9:27 ` Mattias Engdegård
2020-08-20 13:24 ` Eli Zaretskii
2020-08-20 18:46 ` Mattias Engdegård
2020-08-20 19:13 ` Eli Zaretskii
2020-08-21 9:39 ` Mattias Engdegård
2020-08-21 13:26 ` Eli Zaretskii
2020-08-21 14:53 ` Mattias Engdegård
2020-08-21 15:27 ` Eli Zaretskii
2020-08-21 15:50 ` Mattias Engdegård
2020-08-23 17:23 ` Mattias Engdegård
2020-08-20 13:24 ` Alan Third
2020-08-20 17:44 ` Mattias Engdegård
2020-08-18 12:24 ` Eli Zaretskii
2020-08-18 14:11 ` Mattias Engdegård
2020-08-18 14:40 ` Eli Zaretskii
2020-08-18 15:21 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02F52D43-7EAB-4E61-A567-E8CCD11D856B@acm.org \
--to=mattiase@acm.org \
--cc=42904@debbugs.gnu.org \
--cc=alan@idiocy.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.