From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#66732: tree-sitter fontification doesn't update multi-line syntax reliably Date: Sun, 17 Dec 2023 01:09:08 +0200 Message-ID: <029f6911-c4f5-1217-73bf-f57b7f941ae2@gutov.dev> References: <878r7s5cdf.fsf@honnef.co> <83fs1tbou1.fsf@gnu.org> <835y1zo3rw.fsf@gnu.org> <2ce274aa-6d01-4d0a-b10c-07f821343fed@gmail.com> <50920549-006c-0153-2471-02e41a3dada7@gutov.dev> <8c7cd429-bdc3-4fac-ad1c-fbad793bf1a0@gmail.com> <231ebcd1-ec30-0432-82e7-d63e11cd65f7@gutov.dev> <765D713E-9923-4F66-9044-9D69C104C9B0@gmail.com> <33fe5d61-5022-67c5-6a65-babde4fb7f91@gutov.dev> <92CACD38-9534-4A07-8DE3-CE8408272FB6@gmail.com> <59CC46F7-867E-4C74-83EC-49B41DF0FAB8@gmail.com> <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38761"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: Eli Zaretskii , 66732@debbugs.gnu.org, dominik@honnef.co To: Yuan Fu , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 17 00:10:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rEdnh-0009rY-SD for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 17 Dec 2023 00:10:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rEdnY-0006Wr-C7; Sat, 16 Dec 2023 18:10:20 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rEdnF-0006VG-AJ for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 18:10:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rEdnF-0004W8-2J for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 18:10:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rEdnF-0005Ep-Rk for bug-gnu-emacs@gnu.org; Sat, 16 Dec 2023 18:10:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Dec 2023 23:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66732 X-GNU-PR-Package: emacs Original-Received: via spool by 66732-submit@debbugs.gnu.org id=B66732.170276815920077 (code B ref 66732); Sat, 16 Dec 2023 23:10:01 +0000 Original-Received: (at 66732) by debbugs.gnu.org; 16 Dec 2023 23:09:19 +0000 Original-Received: from localhost ([127.0.0.1]:56325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEdmZ-0005Dl-Cj for submit@debbugs.gnu.org; Sat, 16 Dec 2023 18:09:19 -0500 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51041) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rEdmX-0005DW-A8 for 66732@debbugs.gnu.org; Sat, 16 Dec 2023 18:09:18 -0500 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4EB435C00F8; Sat, 16 Dec 2023 18:09:11 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 16 Dec 2023 18:09:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1702768151; x=1702854551; bh=SqgF0Wtw8s1Xzs/qJfzFEGrYbClIxeVjgliIEG1a2SI=; b= RgNs8xiiAU4fSHl/qY1HM5i6ZX+1irKQngWbpCireXu/sM9xtKgMI70gtlUyFQUb lFnAU5tAtdMafuClS6A+2yvX2jiLsD+Yn20st0eftXb6ARVNp16W1u2p8Si8cXC3 4EcF1IUIXLPNhDpMPwXom+P7eK0xcEiLg3rajhO9n03P17thnX6aF1jXd2eyiu30 9rKp16zf19rL79tSpHtggBpZ2tkv9Q+L99eLuq6ctaFjcvWu2hxqMeRRUymLW9NV vVkz7qXySzUpDikliEk35Ns7lB0JvLfJyvp/oEqICQlvh6vdmRG7YpN6hBO0GS4i Nnp5Egi6lBJeSAjyX4PjiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1702768151; x= 1702854551; bh=SqgF0Wtw8s1Xzs/qJfzFEGrYbClIxeVjgliIEG1a2SI=; b=b 3EOV0fiHowvIAh8V6a1F+e5QA5i4p3UbUrZhBrkqRKVT8AgFcFKx2dLB7u5VeXXp mmT6wOS27dU9Hgq0UbEf6c/UJveMzqNwgOEFJ1yYYk+j2G6GELSzvEEeRWIsqjRX LlEDbOvo8v9qFgoCw+r4M+I9AyYSWW230yyQAeiksydo/q/QC+UQ5WrWBGxwETm2 XDX5cT7wpW1ZNTE5wP7wvqsaCJH58S4Ecm0koXki5lYIdGdWF9KAgdgm38sNcFL4 gw4V5MfVGcqwZd9QiAx9Zo7PqIIMnLA13u4JkchriMIuJzrmpke1yqJXEdpGVvZL 857qVDzo1yRqyKIEVRdaQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrvddthedgtdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepiefgteevheevveffheeltdeukeeiieekueefgedugfefgefhudelgfefveel vdevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Dec 2023 18:09:09 -0500 (EST) Content-Language: en-US In-Reply-To: <2C418114-3773-4D62-90CB-E4C7F1B7D467@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276390 Archived-At: On 16/12/2023 21:18, Yuan Fu wrote: >> Indeed we don't want to do it directly in `after-change-functions`, but >> doing it in `font-lock-default-fontify-region` is too late because the >> redisplay and jit-lock have already (to some extent) decided what should >> be refontified at that point. >> >> The infrastructure does offer ways to make it work (to fix previous >> incorrect assumptions about what needed to be redisplayed/refontified), >> but it's best if we can avoid it. > I tried forcing reparse in pre-redisplay-functions, and it seems to work fine! See attached diff. The delist part can be improved a bit, but this is just a POC. This also works.