From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#20625: 25.0.50; doc of `define-error` is incorrect Date: Sat, 30 Apr 2016 11:42:04 -0800 (GMT-08:00) Message-ID: <028438ba-c81a-4ebe-87a8-2057f7f0f9f5@default> References: <87h9eidhm0.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1462045428 9805 80.91.229.3 (30 Apr 2016 19:43:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Apr 2016 19:43:48 +0000 (UTC) Cc: 20625@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 30 21:43:35 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1awand-0000ih-L3 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 21:43:33 +0200 Original-Received: from localhost ([::1]:59452 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awanW-0006wB-H1 for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Apr 2016 15:43:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57170) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awanN-0006jE-8Q for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:43:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awanB-0003Eb-Hp for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:43:11 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:46139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awanB-0003Dg-EF for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:43:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1awan8-0008Gr-2u for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2016 15:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2016 19:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20625 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 20625-submit@debbugs.gnu.org id=B20625.146204533631740 (code B ref 20625); Sat, 30 Apr 2016 19:43:02 +0000 Original-Received: (at 20625) by debbugs.gnu.org; 30 Apr 2016 19:42:16 +0000 Original-Received: from localhost ([127.0.0.1]:58476 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awamO-0008Fr-Kn for submit@debbugs.gnu.org; Sat, 30 Apr 2016 15:42:16 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:48049) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awamN-0008Fe-1R for 20625@debbugs.gnu.org; Sat, 30 Apr 2016 15:42:15 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u3UJg7sv024188 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Apr 2016 19:42:08 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u3UJg7su014460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 30 Apr 2016 19:42:07 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u3UJg6DQ007316; Sat, 30 Apr 2016 19:42:06 GMT In-Reply-To: <87h9eidhm0.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6744.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117436 Archived-At: > > No, MESSAGE is not necessarily a string. It is a required argument, but > > the code explicitly makes use of the case where it is nil. And existin= g > > code delivered with Emacs (e.g. bookmark.el) makes use of a nil MESSAGE= . > > That case should be documented. >=20 > The function doesn't error out if MESSAGE isn't a string, but it still > shouldn't be. So I don't think that's a bug. >=20 > Feel free to submit a new bug report for bookmark.el not supplying a > string. I think it is too bad that `define-error', which was intended to be a friendly wrapper around using `error-conditions' directly, will no longer do all that the latter does. But so be it. Bug #23408 reported, for bookmark.el. Users who wrote similar code, expecting `define-error' to be like using `error-conditions', will need to likewise change their code.