all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 20625@debbugs.gnu.org
Subject: bug#20625: 25.0.50; doc of `define-error` is incorrect
Date: Sat, 30 Apr 2016 11:42:04 -0800 (GMT-08:00)	[thread overview]
Message-ID: <028438ba-c81a-4ebe-87a8-2057f7f0f9f5@default> (raw)
In-Reply-To: <87h9eidhm0.fsf@gnus.org>

> > No, MESSAGE is not necessarily a string. It is a required argument, but
> > the code explicitly makes use of the case where it is nil.  And existing
> > code delivered with Emacs (e.g. bookmark.el) makes use of a nil MESSAGE.
> > That case should be documented.
> 
> The function doesn't error out if MESSAGE isn't a string, but it still
> shouldn't be.  So I don't think that's a bug.
> 
> Feel free to submit a new bug report for bookmark.el not supplying a
> string.

I think it is too bad that `define-error', which was intended to
be a friendly wrapper around using `error-conditions' directly,
will no longer do all that the latter does.  But so be it.

Bug #23408 reported, for bookmark.el.  Users who wrote
similar code, expecting `define-error' to be like using
`error-conditions', will need to likewise change their
code.





  reply	other threads:[~2016-04-30 19:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 21:04 bug#20625: 25.0.50; doc of `define-error` is incorrect Drew Adams
2015-05-23 10:17 ` Eli Zaretskii
2016-04-30 19:25 ` Lars Ingebrigtsen
2016-04-30 19:42   ` Drew Adams [this message]
     [not found] <<b9eb3f53-8dec-4157-8a96-7634274687ac@default>
     [not found] ` <<83382n38et.fsf@gnu.org>
2015-05-23 14:48   ` Drew Adams
2015-05-23 14:57     ` Eli Zaretskii
2015-05-23 16:15     ` Stefan Monnier
2015-05-23 16:22       ` Drew Adams
     [not found] <<10eb5733-c84c-491d-86ca-2d6a05b80e7d@default>
     [not found] ` <<83oalb1gvn.fsf@gnu.org>
2015-05-23 16:02   ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=028438ba-c81a-4ebe-87a8-2057f7f0f9f5@default \
    --to=drew.adams@oracle.com \
    --cc=20625@debbugs.gnu.org \
    --cc=larsi@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.