From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master fails to build on FreeBSD when ACL support is on Date: Sat, 20 Jan 2018 19:41:32 -0800 Organization: UCLA Computer Science Department Message-ID: <025ce2fd-a69a-12da-ce5b-c894d5636789@cs.ucla.edu> References: <86o9lua0yx.fsf@phe.ftfl.ca> <834lnly8ht.fsf@gnu.org> <86vafy20sj.fsf@phe.ftfl.ca> <83o9lpuct5.fsf@gnu.org> <83lggtu1qn.fsf@gnu.org> <9dd64b10-78ce-c561-8c51-9e15b11e102c@cs.ucla.edu> <83bmhpt12i.fsf@gnu.org> <867escw93p.fsf@phe.ftfl.ca> <86vafwumqp.fsf@phe.ftfl.ca> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1516505999 30185 195.159.176.226 (21 Jan 2018 03:39:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Jan 2018 03:39:59 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 Cc: ashish@FreeBSD.org, monnier@IRO.UMontreal.CA, emacs-devel@gnu.org To: Joseph Mingrone , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jan 21 04:39:54 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ed6Tv-0006wE-CL for ged-emacs-devel@m.gmane.org; Sun, 21 Jan 2018 04:39:43 +0100 Original-Received: from localhost ([::1]:57416 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed6Vv-0003Wu-OQ for ged-emacs-devel@m.gmane.org; Sat, 20 Jan 2018 22:41:47 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45076) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ed6Vp-0003WC-60 for emacs-devel@gnu.org; Sat, 20 Jan 2018 22:41:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ed6Vo-0000em-A6 for emacs-devel@gnu.org; Sat, 20 Jan 2018 22:41:41 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49924) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ed6Vk-0000Yq-FM; Sat, 20 Jan 2018 22:41:36 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id F3C5516157F; Sat, 20 Jan 2018 19:41:33 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pE5OnhDbMdSu; Sat, 20 Jan 2018 19:41:33 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 46D981615C9; Sat, 20 Jan 2018 19:41:33 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id sE84t1cJoeJZ; Sat, 20 Jan 2018 19:41:33 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1863716157F; Sat, 20 Jan 2018 19:41:33 -0800 (PST) In-Reply-To: <86vafwumqp.fsf@phe.ftfl.ca> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:222117 Archived-At: Joseph Mingrone wrote: > the problem only seems to occur when /tmp supports ACLs, > but $WRKDIR (location where the tarball is extracted and the build > occurs) does not. The problem occurs because (rename-file A B) signals an error if A has AC= Ls and=20 B's file system does not support ACLs. This is because rename-file calls=20 (copy-file A B nil t t t) and that last "t" tells copy-file to copy ACLs. Creating a temporary file right next to the original file should fix the = problem=20 for bytecomp.el, since rename-file won't be crossing file system boundari= es. The more-general question is whether rename-file should fail in this situ= ation.=20 It is a bit of an edge case. From code inspection it appears that GNU 'mv= A B'=20 issues a warning diagnostic but does not fail (i.e., it does not exit wit= h=20 nonzero status).