all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jens Schmidt <jschmidt4gnu@vodafonemail.de>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded.
Date: Wed, 6 Dec 2023 21:50:38 +0100	[thread overview]
Message-ID: <020ab182-0e3d-4e8d-9415-c93863b95638@vodafonemail.de> (raw)
In-Reply-To: <jwvy1e8i6o4.fsf-monnier+emacs@gnu.org>

On 2023-12-06  00:20, Stefan Monnier wrote:

> How 'bout we fix this as well?

I'd be glad if you can sort this out.  However, there is a second
advice to be considered in ls-lisp.el, which you have not mentioned
yet:

(advice-add 'dired :around #'ls-lisp--dired)

AFAIU it fixes a special case where a file name contains wildcards
and ends in a slash:

          ;; When the wildcard ends in a slash, file-expand-wildcards
          ;; returns nil; fix that by treating the wildcards as
          ;; specifying only directories whose names match the
          ;; widlcard.

I'm too lazy to check the history of this advice (and of
`file-expand-wildcards') right now, but this seems to be like a
stray bug fix that got implemented as an advice.



  parent reply	other threads:[~2023-12-06 20:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <170177277759.6083.12155719482709043212@vcs2.savannah.gnu.org>
     [not found] ` <20231205103937.E1D65C405A8@vcs2.savannah.gnu.org>
2023-12-05 23:20   ` master 19a3b499f84: ; * lisp/loadup.el: Don't prohibit advice when ls-lisp is loaded Stefan Monnier
2023-12-06  1:18     ` Po Lu
2023-12-06 12:14     ` Eli Zaretskii
2023-12-06 16:12       ` Stefan Monnier
2023-12-06 17:07         ` Eli Zaretskii
2023-12-06 21:32           ` Stefan Monnier
2023-12-07  6:19             ` Eli Zaretskii
2023-12-06 20:50     ` Jens Schmidt [this message]
2023-12-07 20:06       ` Stefan Monnier
2023-12-07 22:25         ` Jens Schmidt
2023-12-09 20:09           ` Stefan Monnier
2023-12-09 23:26           ` Stefan Monnier
2023-12-10  5:10           ` Stefan Monnier
2023-12-12 21:22             ` Jens Schmidt
2023-12-21 14:40               ` Stefan Monnier
2023-12-07  2:49     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=020ab182-0e3d-4e8d-9415-c93863b95638@vodafonemail.de \
    --to=jschmidt4gnu@vodafonemail.de \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.