From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation Date: Sat, 9 Mar 2024 10:28:49 -0800 Message-ID: <01f33c40-6bd5-7770-d763-dc119254bc76@gmail.com> References: <87cys4enc4.fsf@posteo.net> <97befab2-f39a-9aac-41c6-cf1d4964aad8@gmail.com> <87cys3dbhp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20631"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69647@debbugs.gnu.org, =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 09 19:30:47 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rj1T4-0005Ck-Kk for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Mar 2024 19:30:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rj1St-0007yI-FB; Sat, 09 Mar 2024 13:30:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rj1Sn-0007xV-MF for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 13:30:30 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rj1Sn-0002Yg-ED for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 13:30:29 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rj1TK-0006Ae-5y for bug-gnu-emacs@gnu.org; Sat, 09 Mar 2024 13:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Mar 2024 18:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69647 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69647-submit@debbugs.gnu.org id=B69647.171000903923686 (code B ref 69647); Sat, 09 Mar 2024 18:31:02 +0000 Original-Received: (at 69647) by debbugs.gnu.org; 9 Mar 2024 18:30:39 +0000 Original-Received: from localhost ([127.0.0.1]:34784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj1Sv-00069x-2Q for submit@debbugs.gnu.org; Sat, 09 Mar 2024 13:30:38 -0500 Original-Received: from mail-oi1-f179.google.com ([209.85.167.179]:46557) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rj1So-00069W-LY for 69647@debbugs.gnu.org; Sat, 09 Mar 2024 13:30:36 -0500 Original-Received: by mail-oi1-f179.google.com with SMTP id 5614622812f47-3c23f3ffd1eso283089b6e.1 for <69647@debbugs.gnu.org>; Sat, 09 Mar 2024 10:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710008932; x=1710613732; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=LWhgYUFxKzaV4iI5VZF5he+Gl2k10v2KVfAmrG8cemU=; b=RaYZGbDVuX2479HRZQ3mOMJe8wRBaWNoW1CRIJJVDSxV68l1RYrjDP9v6MTzY/hHtT zyBazWw88C7/wAtmtFWEaI/ikXl86MYabucUViroTVyMZvPIVQwg5NxKlvHxXTGSapWS fid9WnWs49o8aB57s9IS3RUhoUlL/DR0j819rAbeJZTg0KNxOLZXLH/HRr2ph4J7mlWx g4kMCi1OOvgxHNm1D2pB4kV7KGeMoNmrNxpAQXqItLOR1heVrkW9ezCEdrNAKaYqdAPS 9yn7t6cQYOnZVJVQJEWBfDKnVZKf0tn2gHTLijMLfe16tKo4BHbBy2odB0vNgXZz0D7V A84g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710008932; x=1710613732; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LWhgYUFxKzaV4iI5VZF5he+Gl2k10v2KVfAmrG8cemU=; b=JcCkBd8tCCxg+UgjIObJG1eQab8+KfPm9oBpTBLHzkjK2w0gqXhp5TUtveol0GXqGt OUGdlB0W4sAd7rhMXoWlVyRhlFZ9BvzDeFWv7F7rBkhteYthgydAJ+tDfTcpnRQGB6P1 nf2SjEzqe/NqBFBQMA2f14jbN9lxM4rN+IuuUyP2VURZ0K0zLnWgQxdiRX+K/CyB6yAo qHar8+d8pmwBLZEZxlPirTEou17jlkT23ev7ErM3UroGoxTlEnzLxS00YR2fpgHjvD/s fu97yufx7r/Xj8VxWHCyFKqpWTNqljpqZA+uqHt6tzCCBdHQMTeISnmtDOKAR4eT6mfg Es0g== X-Gm-Message-State: AOJu0Ywu5aRIMLYVkTqtu9/QrTbtB7WapcXKCMC2Ek3TI8MvXMWB8zGA d9lRP/5AXMNgxZQAKnIWCdHmlNHT65646UbEeG50i2J2hBYOFUzl X-Google-Smtp-Source: AGHT+IEnyv29WqxNnL3d/ZjF4XKHDAQzMZvJFAVOCNap0eMvcSMTdRMID7NzRehNv5JievMb15nItQ== X-Received: by 2002:a05:6808:1993:b0:3c1:a268:5bac with SMTP id bj19-20020a056808199300b003c1a2685bacmr2959920oib.55.1710008931955; Sat, 09 Mar 2024 10:28:51 -0800 (PST) Original-Received: from [192.168.1.2] (076-168-148-233.res.spectrum.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ka22-20020a056a00939600b006e6795960d5sm1368146pfb.192.2024.03.09.10.28.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 09 Mar 2024 10:28:51 -0800 (PST) Content-Language: en-US In-Reply-To: <87cys3dbhp.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:281351 Archived-At: I've filed a PR against markdown-mode with my patch here: . On 3/9/2024 1:02 AM, Philip Kaludercic wrote: > Seems fine. The only concern I have is if someone who enabled > `show-trailing-whitespace' would still get highlighted line-endings, but > I guess that's on markdown-mode to solve. At least in this case, I think we should be ok, since I made markdown-view-mode *hide* the trailing spaces entirely (rather than just not fontifying them). However, there could be other trailing spaces that *aren't* Markdown line break syntax that could leak through. > Does my patch have to be updated, or can we discard it then? I think we could discard that one, unless there are still some issues with trailing whitespace in the Eldoc buffer.