all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jim Porter <jporterbugs@gmail.com>
To: Philip Kaludercic <philipk@posteo.net>
Cc: 69647@debbugs.gnu.org, "João Távora" <joaotavora@gmail.com>
Subject: bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation
Date: Sat, 9 Mar 2024 10:28:49 -0800	[thread overview]
Message-ID: <01f33c40-6bd5-7770-d763-dc119254bc76@gmail.com> (raw)
In-Reply-To: <87cys3dbhp.fsf@posteo.net>

I've filed a PR against markdown-mode with my patch here: 
<https://github.com/jrblevin/markdown-mode/pull/826>.

On 3/9/2024 1:02 AM, Philip Kaludercic wrote:
> Seems fine.  The only concern I have is if someone who enabled
> `show-trailing-whitespace' would still get highlighted line-endings, but
> I guess that's on markdown-mode to solve.

At least in this case, I think we should be ok, since I made 
markdown-view-mode *hide* the trailing spaces entirely (rather than just 
not fontifying them). However, there could be other trailing spaces that 
*aren't* Markdown line break syntax that could leak through.

> Does my patch have to be updated, or can we discard it then?

I think we could discard that one, unless there are still some issues 
with trailing whitespace in the Eldoc buffer.





  reply	other threads:[~2024-03-09 18:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-08 15:48 bug#69647: [PATCH 1/2] Delete trailing whitespace when formatting LSP documentation Philip Kaludercic
2024-03-08 20:41 ` João Távora
2024-03-08 20:54 ` Jim Porter
2024-03-08 21:02   ` João Távora
2024-03-08 21:36     ` Jim Porter
2024-03-09  3:08       ` Jim Porter
2024-03-09  9:02         ` Philip Kaludercic
2024-03-09 18:28           ` Jim Porter [this message]
2024-03-09 18:46             ` Philip Kaludercic
2024-03-11  3:50             ` Jim Porter
2024-03-22  8:49               ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01f33c40-6bd5-7770-d763-dc119254bc76@gmail.com \
    --to=jporterbugs@gmail.com \
    --cc=69647@debbugs.gnu.org \
    --cc=joaotavora@gmail.com \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.