From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict Date: Tue, 31 Jan 2023 13:49:11 +0100 Message-ID: <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <83o7qe3nwr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jan 31 15:55:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMs2Y-000AcE-Db for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 31 Jan 2023 15:55:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pMqzb-0004WB-He; Tue, 31 Jan 2023 08:48:11 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMqzT-0004Vg-H0 for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 08:48:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMqzS-0007K2-V9 for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 08:48:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pMqzS-0007bj-AW for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 08:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 Jan 2023 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61184 X-GNU-PR-Package: emacs Original-Received: via spool by 61184-submit@debbugs.gnu.org id=B61184.167517286029198 (code B ref 61184); Tue, 31 Jan 2023 13:48:02 +0000 Original-Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 13:47:40 +0000 Original-Received: from localhost ([127.0.0.1]:51867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMqz6-0007as-32 for submit@debbugs.gnu.org; Tue, 31 Jan 2023 08:47:40 -0500 Original-Received: from server.qxqx.de ([178.63.65.180]:43631 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMqz2-0007aZ-Fx for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 08:47:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E7IO4uXFmwce5IiSw9igEi2OYrlXIdoMEIj2X8Tc66k=; b=vShckToR7aL6pYZRu5FG7gcZxq Xh+WYil8+iUz3SUUPFhJtk9SQBXqQqQxdKOIO5udBwao6A7DwbPjmFxPNRn9xjaF/0xlAVjRMDdJp gxdjck8fPtM/CLA+Pq4b++iDy+9A+oiIa+C1oE0mwIJ4/4eyHSoC2J7mChBqcpjIEVnA=; Content-Language: en-US In-Reply-To: <83o7qe3nwr.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254523 Archived-At: On 1/31/23 13:10, Eli Zaretskii wrote: >> Cc: Lars Ingebrigtsen , Robert Pluim , >> Stefan Monnier >> Date: Mon, 30 Jan 2023 21:52:54 +0100 >> From: Daniel Mendler >> >> In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands >> keymap-local-set and keymap-global-set became less strict for >> non-interactive use, which is not the intended the design. > > Please tell more about that, because I don't yet see how that commit > made the non-interactive (and only non-interactive) invocations check > the argument less strictly. The function became less strict since it also accepts vector arguments now. The intended design by Lars was to only accept strings, and only strings which are valid according to `key-valid-p'. Daniel