From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Building master fails on Windows 10 when testing etc/NEWS file Date: Thu, 19 Sep 2019 00:27:58 -0700 Organization: UCLA Computer Science Department Message-ID: <01cd8c7a-f72a-fb0c-0ac0-5376e69f2aec@cs.ucla.edu> References: <1d388216-eed3-ed6f-5710-18d38daefe58@cs.ucla.edu> <83d0fxvkz7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------528241ED155A8E307F810366" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="121212"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 Cc: rcopley@gmail.com, lekktu@gmail.com, emacs-devel@gnu.org, rudalics@gmx.at To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 19 09:28:15 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iAqrO-000VPE-5K for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2019 09:28:14 +0200 Original-Received: from localhost ([::1]:39450 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAqrM-0003b5-T0 for ged-emacs-devel@m.gmane.org; Thu, 19 Sep 2019 03:28:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55298) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iAqrG-0003aq-CQ for emacs-devel@gnu.org; Thu, 19 Sep 2019 03:28:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iAqrF-0004Xr-B1 for emacs-devel@gnu.org; Thu, 19 Sep 2019 03:28:06 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40098) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iAqrD-0004Vg-4B; Thu, 19 Sep 2019 03:28:03 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 402551605E4; Thu, 19 Sep 2019 00:28:00 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id xeKt71TlePa2; Thu, 19 Sep 2019 00:27:59 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6C0391605E7; Thu, 19 Sep 2019 00:27:59 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 49H_xErRJoQT; Thu, 19 Sep 2019 00:27:59 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 16BCB1605E4; Thu, 19 Sep 2019 00:27:59 -0700 (PDT) In-Reply-To: <83d0fxvkz7.fsf@gnu.org> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:240159 Archived-At: This is a multi-part message in MIME format. --------------528241ED155A8E307F810366 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 9/18/19 5:37 AM, Eli Zaretskii wrote: >> Is the MS-Windows tradition to pretend that permission is denied to >> every missing directory? > Yes. OK, that explains why these problems cropped up on MS-Windows platforms even though I didn't see them on GNU/Linux. Since defining PICKY_EACCES helped to find a configuration-related bug on GNU/Linux (Bug#37445) I would like to try it out on GNUish platforms, so I installed the attached. We can easily revert if it causes more problems than it cures. --------------528241ED155A8E307F810366 Content-Type: text/x-patch; name="0001-Default-PICKY_ACCESS-to-false-on-non-MS.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Default-PICKY_ACCESS-to-false-on-non-MS.patch" >From 30026cfe666e9647aeef73e26df5ffca2fa2c662 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 19 Sep 2019 00:19:11 -0700 Subject: [PATCH] Default PICKY_ACCESS to false on non-MS * src/fileio.c (PICKY_EACCES) [!DOS_NT]: Default to false. --- src/fileio.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/fileio.c b/src/fileio.c index 5337ea5c80..b2896c1fe1 100644 --- a/src/fileio.c +++ b/src/fileio.c @@ -257,12 +257,16 @@ file_attribute_errno (Lisp_Object file, int err) be checked further because they may be problems with an ancestor directory instead of with the file itself, which means that we don't have reliable info about the requested file. In practice, - though, such errors are common enough that signaling them can be - annoying even if the errors are real (e.g., Bug#37445). So return - nil for EACCES unless compiling with -DPICKY_EACCES, which is off - by default. */ + though, DOS_NT platforms set errno to EACCES for missing files like + "/var/mail", so signaling EACCES errors would be a mistake there. + So return nil for EACCES unless PICKY_EACCES, which is false by + default on DOS_NT. */ #ifndef PICKY_EACCES +# ifdef DOS_NT enum { PICKY_EACCES = false }; +# else +enum { PICKY_EACCES = true }; +# endif #endif Lisp_Object -- 2.17.1 --------------528241ED155A8E307F810366--