Re: Building master fails on Windows 10 when testing etc/NEWS file

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

On 9/18/19 5:37 AM, Eli Zaretskii wrote:
>> Is the MS-Windows tradition to pretend that permission is denied to
>> every missing directory?
> Yes.

OK, that explains why these problems cropped up on MS-Windows platforms even 
though I didn't see them on GNU/Linux.

Since defining PICKY_EACCES helped to find a configuration-related bug on 
GNU/Linux (Bug#37445) I would like to try it out on GNUish platforms, so I 
installed the attached. We can easily revert if it causes more problems than it 
cures.

[-- Attachment #2: 0001-Default-PICKY_ACCESS-to-false-on-non-MS.patch --]
[-- Type: text/x-patch, Size: 1362 bytes --]

From 30026cfe666e9647aeef73e26df5ffca2fa2c662 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 19 Sep 2019 00:19:11 -0700
Subject: [PATCH] Default PICKY_ACCESS to false on non-MS

* src/fileio.c (PICKY_EACCES) [!DOS_NT]: Default to false.
---
 src/fileio.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/fileio.c b/src/fileio.c
index 5337ea5c80..b2896c1fe1 100644
--- a/src/fileio.c
+++ b/src/fileio.c
@@ -257,12 +257,16 @@ file_attribute_errno (Lisp_Object file, int err)
    be checked further because they may be problems with an ancestor
    directory instead of with the file itself, which means that we
    don't have reliable info about the requested file.  In practice,
-   though, such errors are common enough that signaling them can be
-   annoying even if the errors are real (e.g., Bug#37445).  So return
-   nil for EACCES unless compiling with -DPICKY_EACCES, which is off
-   by default.  */
+   though, DOS_NT platforms set errno to EACCES for missing files like
+   "/var/mail", so signaling EACCES errors would be a mistake there.
+   So return nil for EACCES unless PICKY_EACCES, which is false by
+   default on DOS_NT.  */
 #ifndef PICKY_EACCES
+# ifdef DOS_NT
 enum { PICKY_EACCES = false };
+# else
+enum { PICKY_EACCES = true };
+# endif
 #endif
 
 Lisp_Object
-- 
2.17.1