all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Bozhidar Batsov" <bozhidar@batsov.dev>
To: "Emacs Devel" <emacs-devel@gnu.org>
Subject: Re: [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var
Date: Wed, 02 Feb 2022 15:40:03 +0200	[thread overview]
Message-ID: <01c56965-15a3-4386-9322-2601f72a103e@www.fastmail.com> (raw)
In-Reply-To: <jwv5ypxh0ad.fsf-monnier+emacs@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Thanks for the feedback. I'll change this right away. 

On Wed, Feb 2, 2022, at 3:23 PM, Stefan Monnier wrote:
> >  (eval-when-compile
> >    (defvar calculate-lisp-indent-last-sexp)
> > +  (defvar delete-pair-blink-delay)
> >    (defvar font-lock-beg)
> >    (defvar font-lock-end)
> >    (defvar paredit-space-for-delimiter-predicates)
> 
> `defvar` (when given a single argument) is a compiler directive whose
> execution has no effect.
> 
> The fact that it also works when placed inside `eval-when-compile` is an
> accident (and a bug: it should only affect the rest of the code within
> the `eval-when-compile`).
> 
> Please move those out of `eval-when-compile`.
> 
> 
>         Stefan
> 
> 
> 

[-- Attachment #2: Type: text/html, Size: 1325 bytes --]

      reply	other threads:[~2022-02-02 13:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <164379973260.10900.5488380383299537790@vcs2.savannah.gnu.org>
     [not found] ` <20220202110212.D3908C002F7@vcs2.savannah.gnu.org>
2022-02-02 13:23   ` [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var Stefan Monnier
2022-02-02 13:40     ` Bozhidar Batsov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01c56965-15a3-4386-9322-2601f72a103e@www.fastmail.com \
    --to=bozhidar@batsov.dev \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.