From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eli Zaretskii" Newsgroups: gmane.emacs.devel Subject: Re: executable-find in files.el Date: Thu, 12 May 2005 01:56:43 +0300 Message-ID: <01c5567c$Blat.v2.4$d8bc9c20@zahav.net.il> References: <01c55657$Blat.v2.4$7979dc20@zahav.net.il> <87fywt6128.fsf-monnier+emacs@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: main.gmane.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7BIT X-Trace: sea.gmane.org 1115852320 6804 80.91.229.2 (11 May 2005 22:58:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 11 May 2005 22:58:40 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 12 00:58:35 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DW09S-0004gQ-BK for ged-emacs-devel@m.gmane.org; Thu, 12 May 2005 00:58:03 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DW0IG-0001OM-JC for ged-emacs-devel@m.gmane.org; Wed, 11 May 2005 19:07:08 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DW0Fe-00011P-6c for emacs-devel@gnu.org; Wed, 11 May 2005 19:04:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DW0Fb-0000zL-7v for emacs-devel@gnu.org; Wed, 11 May 2005 19:04:23 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DW0Fb-0000yB-3h for emacs-devel@gnu.org; Wed, 11 May 2005 19:04:23 -0400 Original-Received: from [192.114.186.24] (helo=legolas.inter.net.il) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DW0Hw-0001Tx-D6 for emacs-devel@gnu.org; Wed, 11 May 2005 19:06:48 -0400 Original-Received: from zaretski (IGLD-83-130-254-105.inter.net.il [83.130.254.105]) by legolas.inter.net.il (MOS 3.5.6-GR) with ESMTP id EIV03180 (AUTH halo1); Thu, 12 May 2005 01:59:53 +0300 (IDT) Original-To: Stefan Monnier X-Mailer: emacs 22.0.50 (via feedmail 8 I) and Blat ver 2.4 In-reply-to: <87fywt6128.fsf-monnier+emacs@gnu.org> (message from Stefan Monnier on Wed, 11 May 2005 15:07:36 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:36998 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:36998 > Cc: emacs-devel@gnu.org > From: Stefan Monnier > Date: Wed, 11 May 2005 15:07:36 -0400 > > > Passing 1 as last arg of locate-file is subtly different from passing > > file-executable-p. I think the latter does a better job, so I think > > executable-find should use file-executable-p. > > Have you read the comment you quoted? Yes. But since you obviously didn't read my identical comment posted in response to your suggestion to do what you just did in this version of executable-find (or perhaps you read it, but disregarded it), I posted the same comment again. > What do you reply to that? Did you read my message? That's my answer to it. > Do you think it's more important to "do a subtly better job" or to "match > the behavior of call-process"? I think they should do the same. But the original executable-find used file-executable-p, so your change is subtly incompatible, unless you change openp to use the same method as file-executable-p. > In my view, the point of executable-find is to figure out whether there is > a command that we can run. If it tells us "I found /ssh:foo/bar/baz", but > then call-process fails because it doesn't work through Tramp, I think it's > a problem. I agree. But the solution should be to make all 3 of these do exactly the same job in exactly the same way.