Re: face colors on 256 colors terminals

["Eli Zaretskii" <eliz@gnu.org>]

> Cc: emacs-devel@gnu.org
> From: Dan Nicolaescu <dann@ics.uci.edu>
> Date: Wed, 06 Apr 2005 14:34:06 -0700
> 
> "Eli Zaretskii" <eliz@gnu.org> writes:
> 
>   > > From: Dan Nicolaescu <dann@ics.uci.edu>
>   > > Some standard face definitions use colors like "red" or "blue". They 
>   > > should be changed "red1" (or "blue1")
>   > 
>   > Yes, I agree.  Can you post a patch to do that?
> 
> Here it is. It replaces: 
> 	red->red1
> 	green->green1
> 	blue->blue1
> 	yellow->yellow1
> 	cyan->cyan1
> 	magenta->magenta1
> 
> The replacements were done so that not change anything for faces that
> had a special treatment for ttys, pc, etc. 

Thanks.

> Is this OK? 
> 
> Index: lisp/comint.el
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lisp/comint.el,v
> retrieving revision 1.310
> diff -c -3 -p -r1.310 comint.el
> *** lisp/comint.el	5 Apr 2005 01:21:23 -0000	1.310
> --- lisp/comint.el	6 Apr 2005 21:24:52 -0000
> *************** This variable is buffer-local."
> *** 228,234 ****
>     :group 'comint)
>   
>   (defface comint-highlight-prompt
> !   '((((background dark)) (:foreground "cyan"))
>       (t (:foreground "dark blue")))
>     "Face to use to highlight prompts."
>     :group 'comint)
> --- 228,234 ----
>     :group 'comint)
>   
>   (defface comint-highlight-prompt
> !   '((((background dark)) (:foreground "cyan1"))
>       (t (:foreground "dark blue")))
>     "Face to use to highlight prompts."
>     :group 'comint)

Hmmm... "bother", as they say.  The changes to the face colors that
are under (min-colors 88) or when there's a separate color for less
color-capable displays are okay.  But there are few cases where
there's a single color definition, like the one above, which is
applicable to all color-capable displays.  In these cases, the changes
you suggest will have a significant effect on 16-color text terminals,
because cyan1, blue1, red1 etc. are translated to the bright shades of
the respective colors, so what was red will now be brightred.  The
bright shades are quite annoying in many situations.

So I think we should change this patch so as not to change the color
definitions on displays that support less than 88 colors.  That is, in
those cases where there's a single color definition, split it into 2
and change only the one for >88 colors.